fix: 30726 A blank spot appears after deleting a money request by tienifr · Pull Request #31670 · Expensify/App

tienifr · 2023-11-22T04:42:59Z

Details

Fixed Issues

$ #30726
PROPOSAL: #30726 (comment)

Tests

Request money manually form Fab menu
Select user
Add receipt
Select from Gallery
Complete request
Open Request
Select tree dot and select Delete Request
Verify that NO blank spot appears after deleting a money request

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Request money manually form Fab menu
Select user
Add receipt
Select from Gallery
Complete request
Open Request
Select tree dot and select Delete Request
Verify that NO blank spot appears after deleting a money request

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-22.at.15.48.16.mov

Android: mWeb Chrome

Screen.Recording.2023-11-22.at.15.16.48.mov

iOS: Native

Screen.Recording.2023-11-02.at.15.06.19.mov

iOS: mWeb Safari

Screen.Recording.2023-11-22.at.14.28.04.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-22.at.14.19.58.mp4

MacOS: Desktop

Screen.Recording.2023-11-22.at.14.24.46.mp4

melvin-bot · 2023-11-22T07:30:09Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2023-11-22T07:44:39Z

Should we use

const previousLastIndex = useRef(sortedReportActions[0].reportActionID) // we can use useRef here

    useEffect(()=>{
        if(previousLastIndex.current !== sortedReportActions[0].reportActionID && reportActionSize.current > sortedReportActions.length){
            reportScrollManager.scrollToBottom()
        }
       previousLastIndex.current = sortedReportActions[0].reportActionID;
    }, [sortedReportActions[0].reportActionID])

tienifr · 2023-11-22T08:52:27Z

@shubham1206agra Updated

shubham1206agra · 2023-11-22T08:53:40Z

One last thing
Do we still need autoScrollToTopThreshold?

shubham1206agra · 2023-11-22T08:54:14Z

Can you check if this doesn't break any other test defined #30461?

tienifr · 2023-11-24T02:50:20Z

@shubham1206agra
If we apply this PR, these tests work well without autoScrollToTopThreshold

But we should not remove autoScrollToTopThreshold. autoScrollToTopThreshold is added into BaseInvertedFlatList and it's used in other places as well. I'm afraid that removing autoScrollToTopThreshold can cause the regressions

shubham1206agra · 2023-11-24T03:25:17Z

@tienifr No other component is using InvertedFlatList. So I think its safe to remove this.

tienifr · 2023-11-27T03:10:49Z

Agree with you, I just updated the PR

shubham1206agra · 2023-12-03T14:01:04Z

Screen.Recording.2023-12-03.at.7.26.55.PM.mov

@tienifr Can you check this problem occuring on iOS native?

tienifr · 2023-12-04T03:23:23Z

@shubham1206agra you mean the problem when the IOU preview is not present unless we scroll up and down?

shubham1206agra · 2023-12-04T03:25:13Z

Both the original problem we are trying to solve and the one you mentioned just now

tienifr · 2023-12-05T11:08:57Z

@shubham1206agra

After removing autoscrollToTopThreshold we have to have the logic to scrollToBottom when the new message is coming, although we already have this logic here, but we don't wait for animation end so it does not work properly. To fix that we can wrap this function into actionManager.runAfterInteractions
In here we hide the report action if it's pendingAction is delete (As the video I recorded before it show the skeleton but I don't know why it disappears for now), but the sortedReportAction still contains the pending deleted action so it takes more time for the actions is actually deleted. So I updated my PR a bit to filter out the deleted action

Result

Screen.Recording.2023-12-05.at.17.55.21.mov

shubham1206agra · 2023-12-05T11:47:53Z

@tienifr Thanks for the update.
But I think it should show skeleton there when pending delete action is there.
Let me ask this in slack.

shubham1206agra · 2023-12-06T07:40:55Z

@tienifr In MoneyRequestPreview, we are not passing pendingAction, so how will here condition will be evaluated to true?
Can you point me to the line responsible for this behaviour?

tienifr · 2023-12-07T04:03:38Z

@shubham1206agra We put the pendingAction here

App/src/pages/home/report/ReportActionItem.js

Line 692 in 43b1722

pendingAction={props.draftMessage ? null : props.action.pendingAction}

shubham1206agra · 2023-12-07T04:42:53Z

Can you tell me why skeleton was removed in #26939?

shubham1206agra · 2023-12-08T18:29:27Z

@tienifr bump

tienifr · 2023-12-18T03:36:58Z

merged

shubham1206agra · 2023-12-18T05:25:59Z

@tienifr Can you fix the lint error here?

shubham1206agra · 2023-12-18T08:34:02Z

@tienifr This will not work as reportActionSize never gets a new value

tienifr · 2023-12-18T08:35:23Z

@shubham1206agra Yes, I just noticed that, I'm checking why it's removed

tienifr · 2023-12-18T09:34:01Z

updated

shubham1206agra · 2023-12-19T07:48:45Z

Screen.Recording.2023-12-19.at.1.14.41.PM.mov

@tienifr Attachment is not autoscrolling to end

shubham1206agra · 2023-12-19T08:31:56Z

@shubham1206agra If we apply this PR, these tests work well without autoScrollToTopThreshold

But we should not remove autoScrollToTopThreshold. autoScrollToTopThreshold is added into BaseInvertedFlatList and it's used in other places as well. I'm afraid that removing autoScrollToTopThreshold can cause the regressions

Lets add this back in. Its creating problems beyond the scope of the PR.

tienifr · 2023-12-20T08:12:31Z

@shubham1206agra updated

tienifr · 2023-12-25T03:13:13Z

@shubham1206agra any updates?

shubham1206agra · 2023-12-25T05:52:30Z

Sorry for the delay. I will finish this today

shubham1206agra · 2023-12-26T13:29:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-26.at.6.15.40.PM.mp4

Android: mWeb Chrome

Screen.Recording.2023-12-26.at.6.39.20.PM.mov

iOS: Native

Screen.Recording.2023-12-26.at.5.51.48.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-12-26.at.6.33.08.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-26.at.6.27.42.PM.mov

MacOS: Desktop

Screen.Recording.2023-12-26.at.6.41.59.PM.mov

rlinoz · 2023-12-26T18:47:27Z

src/pages/home/report/ReportActionsList.js

+            InteractionManager.runAfterInteractions(() => {
+                reportScrollManager.scrollToBottom();
+            });


Do we still need this change since we rolled back what caused the change?

@rlinoz After testing carefully, I realize that we don't need InteractionManager.runAfterInteractions anymore, so I just removed it. Thank you

OSBotify · 2023-12-27T15:34:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-28T21:18:48Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.18-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: 30726 A blank spot appears after deleting a money request

45c6f78

tienifr marked this pull request as ready for review November 22, 2023 07:30

tienifr requested a review from a team as a code owner November 22, 2023 07:30

melvin-bot bot requested review from shubham1206agra and removed request for a team November 22, 2023 07:30

format

fd105ab

tienifr added 2 commits November 22, 2023 15:38

refactor

7dc7bfa

refactor

0c45632

tienifr added 2 commits November 27, 2023 10:09

Merge branch 'main' into fix/30726

65fdbf9

remove autoScrollToTopThreshold

e304bb9

tienifr added 2 commits December 5, 2023 15:08

Merge branch 'main' into fix/30726

8f6ccef

fix: bug

22502c9

lint fix

fee9199

Merge branch 'main' into fix/30726

58d7ceb

lint fix

4a76dfe

tienifr added 2 commits December 18, 2023 15:43

update reportActionSize

304e367

update reportActionSize

089c090

tienifr added 2 commits December 20, 2023 14:58

Merge branch 'main' into fix/30726

4bb198c

revert flatlist

557aa85

shubham1206agra approved these changes Dec 26, 2023

View reviewed changes

melvin-bot bot requested a review from rlinoz December 26, 2023 13:30

rlinoz reviewed Dec 26, 2023

View reviewed changes

tienifr added 2 commits December 27, 2023 14:14

Merge branch 'main' into fix/30726

871816b

fix remove InteractionManager

c279ca1

rlinoz approved these changes Dec 27, 2023

View reviewed changes

rlinoz merged commit ad73595 into Expensify:main Dec 27, 2023

github-actions bot mentioned this pull request Dec 27, 2023

Deploy Checklist: New Expensify 2023-12-27 #33644

Closed

41 tasks

melvin-bot bot mentioned this pull request Dec 28, 2023

[HOLD for payment 2024-01-04] [$500] IOS - A blank spot appears after deleting a money request #30726

Closed

6 tasks

bernhardoj mentioned this pull request Apr 5, 2024

[Hold for payment 2024-05-30][$250] Deleted message disappear for a moment when transistioning from offline to online #39218

Closed

6 tasks

bernhardoj mentioned this pull request Nov 27, 2024

[HOLD for payment 2024-12-20] [$250] iOS - Report - Conversation does not scroll down after deleting an attachment #52861

Closed

8 tasks

Conversation

tienifr commented Nov 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 22, 2023

Uh oh!

shubham1206agra commented Nov 22, 2023

Uh oh!

tienifr commented Nov 22, 2023

Uh oh!

shubham1206agra commented Nov 22, 2023

Uh oh!

shubham1206agra commented Nov 22, 2023

Uh oh!

tienifr commented Nov 24, 2023

Uh oh!

shubham1206agra commented Nov 24, 2023

Uh oh!

tienifr commented Nov 27, 2023

Uh oh!

shubham1206agra commented Dec 3, 2023

Uh oh!

tienifr commented Dec 4, 2023

Uh oh!

shubham1206agra commented Dec 4, 2023

Uh oh!

tienifr commented Dec 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubham1206agra commented Dec 5, 2023

Uh oh!

shubham1206agra commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tienifr commented Dec 7, 2023

Uh oh!

shubham1206agra commented Dec 7, 2023

Uh oh!

shubham1206agra commented Dec 8, 2023

Uh oh!

tienifr commented Dec 18, 2023

Uh oh!

shubham1206agra commented Dec 18, 2023

Uh oh!

shubham1206agra commented Dec 18, 2023

Uh oh!

tienifr commented Dec 18, 2023

Uh oh!

tienifr commented Dec 18, 2023

Uh oh!

shubham1206agra commented Dec 19, 2023

Uh oh!

shubham1206agra commented Dec 19, 2023

Uh oh!

tienifr commented Dec 20, 2023

Uh oh!

tienifr commented Dec 25, 2023

Uh oh!

shubham1206agra commented Dec 25, 2023

Uh oh!

shubham1206agra commented Dec 26, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

rlinoz Dec 26, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Dec 27, 2023

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Dec 27, 2023

Uh oh!

OSBotify commented Dec 28, 2023

tienifr commented Nov 22, 2023 •

edited

Loading

tienifr commented Dec 5, 2023 •

edited

Loading

shubham1206agra commented Dec 6, 2023 •

edited

Loading