#30842/ Fix param SidebarUtils.getOrderedReportIDs type by kubabutkiewicz · Pull Request #32296 · Expensify/App

kubabutkiewicz · 2023-11-30T18:44:44Z

Details

Fixed Issues

$ #30842

Tests

Start a chat
Send money requests
Assign a task
Edit a chat message
Edit a money request
Edit a task
All items in the sidebar should be correct

Verify that no errors appear in the JS console

Offline tests

QA Steps

Start a chat
Send money requests
Assign a task
Edit a chat message
Edit a money request
Edit a task
All items in the sidebar should be correct

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

web2.mp4

MacOS: Desktop

desktop.mp4

…ix/30842

kubabutkiewicz · 2023-12-01T13:41:49Z

changes made according to this comment

fabioh8010 · 2023-12-04T07:45:02Z

src/libs/SidebarUtils.ts

    policies: Record<string, Policy>,
    priorityMode: ValueOf<typeof CONST.PRIORITY_MODE>,
-    allReportActions: OnyxCollection<ReportActions>,
+    allReportActions: OnyxCollection<ReportAction[]>,


I'm curious about this change, the structure should be OnyxCollection<ReportActions>.

Yes, but in the component where this method is used , there is a selector in withOnyx which is mapping value to type ReportAction[]

In the original issue I put a screenshot (I am also a creator of this issue XD) I found it when migrating ReportUtils

Ok, I understand now. So maybe we should use Record<string, ReportAction[]> like you used in the other file?

fabioh8010 · 2023-12-04T07:46:00Z

tests/perf-test/SidebarUtils.perf-test.ts

            ],
        ]),
-    ) as unknown as OnyxCollection<ReportActions>;
+    ) as unknown as Record<string, ReportAction[]>;


Where is this Record<string, ReportAction[]> structure from?

Same comment as here

Actually it should be OnyxCollection<ReportAction[]> I will change it

melvin-bot · 2023-12-04T09:49:12Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2023-12-05T13:09:40Z

@kubabutkiewicz please pull main

…ix/30842

kubabutkiewicz · 2023-12-05T15:34:05Z

@aimane-chnaif done

aimane-chnaif · 2023-12-06T15:48:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

aimane-chnaif

Looks good except this known bug:

#30990

NikkiWines

👍

OSBotify · 2023-12-07T18:48:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-08T01:24:14Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.10-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-08T02:54:07Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.4.10-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-11T10:41:24Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.10-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-11T15:23:19Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.10-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

kubabutkiewicz added 3 commits November 30, 2023 19:41

fix: fix type and remove parameter for canAccessReport

ca83e0d

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

5289e0d

…ix/30842

fix: type error in perf tests

f64ef0f

fabioh8010 reviewed Dec 4, 2023

View reviewed changes

fix: type

441935a

fabioh8010 approved these changes Dec 4, 2023

View reviewed changes

kubabutkiewicz marked this pull request as ready for review December 4, 2023 09:49

kubabutkiewicz requested a review from a team as a code owner December 4, 2023 09:49

melvin-bot bot requested review from aimane-chnaif and removed request for a team December 4, 2023 09:49

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into f…

69a6c26

…ix/30842

aimane-chnaif approved these changes Dec 6, 2023

View reviewed changes

melvin-bot bot requested a review from NikkiWines December 6, 2023 15:50

NikkiWines approved these changes Dec 7, 2023

View reviewed changes

NikkiWines merged commit 749e6e3 into Expensify:main Dec 7, 2023

github-actions bot mentioned this pull request Dec 8, 2023

Deploy Checklist: New Expensify 2023-12-08 #32704

Closed

27 tasks

melvin-bot bot mentioned this pull request Dec 11, 2023

[HOLD for payment 2023-12-18] [$500] ReportUtils.shouldReportBeInOptionList will always be falsy for specific reports #30842

Closed

6 tasks

Conversation

kubabutkiewicz commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

kubabutkiewicz commented Dec 1, 2023

Uh oh!

fabioh8010 Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

fabioh8010 Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

fabioh8010 Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Dec 4, 2023

Uh oh!

aimane-chnaif commented Dec 5, 2023

Uh oh!

kubabutkiewicz commented Dec 5, 2023

Uh oh!

aimane-chnaif commented Dec 6, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Dec 7, 2023

Uh oh!

OSBotify commented Dec 8, 2023

Uh oh!

OSBotify commented Dec 8, 2023

Uh oh!

OSBotify commented Dec 11, 2023

Uh oh!

OSBotify commented Dec 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kubabutkiewicz commented Nov 30, 2023 •

edited

Loading