[Wave 8] Ideal nav by adamgrzybowski · Pull Request #33280 · Expensify/App

adamgrzybowski · 2023-12-19T11:30:00Z

Details

Introduces the new navigation style to the App, mainly the new bottom tabs, the workspace switcher and moves several pages to the main pane navigator. For more details about the navigation patterns and design, refer to the design doc.

Fixed Issues

$ #32941

Tests

Verify that no errors appear in the JS console

There is obviously lots to cover in testing, we have let QA Applause team know about this big change and gave them a document with testing steps to follow.

Offline tests

Similar to the Test when it comes to the navigation patterns.

QA Steps

There is obviously lots to cover in testing, we have let QA Applause team know about this big change and gave them a document with testing steps to follow.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

We are not adding specific test screenshots or videos into this sections. The PR has been tested thoroughly over the course of weeks on various platforms. You can see that progress in the comment history here, rest assured we tried our best to catch any regressions.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/index.tsx

src/libs/Navigation/AppNavigator/createCustomFullScreenNavigator/CustomFullScreenRouter.tsx

src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.ts

src/pages/home/sidebar/BottomTabBarFloatingActionButton/index.tsx

MaciejSWM · 2023-12-22T19:42:35Z

staszekscp · 2024-01-02T14:16:10Z

Hey @mountiny! When would be possible to start testing the changes? 😄

s77rt · 2024-01-03T20:29:37Z

@adamgrzybowski Can you please merge main / resolve conflicts? I see some changes related the LHP that should not be a part of this PR

WojtekBoman · 2024-01-04T09:14:09Z

Conflicts have been resolved :)

s77rt · 2024-01-04T10:42:03Z

How is this supposed to look on Web? Not seeing much currently

s77rt · 2024-01-04T10:47:15Z

Missing icon on the bottom tabs
We should not keep navigating to a page that are we are currently in
Navigation direction should be different when going to Chats

Screen.Recording.2024-01-04.at.11.44.59.AM.mov

s77rt · 2024-01-04T10:54:07Z

Question: What is the role of the Expensify top-left logo button?

Screen.Recording.2024-01-04.at.11.53.03.AM.mov

github-actions · 2024-01-04T11:15:58Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/33280/index.html
The QR code can't be generated, because the android build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	https://33280.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

s77rt · 2024-01-04T11:25:59Z

Help and Go Expensify Classing missing the external link icon

kosmydel · 2024-01-04T11:30:03Z

Help and Go Expensify Classing missing the external link icon

The designs don't include this icon.
Do you think the icons should be visible here? cc @shawnborton

kosmydel · 2024-01-04T11:31:23Z

How is this supposed to look on Web? Not seeing much currently <img alt="Screenshot 2024-01-04 at 11 37 54 AM"

Oh, we forgot to mention. To got everything working you have to do the following:

rm -rf node_modules
npm i

We made some changes in a patch file and simple npm i doesn't re-apply patches.

kosmydel · 2024-01-04T11:32:16Z

Question: What is the role of the Expensify top-left logo button?

We haven't implemented this part yet - the workspace switcher. We are currently working on it.

mountiny · 2024-01-04T11:40:20Z

Question: What is the role of the Expensify top-left logo button?

This will be workspace switcher, where you can filter the app functionality on workspace basis

s77rt · 2024-01-04T11:45:26Z

I love the new web design <3

s77rt · 2024-01-04T11:49:26Z

Going to Profile does not have the Profile highlighted
Going to AllSettings does not have the Workspace highlighted (and it can't be highlighted on a second click)
There is a back button in the Workspace that should not be there (at least for Web)

Screen.Recording.2024-01-04.at.12.45.47.PM.mov

s77rt · 2024-01-04T11:53:37Z

Delete popover is misplaced

Same with workspace avatar change button

s77rt · 2024-01-04T12:04:11Z

Bug / By design? The settings in the workspace do not take full width

s77rt · 2024-01-04T12:08:55Z

Starting VBBA process messes with the flow: the central screen have a chat while the sidebar is on workspace settings. Also browser back button do not work

Screen.Recording.2024-01-04.at.1.07.46.PM.mov

s77rt · 2024-01-04T12:18:51Z

Not a bug: Now that the workspace name field is pushed on it's own page we should auto focus the input

s77rt · 2024-01-04T12:26:44Z

Crash when trying to view a workspace avatar

Screen.Recording.2024-01-04.at.1.26.02.PM.mov

s77rt · 2024-01-04T13:23:12Z

(similar to #33280 (comment)) If you refresh the page while RHP is open the highlighted item in Settings list is lost

Screen.Recording.2024-01-04.at.2.19.37.PM.mov

s77rt · 2024-01-04T13:24:15Z

Workspace links all redirects to the overview and you can't refresh a page that you are currently in

Screen.Recording.2024-01-04.at.2.23.26.PM.mov

src/pages/WorkspaceSwitcherPage.tsx

src/libs/Navigation/AppNavigator/Navigators/CentralPaneNavigator/BaseCentralPaneNavigator.tsx

jayeshmangwani · 2024-03-20T20:08:26Z

Coming from #37982. We missed updating a goBack here:

App/src/libs/actions/PaymentMethods.ts

Line 287 in 46d5d85

Navigation.goBack(ROUTES.SETTINGS_WALLET);

App/src/pages/settings/Wallet/TransferBalancePage.js

Line 182 in 46d5d85

onLinkPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)}

App/src/pages/settings/Wallet/TransferBalancePage.js

Line 187 in 46d5d85

onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS_WALLET)}

fedirjh · 2024-03-29T04:50:52Z

src/libs/Navigation/linkingConfig/FULL_SCREEN_TO_RHP_MAPPING.ts

+        SCREENS.SETTINGS.WALLET.CARDS_DIGITAL_DETAILS_UPDATE_ADDRESS,
+    ],
+    [SCREENS.SETTINGS.SECURITY]: [SCREENS.SETTINGS.TWO_FACTOR_AUTH, SCREENS.SETTINGS.CLOSE],
+    [SCREENS.SETTINGS.ABOUT]: [SCREENS.SETTINGS.APP_DOWNLOAD_LINKS, SCREENS.KEYBOARD_SHORTCUTS],


Coming from #35887, we shouldn’t add SCREENS.KEYBOARD_SHORTCUTS to this mapping. The page can be opened independently with a keyboard shortcut, so it shouldn't navigate from the current page.

alitoshmatov · 2024-04-11T15:47:11Z

src/libs/Navigation/linkTo.ts

@@ -99,9 +186,54 @@ export default function linkTo(navigation: NavigationContainerRef<RootStackParam
            // If this action is navigating to the ModalNavigator and the last route on the root navigator is not already opened ModalNavigator then push
        } else if (isModalNavigator(action.payload.name) && !isTargetNavigatorOnTop) {


Opening new workspace from workspace list is not creating new workspace, ref: #38420

parasharrajat · 2024-05-07T05:17:46Z

src/pages/WorkspaceSwitcherPage.tsx

+        }
+
+        return Object.values(policies)
+            .filter((policy) => PolicyUtils.shouldShowPolicy(policy, !!isOffline))


We should filter unapproved workspaces as well. #40679

parasharrajat · 2024-07-04T05:42:24Z

src/pages/workspace/WorkspacesListPage.tsx

+                    shouldShowBackButton={isSmallScreenWidth}
+                    onBackButtonPress={() => Navigation.goBack()}
+                >
+                    <Button


This button was causing the header title to wrap in two lines. #44210

thank you for letting us know 😄

eVoloshchak · 2024-07-22T13:38:07Z

src/libs/PolicyUtils.ts

-        policy?.isPolicyExpenseChatEnabled &&
-        policy?.role === CONST.POLICY.ROLE.ADMIN &&
-        (isOffline || policy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || Object.keys(policy.errors ?? {}).length > 0)
+        !!policy && policy?.isPolicyExpenseChatEnabled && (isOffline || policy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || Object.keys(policy.errors ?? {}).length > 0)


👋 Hey folks, coming from #44811
This PR has deleted policy?.role === CONST.POLICY.ROLE.ADMIN check, which resulted in workspaces being displayed in workspace list even if user has no role in them
We've resolved this by adding a !!policy?.role check to filter out all of the workspaces in which the user has no role

s77rt · 2024-08-05T01:01:56Z

src/pages/WorkspaceSwitcherPage.tsx

We didn't take into account the case where a user is removed from the selected workspace. In such case we should switch to "Expensify". (Coming from #43981)

ntdiary · 2024-10-31T03:47:07Z

src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

+    const policyID = isAnonymous ? undefined : extractPolicyIDFromPath(path);
+
+    const state = getStateFromPath(pathWithoutPolicyID, options) as PartialState<NavigationState<RootStackParamList>>;
+    replacePathInNestedState(state, path);


Coming from #49854.
We replaced path with normalizedPath to ensure it also have a prefix /, just like the path in useLinking of react-navigation, to prevent the URL from becoming incorrect when using the browser's back button. :)

eVoloshchak · 2024-12-09T13:09:11Z

src/pages/workspace/WorkspacesListPage.tsx

+        }
+
+        return Object.values(reports).reduce<ChatPolicyType>((result, report) => {
+            if (!report?.reportID || !report.policyID) {


Hey folks👋
This has caused a regression in #51820, user is navigated to thread message when going to #announce/admins room
Since all reports in announce room have chatType === policyAnnounce (even the thread reports), we were mistakenly identifying any report with chatType === policyAnnounce as the announce room in the switch statement below
This was resolved by returning early here is a report has parentReportID

s77rt · 2024-12-15T15:00:17Z

src/pages/WorkspaceSwitcherPage.tsx

+    const selectPolicy = useCallback(
+        (option?: SimpleWorkspaceItem) => {
+            if (!option) {
+                return;
+            }
+
+            const {policyID, isPolicyAdmin} = option;
+
+            if (policyID) {
+                setSelectedOption(option);
+            } else {
+                setSelectedOption(undefined);
+            }
+            setActiveWorkspaceID(policyID);
+            Navigation.goBack();
+            if (policyID !== activeWorkspaceID) {
+                Navigation.navigateWithSwitchPolicyID({policyID, isPolicyAdmin});
+            }
+        },
+        [activeWorkspaceID, setActiveWorkspaceID],
+    );


On double click this callback is called twice. After the first click (and after callingsetActiveWorkspaceID), the order of the workspaces change making the second click hit a different workspace. Resulting in unexpected workspace selection (user lands on the previous selected workspace).

First click:

Second click:

Coming from #51402

blazejkustra suggested changes Dec 19, 2023

View reviewed changes

adamgrzybowski changed the title ~~Ideal nav merge~~ Ideal nav Dec 22, 2023

mountiny changed the title ~~Ideal nav~~ [Wave 8] Ideal nav Dec 22, 2023

mountiny assigned adamgrzybowski Dec 22, 2023

mountiny added the Ready To Build label Dec 22, 2023

mateuuszzzzz mentioned this pull request Dec 22, 2023

[Wave8] Workspace Switcher #33501

Closed

50 tasks

This comment has been minimized.

Sign in to view

kosmydel mentioned this pull request Jan 2, 2024

Implement the full Screen Settings page #32940

Closed

rushatgabhane reviewed Mar 7, 2024

View reviewed changes

src/pages/WorkspaceSwitcherPage.tsx Show resolved Hide resolved

rushatgabhane mentioned this pull request Mar 7, 2024

[HOLD for payment 2024-02-26] [$250] Workspace switcher - No tooltip when hovering over + button next to Workspaces #35683

Closed

6 tasks

mollfpr mentioned this pull request Mar 14, 2024

[HOLD for payment 2024-03-13] [$500] Workspace switcher - LHN does not show IOU report and details page under "workspace" filter #35963

Closed

6 tasks

fedirjh reviewed Mar 19, 2024

View reviewed changes

src/libs/Navigation/AppNavigator/Navigators/CentralPaneNavigator/BaseCentralPaneNavigator.tsx Show resolved Hide resolved

fedirjh mentioned this pull request Mar 19, 2024

[$500] Infinite loading when accessing a non-existing workspace #36442

Closed

6 tasks

jayeshmangwani mentioned this pull request Mar 20, 2024

[HOLD for payment 2024-03-20] [$250] navigation transition from "transfer balance" screen slides from right instead of left #37982

Closed

6 tasks

fedirjh reviewed Mar 29, 2024

View reviewed changes

fedirjh mentioned this pull request Mar 29, 2024

[$500] Show keyboard shortcuts page modal wherever you are in the app #35887

Closed

6 tasks

dukenv0307 mentioned this pull request Apr 4, 2024

[HOLD for payment 2024-04-05] [$250] Tooltips - Tooltips on Desktop overlap with App window "dots" #38292

Closed

6 tasks

alitoshmatov reviewed Apr 11, 2024

View reviewed changes

alitoshmatov mentioned this pull request Apr 11, 2024

[HOLD for payment 2024-04-09] [$500] Workspace - New Workspace button doesn't create WS and shows no default name #38420

Closed

6 tasks

thesahindia mentioned this pull request Apr 12, 2024

[Ready for payment][$500] Chat - Skeleton in the header is not aligned with skeleton in the chat #35892

Closed

6 tasks

parasharrajat reviewed May 7, 2024

View reviewed changes

parasharrajat mentioned this pull request May 7, 2024

[HOLD for payment 2024-05-06] [$250] Join workspace - Unapproved workspace appears in workspace switcher #40679

Closed

6 tasks

c3024 mentioned this pull request Jun 21, 2024

[HOLD for payment 2024-06-20] [$250] Workspace switcher resets to All (Expensify) after page refresh #42153

Closed

6 tasks

parasharrajat reviewed Jul 4, 2024

View reviewed changes

parasharrajat mentioned this pull request Jul 4, 2024

[HOLD for payment 2024-07-10] [$250] Android - Workspaces - "Workspaces" title is shown in two lines #44210

Closed

6 tasks

eVoloshchak reviewed Jul 22, 2024

View reviewed changes

eVoloshchak mentioned this pull request Jul 22, 2024

[HOLD for payment 2024-07-17] [$125] Invoice-User B's workspace appears in User A's workspace list after paying invoice as business #44811

Closed

6 tasks

s77rt reviewed Aug 5, 2024

View reviewed changes

s77rt mentioned this pull request Aug 5, 2024

[HOLD for payment 2024-08-09] [$250] Workspace switcher - WS switcher and LHN are not reset to Expensify after leaving workspace #43981

Closed

6 tasks

paultsimura mentioned this pull request Sep 7, 2024

[HOLD for payment 2024-09-10] [$250] Workspace - RBRs displayed on every workspace after quitting adding bank VBA & starting over #48167

Closed

6 tasks

NaveedShaikh78 mentioned this pull request Sep 19, 2024

[$250] [Search v2.3] Popup colors are incorrect #49440

Closed

ntdiary mentioned this pull request Oct 10, 2024

[HOLD for payment 2024-10-30] [$250] mWeb - Workspace - Opens "Hmm it's not here" when tapping system back button #49854

Closed

6 tasks

ntdiary reviewed Oct 31, 2024

View reviewed changes

eVoloshchak reviewed Dec 9, 2024

View reviewed changes

eVoloshchak mentioned this pull request Dec 9, 2024

[HOLD for payment 2024-11-29] [$250] Workspace - User is navigate to thread message when going to #announce room #51820

Closed

8 tasks

s77rt reviewed Dec 15, 2024

View reviewed changes

s77rt mentioned this pull request Dec 15, 2024

[HOLD for payment 2024-12-19] [$250] mWeb - Selector - User lands on the same WS when double tapping on different one on selector #51402

Closed

8 tasks

		@@ -99,9 +186,54 @@ export default function linkTo(navigation: NavigationContainerRef<RootStackParam
		// If this action is navigating to the ModalNavigator and the last route on the root navigator is not already opened ModalNavigator then push
		} else if (isModalNavigator(action.payload.name) && !isTargetNavigatorOnTop) {

Conversation

adamgrzybowski commented Dec 19, 2023 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaciejSWM commented Dec 22, 2023

Uh oh!

This comment has been minimized.

staszekscp commented Jan 2, 2024

Uh oh!

s77rt commented Jan 3, 2024

Uh oh!

WojtekBoman commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s77rt commented Jan 4, 2024

Uh oh!

s77rt commented Jan 4, 2024

Uh oh!

s77rt commented Jan 4, 2024

Uh oh!

github-actions bot commented Jan 4, 2024

Uh oh!

s77rt commented Jan 4, 2024

Uh oh!

kosmydel commented Jan 4, 2024

Uh oh!

kosmydel commented Jan 4, 2024

Uh oh!

kosmydel commented Jan 4, 2024

Uh oh!

mountiny commented Jan 4, 2024

Uh oh!

s77rt commented Jan 4, 2024

Uh oh!

s77rt commented Jan 4, 2024

Uh oh!

s77rt commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s77rt commented Jan 4, 2024

Uh oh!

s77rt commented Jan 4, 2024

Uh oh!

s77rt commented Jan 4, 2024

Uh oh!

s77rt commented Jan 4, 2024

Uh oh!

s77rt commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s77rt commented Jan 4, 2024

Uh oh!

Uh oh!

Uh oh!

jayeshmangwani commented Mar 20, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adamgrzybowski commented Dec 19, 2023 •

edited by mountiny

Loading

WojtekBoman commented Jan 4, 2024 •

edited

Loading

s77rt commented Jan 4, 2024 •

edited

Loading

s77rt commented Jan 4, 2024 •

edited

Loading

parasharrajat Jul 4, 2024 •

edited

Loading