Fixed currency selection on confirm step by shubham1206agra · Pull Request #34075 · Expensify/App

shubham1206agra · 2024-01-06T13:32:39Z

Details

Fixed Issues

$ #33608
PROPOSAL: #33608 (comment)

Tests

Open App
Tap FAB button > Request money
Select Manual tab
Complete the flow till the confirmation step.
Click on Amount field to edit
Click on Currency and change to another one
Again click on Currency and verify if new selected currency is shown

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-22.at.6.58.11.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-01-22.at.5.14.11.PM.mov

iOS: Native

Screen.Recording.2024-01-22.at.6.44.34.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-01-22.at.5.10.29.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-22.at.5.07.19.PM.mov

MacOS: Desktop

Screen.Recording.2024-01-22.at.6.37.29.PM.mov

shubham1206agra · 2024-01-06T16:09:59Z

Screen.Recording.2024-01-06.at.9.37.59.PM.mov

@hoangzinh There's a slight delay in updating the currency. Is that fine as we are changing currency on unmount only?

hoangzinh · 2024-01-07T03:09:06Z

@shubham1206agra I recall there is related issue here https://expensify.slack.com/archives/C01GTK53T8Q/p1704368050838699

shubham1206agra · 2024-01-07T04:37:56Z

@shubham1206agra I recall there is related issue here https://expensify.slack.com/archives/C01GTK53T8Q/p1704368050838699

This will not be fixed by that. I am proposing to use a spinner while old value is present.

hoangzinh · 2024-01-09T15:50:56Z

ah I just want to share that "There's a slight delay in updating the currency" might cause an issue later. I think using a spinner is work around and it will cause bad UX when user see a spinner in a short time

shubham1206agra · 2024-01-11T03:58:03Z

ah I just want to share that "There's a slight delay in updating the currency" might cause an issue later. I think using a spinner is work around and it will cause bad UX when user see a spinner in a short time

Can you suggest me what should we do in this case?

hoangzinh · 2024-01-12T23:41:52Z

@shubham1206agra sorry I was thinking about what should we do so I'm late. Wdyt about the approach here https://expensify.slack.com/archives/C01GTK53T8Q/p1704818739022579

Wait onyx updated then goBack 🤔

shubham1206agra · 2024-01-17T13:55:25Z

@shubham1206agra sorry I was thinking about what should we do so I'm late. Wdyt about the approach here https://expensify.slack.com/archives/C01GTK53T8Q/p1704818739022579

Wait onyx updated then goBack 🤔

To be honest, this looks like a bad idea to just simply wait as it might look laggy to the user. I think its safe to use spinner (I know it will be a short spinner), rather than simply wait, which is actually an anti-pattern in the code.

What is your opinion on this @tgolen?

hoangzinh · 2024-01-17T15:34:29Z

this looks like a bad idea to just simply wait as it might look laggy to the user

Agreed. I'm okay with Spinner. Just wanna confirm, is it a full loading screen?

shubham1206agra · 2024-01-17T15:55:31Z

this looks like a bad idea to just simply wait as it might look laggy to the user

Agreed. I'm okay with Spinner. Just wanna confirm, is it a full loading screen?

Right now, I am thinking spinner on amount only. But I think, full screen spinner would be better.

melvin-bot · 2024-01-22T13:29:47Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2024-01-24T16:21:07Z

@shubham1206agra thanks for updates, I will try to do code review within 2 days.

hoangzinh · 2024-01-26T09:50:53Z

src/pages/iou/request/step/IOURequestStepConfirmation.js

        IOU.setMoneyRequestBillable_temporaryForRefactor(transactionID, billable);
    };

+    const isLoading = !!(transaction && transaction.originalCurrency);


I think we need to leave comment here to explain why we have this code

@shubham1206agra could you help to leave a comment here, other than that it looks good to me.

Thanks mate

hoangzinh · 2024-01-26T14:06:27Z

src/pages/iou/request/step/IOURequestStepAmount.js

+            IOU.setMoneyRequestCurrency_temporaryForRefactor(transactionID, originalCurrency.current, true);
+        };
+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, []);


I'm thinking is it possible if we don't need an additional useRef and modify current IOU.setMoneyRequestOriginalCurrency_temporaryForRefactor to pass a 3rd params like current implementation.

How about?

useEffect(() => { IOU.setMoneyRequestOriginalCurrency_temporaryForRefactor(transactionID, currency); return () => { if (isSaveButtonPressed.current) { return; } IOU.setMoneyRequestCurrency_temporaryForRefactor(transactionID, transaction.originalCurrency); }; // eslint-disable-next-line react-hooks/exhaustive-deps }, []);

Actually, it was creating some problems as it was keeping old values in mount / unmount.

Or we can always reset originalCurrency on unmount.

Let keep it this way as it helps me with cases of refresh (it will call mount again, and will set wrong value on refresh).

Hi @shubham1206agra I will try to test & complete review checklist tomorrow

hoangzinh · 2024-02-03T03:42:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-03.at.20.14.52.android.mov

Android: mWeb Chrome

Screen.Recording.2024-02-03.at.19.45.36.android.chrome.mov

iOS: Native

Screen.Recording.2024-02-03.at.19.50.10.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-02-03.at.19.47.36.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-03.at.19.41.52.web.mov

MacOS: Desktop

Screen.Recording.2024-02-03.at.19.43.43.desktop.mov

techievivek

Looks good, thanks.

OSBotify · 2024-02-05T16:22:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-05T23:08:55Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-02-05T23:30:40Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-02-07T09:51:04Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

sobitneupane · 2024-05-07T09:59:08Z

This regression is caused by changes introduced in this PR.

shubham1206agra added 6 commits January 6, 2024 19:01

fixed currency selection on confirm step

e929016

fixed minor bugs regarding currency change

ef3810c

fixed deep linking bugs

ca2763d

mirroring changes in tax step

9396845

fix lint

db92b88

removed unecessary param

f27c037

shubham1206agra and others added 2 commits January 22, 2024 16:32

Merge branch 'Expensify:main' into fix-currency-step

8a2e4c2

added full screen loader for better UX

d7fdf80

shubham1206agra marked this pull request as ready for review January 22, 2024 13:29

shubham1206agra requested a review from a team as a code owner January 22, 2024 13:29

melvin-bot bot requested review from hoangzinh and removed request for a team January 22, 2024 13:29

hoangzinh reviewed Jan 26, 2024

View reviewed changes

added comment

2bf606f

hoangzinh approved these changes Feb 3, 2024

View reviewed changes

melvin-bot bot requested a review from techievivek February 3, 2024 13:17

techievivek approved these changes Feb 5, 2024

View reviewed changes

techievivek merged commit 8034a1b into Expensify:main Feb 5, 2024

github-actions bot mentioned this pull request Feb 5, 2024

Deploy Checklist: New Expensify 2024-02-05 #35857

Closed

66 tasks

ZhenjaHorbach mentioned this pull request Feb 6, 2024

[$500] IOU - Page shows spinner after returning from Amount editor in confirmation page #35893

Closed

6 tasks

melvin-bot bot mentioned this pull request Feb 7, 2024

[HOLD for payment 2024-02-14] [$500] Request Money - Previous currency is shown selected if edit Amount&Currency in Request Money #33608

Closed

6 tasks

Pujan92 mentioned this pull request Feb 8, 2024

[regression] [HOLD til 03-04-2024] Expense - Expanded confirmation page is collapsed when returning from Amount #36077

Closed

6 tasks

hoangzinh mentioned this pull request Feb 15, 2024

fix: Room - Side panel does not close when clicking outside of panel #36002

Closed

50 tasks

sobitneupane mentioned this pull request Mar 12, 2024

[Checklist and NewDot C+ payment][$500] Distance - Distance request briefly shows local currency instead of workspace currency after creating it #37643

Closed

6 tasks

fedirjh mentioned this pull request Mar 21, 2024

[$500] IOU - Category is displayed in delay in employee workspace #37768

Closed

6 tasks

bernhardoj added a commit to bernhardoj/Expensify that referenced this pull request Mar 24, 2024

revert Expensify#34075

8045460

shubham1206agra deleted the fix-currency-step branch February 3, 2025 17:47

Conversation

shubham1206agra commented Jan 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

shubham1206agra commented Jan 6, 2024

Uh oh!

hoangzinh commented Jan 7, 2024

Uh oh!

shubham1206agra commented Jan 7, 2024

Uh oh!

hoangzinh commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shubham1206agra commented Jan 11, 2024

Uh oh!

hoangzinh commented Jan 12, 2024

Uh oh!

shubham1206agra commented Jan 17, 2024

Uh oh!

hoangzinh commented Jan 17, 2024

Uh oh!

shubham1206agra commented Jan 17, 2024

Uh oh!

melvin-bot bot commented Jan 22, 2024

Uh oh!

hoangzinh commented Jan 24, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Feb 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

techievivek left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 5, 2024

Uh oh!

OSBotify commented Feb 5, 2024

Uh oh!

OSBotify commented Feb 5, 2024

Uh oh!

OSBotify commented Feb 7, 2024

Uh oh!

sobitneupane commented May 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shubham1206agra commented Jan 6, 2024 •

edited

Loading

hoangzinh commented Jan 9, 2024 •

edited

Loading

hoangzinh commented Feb 3, 2024 •

edited

Loading