[TS migration] Migrate 'SettingsProfileDetails' page to TypeScript by kubabutkiewicz · Pull Request #35307 · Expensify/App

kubabutkiewicz · 2024-01-29T12:15:04Z

Details

Fixed Issues

$ #25214

Tests

Login into app
Go to Settings > Profile
Verify that Legal name page is working
Verify that Date of Birth Page is working
Verify that Address Page is working

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login into app
Go to Settings > Profile > Personal Details
Verify that Legal name page is working
Verify that Date of Birth Page is working
Verify that Address Page is working

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

mchrome.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

msafari.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…s-migration/SettingsProfileDetails

melvin-bot · 2024-01-29T12:15:09Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

…s-migration/SettingsProfileDetails

src/pages/settings/Profile/PersonalDetails/PersonalDetailsInitialPage.tsx

src/pages/settings/Profile/PersonalDetails/LegalNamePage.tsx

…s-migration/SettingsProfileDetails

src/ONYXKEYS.ts

src/libs/ValidationUtils.ts

src/pages/settings/Profile/PersonalDetails/AddressPage.tsx

src/pages/settings/Profile/PersonalDetails/CountrySelectionPage.tsx

src/pages/settings/Profile/PersonalDetails/DateOfBirthPage.tsx

src/pages/settings/Profile/PersonalDetails/LegalNamePage.tsx

fabioh8010 · 2024-02-07T23:11:57Z

src/types/onyx/OnyxCommon.ts

+type Error = string | MaybePhraseKey;
+
+type Errors = Record<string, Error | null>;


What's the reason of this change? Let's be careful because Errors is a type used in many files

Its because for example of this

App/src/pages/settings/Profile/PersonalDetails/LegalNamePage.js

Lines 65 to 67 in f697c89

if (values.legalFirstName.length > CONST.LEGAL_NAME.MAX_LENGTH) {

ErrorUtils.addErrorMessage(errors, 'legalFirstName', ['common.error.characterLimitExceedCounter', {length: values.legalFirstName.length, limit: CONST.LEGAL_NAME.MAX_LENGTH}]);

}

here we are not adding just string but this MaybePhraseKey

…s-migration/SettingsProfileDetails

blazejkustra

LGTM

melvin-bot · 2024-02-12T15:11:12Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2024-02-13T13:50:56Z

@kubabutkiewicz please fix conflict

kubabutkiewicz · 2024-02-15T15:29:02Z

@situchan Comments are resolved and conflicts are fixed, you can recheck 😄

situchan · 2024-02-15T22:31:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

situchan · 2024-02-19T07:09:50Z

Please also update QA Steps

Go to Settings > Profile > Personal Details

Personal Details page is deprecated. Now all sub-pages are directly in Profile page

situchan

melvin-bot · 2024-02-19T07:23:54Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25214 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

situchan · 2024-02-21T20:14:05Z

@kubabutkiewicz there's conflict

…s-migration/SettingsProfileDetails

kubabutkiewicz · 2024-02-22T11:16:06Z

@situchan conflicts resolved 😄

situchan · 2024-02-22T11:16:49Z

@tylerkaraszewski all yours

tylerkaraszewski · 2024-02-22T17:42:29Z

There are conflicts again.

…s-migration/SettingsProfileDetails

kubabutkiewicz · 2024-02-23T10:00:04Z

@tylerkaraszewski conflicts resolved

situchan · 2024-02-23T12:36:02Z

@kubabutkiewicz job2 still failing

kubabutkiewicz · 2024-02-26T08:36:29Z

will take a look at this today

…s-migration/SettingsProfileDetails

tylerkaraszewski · 2024-02-26T17:40:54Z

I merged this, but it caused the failure here:
#37215

I am going to revert this PR and let you re-create it kubabutkiewicz, sorry about the extra work, but you can look at the failure above and resolve that in the next iteration.

tylerkaraszewski · 2024-02-26T17:42:59Z

We probably shouldn't have duplicate zip and zipPostCode fields in an address.

OSBotify · 2024-02-26T21:05:14Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kubabutkiewicz · 2024-02-27T13:59:54Z

will take a look soon on that

OSBotify · 2024-02-28T23:53:50Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kubabutkiewicz added 4 commits January 26, 2024 12:03

ref: started working on migration of Profile pages

dcd834b

ref: migrate AddressPage

7d88436

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

2f7f0be

…s-migration/SettingsProfileDetails

ref: migrate DateOfBirthPage to TS

75fb85f

kubabutkiewicz added 5 commits January 29, 2024 16:32

ref: move PersonalDetailInitialPage to TS, fix Errors type

5d83e8e

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

5f26b89

…s-migration/SettingsProfileDetails

fix: typecheck

71889c6

fix: typecheck

9e87935

fix: remove comment

ff249fd

VickyStash reviewed Feb 2, 2024

View reviewed changes

kubabutkiewicz added 4 commits February 2, 2024 17:15

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

7cffd1c

…s-migration/SettingsProfileDetails

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

07aeee9

…s-migration/SettingsProfileDetails

fix: resolve comments

d7fa1f4

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

9165006

…s-migration/SettingsProfileDetails

fabioh8010 reviewed Feb 7, 2024

View reviewed changes

kubabutkiewicz added 2 commits February 8, 2024 14:47

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

3b37ccc

…s-migration/SettingsProfileDetails

fix: resolved comments

7d667af

kubabutkiewicz changed the title ~~[TS migration] Migrate 'SettingsProfileDetails' page to TypeScript~~ [No QA] [TS migration] Migrate 'SettingsProfileDetails' page to TypeScript Feb 8, 2024

kubabutkiewicz added 3 commits February 9, 2024 16:38

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

d8c3281

…s-migration/SettingsProfileDetails

fix: typecheck

20c98fd

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

9a85683

…s-migration/SettingsProfileDetails

fabioh8010 approved these changes Feb 12, 2024

View reviewed changes

blazejkustra approved these changes Feb 12, 2024

View reviewed changes

kubabutkiewicz marked this pull request as ready for review February 12, 2024 15:11

kubabutkiewicz requested a review from a team as a code owner February 12, 2024 15:11

melvin-bot bot requested review from situchan and removed request for a team February 12, 2024 15:11

situchan approved these changes Feb 19, 2024

View reviewed changes

melvin-bot bot requested a review from tylerkaraszewski February 19, 2024 07:24

Merge branch 'main' into ts-migration/SettingsProfileDetails

87dc6e3

kubabutkiewicz added 2 commits February 22, 2024 11:43

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

f0c8f25

…s-migration/SettingsProfileDetails

fix: typecheck

60f0c39

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

9e89e34

…s-migration/SettingsProfileDetails

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

6d9b146

…s-migration/SettingsProfileDetails

tylerkaraszewski approved these changes Feb 26, 2024

View reviewed changes

tylerkaraszewski merged commit 57d7eda into Expensify:main Feb 26, 2024

github-actions bot mentioned this pull request Feb 26, 2024

Investigate workflow job failing on main: confirmPassingBuild #37215

Closed

tylerkaraszewski mentioned this pull request Feb 26, 2024

Revert "[TS migration] Migrate 'SettingsProfileDetails' page to TypeScript" #37218

Merged

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

kubabutkiewicz mentioned this pull request Feb 28, 2024

[TS migration] Migrate 'SettingsProfileDetails' page to TypeScript #37426

Merged

50 tasks

		type Error = string \| MaybePhraseKey;

		type Errors = Record<string, Error \| null>;

	if (values.legalFirstName.length > CONST.LEGAL_NAME.MAX_LENGTH) {
	ErrorUtils.addErrorMessage(errors, 'legalFirstName', ['common.error.characterLimitExceedCounter', {length: values.legalFirstName.length, limit: CONST.LEGAL_NAME.MAX_LENGTH}]);
	}

Conversation

kubabutkiewicz commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabioh8010 Feb 7, 2024

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz Feb 8, 2024

Choose a reason for hiding this comment

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Feb 12, 2024

Uh oh!

situchan commented Feb 13, 2024

Uh oh!

kubabutkiewicz commented Feb 15, 2024

Uh oh!

situchan commented Feb 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Feb 19, 2024

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Feb 19, 2024

Uh oh!

situchan commented Feb 21, 2024

Uh oh!

kubabutkiewicz commented Feb 22, 2024

Uh oh!

situchan commented Feb 22, 2024

Uh oh!

tylerkaraszewski commented Feb 22, 2024

Uh oh!

kubabutkiewicz commented Feb 23, 2024

Uh oh!

situchan commented Feb 23, 2024

Uh oh!

kubabutkiewicz commented Feb 26, 2024

Uh oh!

tylerkaraszewski commented Feb 26, 2024

Uh oh!

tylerkaraszewski commented Feb 26, 2024

Uh oh!

OSBotify commented Feb 26, 2024

Uh oh!

kubabutkiewicz commented Feb 27, 2024

Uh oh!

OSBotify commented Feb 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

kubabutkiewicz commented Jan 29, 2024 •

edited

Loading

situchan commented Feb 15, 2024 •

edited

Loading