Skip to content

Revert "[TS migration] Migrate 'SettingsProfileDetails' page to TypeScript"#37218

Merged
roryabraham merged 1 commit intomainfrom
revert-35307-ts-migration/SettingsProfileDetails
Feb 26, 2024
Merged

Revert "[TS migration] Migrate 'SettingsProfileDetails' page to TypeScript"#37218
roryabraham merged 1 commit intomainfrom
revert-35307-ts-migration/SettingsProfileDetails

Conversation

@tylerkaraszewski
Copy link
Contributor

Reverts #35307 which caused this failure: #37215

@tylerkaraszewski tylerkaraszewski self-assigned this Feb 26, 2024
@tylerkaraszewski tylerkaraszewski requested a review from a team as a code owner February 26, 2024 17:41
@melvin-bot
Copy link

melvin-bot bot commented Feb 26, 2024

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@melvin-bot melvin-bot bot requested review from srikarparsi and removed request for a team February 26, 2024 17:41
@melvin-bot
Copy link

melvin-bot bot commented Feb 26, 2024

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving and merging w/o checklist as this is a straight revert.

@roryabraham
Copy link
Contributor

@roryabraham roryabraham merged commit 066d6c8 into main Feb 26, 2024
@roryabraham roryabraham deleted the revert-35307-ts-migration/SettingsProfileDetails branch February 26, 2024 17:44
@melvin-bot melvin-bot bot added the Emergency label Feb 26, 2024
@melvin-bot
Copy link

melvin-bot bot commented Feb 26, 2024

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@roryabraham
Copy link
Contributor

not an emergency, straight revert

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.44-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants