[CP Staging] Fix - App crashes when scrubbing through an mp4 file on attachment upload preview by kowczarz · Pull Request #37007 · Expensify/App

kowczarz · 2024-02-21T09:19:39Z

Details

Fixed Issues

$ #36905

Tests

Open a chat on ND
Click on plus icon inside the compose box
Click on add attachment
Click on choose from gallery
Select an mp4 video
When the preview opens up play the video and manually scrub through the video using the progress bar

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native_H.265.mp4

Android: mWeb Chrome

android.web_H.265.mp4

iOS: Native

ios_H.265.mp4

iOS: mWeb Safari

ios.web_H.265.mp4

MacOS: Chrome / Safari

web_H.265.mp4

MacOS: Desktop

desktop_H.265.mp4

kowczarz · 2024-02-22T15:19:41Z

src/components/VideoPlayerContexts/PlaybackContext.js


    const checkVideoPlaying = useCallback(
        (statusCallback) => {
+            if (!(currentVideoPlayerRef && currentVideoPlayerRef.current && currentVideoPlayerRef.current.getStatusAsync)) {


We need to check if the function isn't null, if it is then we can safely keep status default value (which is false).

melvin-bot · 2024-02-22T16:43:35Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2024-02-22T17:13:27Z

@kowczarz Can you please check this? It is showing promise rejection warning while scrubbing.

Screen.Recording.2024-02-22.at.10.41.42.PM.mov

shubham1206agra · 2024-02-22T17:42:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-22.at.11.07.56.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-22.at.10.32.06.PM.mov

iOS: Native

Screen.Recording.2024-02-22.at.10.41.42.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-02-22.at.10.24.04.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-22.at.10.21.20.PM.mov

MacOS: Desktop

Screen.Recording.2024-02-22.at.10.34.48.PM.mov

kowczarz · 2024-02-22T19:32:17Z

@shubham1206agra it's caused by progressBarInteraction, I will sync tomorrow with Reanimated team, so they will help me investigate it, but since the crash is a deploy blocker, I would fix the warning in a separate followup PR. WDYT?

Cc. @rlinoz, since you're the internal engineer who is assigned to the issue.

rlinoz · 2024-02-22T20:02:20Z

We are not deploying this week anymore, so if we can get the warning fixed tomorrow that is fine, otherwise I agree we can fix it in a separate PR.

mountiny · 2024-02-22T21:20:24Z

@rlinoz lets get the crash fixed in staging asap, the warning can follow up whenever fixed

mountiny

I will ask for the CP

OSBotify · 2024-02-22T21:28:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…lowups/fix-crashing [CP Staging] Fix - App crashes when scrubbing through an mp4 file on attachment upload preview (cherry picked from commit 437d75c)

OSBotify · 2024-02-22T22:12:07Z

🚀 Cherry-picked to staging by https://github.com/chiragsalian in version: 1.4.43-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-02-26T20:57:32Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix crashing on video attachment preview interactions

b11c83f

kowczarz force-pushed the video-player-followups/fix-crashing branch from 8e8b3ee to b11c83f Compare February 22, 2024 15:13

Cleanup

fd72a5f

kowczarz commented Feb 22, 2024

View reviewed changes

staszekscp approved these changes Feb 22, 2024

View reviewed changes

kowczarz marked this pull request as ready for review February 22, 2024 16:43

kowczarz requested a review from a team as a code owner February 22, 2024 16:43

melvin-bot bot requested review from shubham1206agra and removed request for a team February 22, 2024 16:43

shubham1206agra approved these changes Feb 22, 2024

View reviewed changes

melvin-bot bot requested a review from rlinoz February 22, 2024 19:52

mountiny changed the title ~~Fix - App crashes when scrubbing through an mp4 file on attachment upload preview~~ [CP Staging] Fix - App crashes when scrubbing through an mp4 file on attachment upload preview Feb 22, 2024

mountiny assigned kowczarz Feb 22, 2024

mountiny approved these changes Feb 22, 2024

View reviewed changes

mountiny merged commit 437d75c into Expensify:main Feb 22, 2024

github-actions bot mentioned this pull request Feb 22, 2024

Deploy Checklist: New Expensify 2024-02-19 #36820

Closed

izarutskaya mentioned this pull request Feb 23, 2024

[PAID] [$500] Chat - When opening the mp4 video that was just sent, console error appears #37142

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix - App crashes when scrubbing through an mp4 file on attachment upload preview#37007

[CP Staging] Fix - App crashes when scrubbing through an mp4 file on attachment upload preview#37007
mountiny merged 2 commits intoExpensify:mainfrom
software-mansion-labs:video-player-followups/fix-crashing

kowczarz commented Feb 21, 2024 •

edited

Loading

Uh oh!

kowczarz Feb 22, 2024 •

edited

Loading

Uh oh!

melvin-bot bot commented Feb 22, 2024

Uh oh!

shubham1206agra commented Feb 22, 2024

Uh oh!

shubham1206agra commented Feb 22, 2024

Uh oh!

kowczarz commented Feb 22, 2024

Uh oh!

rlinoz commented Feb 22, 2024

Uh oh!

mountiny commented Feb 22, 2024

Uh oh!

mountiny left a comment

Uh oh!

OSBotify commented Feb 22, 2024

Uh oh!

OSBotify commented Feb 22, 2024

Uh oh!

OSBotify commented Feb 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

kowczarz commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

kowczarz Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Feb 22, 2024

Uh oh!

shubham1206agra commented Feb 22, 2024

Uh oh!

shubham1206agra commented Feb 22, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

kowczarz commented Feb 22, 2024

Uh oh!

rlinoz commented Feb 22, 2024

Uh oh!

mountiny commented Feb 22, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 22, 2024

Uh oh!

OSBotify commented Feb 22, 2024

Uh oh!

OSBotify commented Feb 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kowczarz commented Feb 21, 2024 •

edited

Loading

kowczarz Feb 22, 2024 •

edited

Loading