Skip to content

[CP Staging] Fix - App crashes when scrubbing through an mp4 file on attachment upload preview #37007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 2 commits into from
Feb 22, 2024
Merged

[CP Staging] Fix - App crashes when scrubbing through an mp4 file on attachment upload preview #37007

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b11c83f
Fix crashing on video attachment preview interactions
kowczarz Feb 20, 2024
fd72a5f
Cleanup
kowczarz Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/VideoPlayerContexts/PlaybackContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ function PlaybackContextProvider({children}) {

const checkVideoPlaying = useCallback(
(statusCallback) => {
if (!(currentVideoPlayerRef && currentVideoPlayerRef.current && currentVideoPlayerRef.current.getStatusAsync)) {
Copy link
Contributor Author

@kowczarz kowczarz Feb 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check if the function isn't null, if it is then we can safely keep status default value (which is false).

return;
}
currentVideoPlayerRef.current.getStatusAsync().then((status) => {
statusCallback(status.isPlaying);
});
Expand Down