#39005 - Polish items for Transfer owner flow by burczu · Pull Request #39035 · Expensify/App

burczu · 2024-03-27T07:57:27Z

Details

This PR fixes some issues that left after merging the main Transfer Owner Flow feature.

Fixed Issues

$ #39005
PROPOSAL: n/a

Tests

Log in to the App
Open paid workspace where you are an admin but not an owner
Go to the members screen
Press on the owner member
Press the Transfer owner button
After adding payment card and there is no more errors, make sure it shows the success page
Go through error screens and see if there is no glitches (it should show correct copy immediately)
On the Outstanding balance error page, make sure it shows the amount value correctly formatted

Verify that no errors appear in the JS console

Offline tests

The Transfer owner functionality should be unavailable in the offline mode.

QA Steps

Same as in Tests section.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

n/a

Android: mWeb Chrome

n/a

iOS: Native

n/a

iOS: mWeb Safari

n/a

MacOS: Chrome / Safari

Screen.Recording.2024-03-28.at.10.47.01.mov

Screen.Recording.2024-03-28.at.10.50.15.mov

MacOS: Desktop

Screen.Recording.2024-03-28.at.10.53.55.mov

Screen.Recording.2024-03-28.at.10.55.48.mov

luacmartins

Left a few small comments. Otherwise looks good and tests really well!

src/pages/workspace/members/WorkspaceOwnerChangeCheck.tsx

src/pages/workspace/members/WorkspaceOwnerPaymentCardForm.tsx

…-flow

melvin-bot · 2024-03-28T10:05:32Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

burczu · 2024-03-28T10:08:19Z

@luacmartins I've published the PR, but I couldn't add videos for all platforms... I've encountered an error (I think) on all mobile devices, where I can't open any workspace on the workspaces list page - it's just not reacting to pressing on the item. Please see the video below:

Screen.Recording.2024-03-28.at.11.07.31.mov

luacmartins · 2024-03-28T15:42:56Z

@burczu yes, seems like a regression from this PR

luacmartins · 2024-03-28T16:15:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

blocked by #38734 (comment)

Android: mWeb Chrome

blocked by #38734 (comment)

iOS: Native

blocked by #38734 (comment)

iOS: mWeb Safari

blocked by #38734 (comment)

MacOS: Chrome / Safari

Screen.Recording.2024-03-28.at.9.57.26.AM.mov

MacOS: Desktop

Screen.Recording.2024-03-28.at.10.19.47.AM.mov

luacmartins · 2024-03-28T16:21:39Z

This flow is tricky to test as C+ so I'll do the checklist here. @burczu I checked off those platform videos since we're blocked from testing in those platforms. Gonna go ahead and merge this.

melvin-bot · 2024-03-28T16:21:55Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-03-28T16:27:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

luacmartins · 2024-03-28T16:31:47Z

Tests were passing

OSBotify · 2024-03-29T02:28:26Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2024-03-31T01:33:32Z

@luacmartins @burczu We don't see the option Transfer Owner in public domain accounts. In the applause.expensifail.com domain subscription is not charged. We don't have account with outstanding balance.

luacmartins · 2024-04-01T16:06:20Z

@kavimuru I think it's ok to skip the outstanding balance check in that case.

OSBotify · 2024-04-02T11:04:42Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.58-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

blazejkustra · 2024-11-04T16:42:46Z

src/pages/workspace/members/WorkspaceOwnerChangeCheck.tsx

+    useEffect(() => {
+        updateDisplayTexts();
+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, []);
+
+    useEffect(() => {
+        updateDisplayTexts();
+    }, [updateDisplayTexts]);


Is this intended to have two useEffects here? 🤔 cc @luacmartins @burczu

I can't think of a reason to have both, it seems like we can get rid of the first one without affecting functionality.

@carlosmiceli I started investigating components that disable react-hooks/exhaustive-deps and react-compiler/react-compiler because of this comment. That's how I noticed this weird duplicate.

I created a follow up issue to react-compiler upgrade PR, could you assign me to it? I don't want to spend too much time on this, but to fix some of obvious mistakes we have in the codebase. I could fix this one there too, let me know what do you think :)

Not sure if you meant to tag @carlosmiceli, but I assigned you to the issue above.

Ahh, sorry. I meant to tag you of course 🤦

burczu added 5 commits March 27, 2024 08:56

switched to use of correct currency utility function

b317e2d

missing flags setting for add billing card action added

cc3fb59

unnecessary import removed

b69dee8

issue with stale error messages shown for ms fixed

e5b480d

issue with glitching between transitions fixed

3279ebe

burczu force-pushed the bugfix/39005-polish-items-for-transfer-owner-flow branch from b055809 to 3279ebe Compare March 27, 2024 10:48

burczu added 2 commits March 27, 2024 13:21

unnecessary property removed

b22a60f

missing key for list added in the currency modal to highlight correctly

cd5a60f

luacmartins self-requested a review March 27, 2024 14:19

luacmartins reviewed Mar 27, 2024

View reviewed changes

src/pages/workspace/members/WorkspaceOwnerChangeCheck.tsx Outdated Show resolved Hide resolved

src/pages/workspace/members/WorkspaceOwnerChangeCheck.tsx Outdated Show resolved Hide resolved

src/pages/workspace/members/WorkspaceOwnerPaymentCardForm.tsx Outdated Show resolved Hide resolved

burczu added 4 commits March 28, 2024 09:12

state variable renamed

21a889a

unnecessary default value removed

e6f1c04

lint and prettier

ae4c645

Merge branch 'main' into bugfix/39005-polish-items-for-transfer-owner…

370c375

…-flow

burczu marked this pull request as ready for review March 28, 2024 10:05

burczu requested a review from a team as a code owner March 28, 2024 10:05

melvin-bot bot requested review from thesahindia and removed request for a team March 28, 2024 10:05

luacmartins approved these changes Mar 28, 2024

View reviewed changes

luacmartins merged commit c2d803e into Expensify:main Mar 28, 2024

melvin-bot bot added the Emergency label Mar 28, 2024

luacmartins removed the Emergency label Mar 28, 2024

github-actions bot mentioned this pull request Mar 29, 2024

Deploy Checklist: New Expensify 2024-03-29 #39222

Closed

izarutskaya mentioned this pull request Apr 1, 2024

[$500] [Members] The page for adding a payment card does not open during transfer owner flow #39349

Closed

6 tasks

melvin-bot bot mentioned this pull request Apr 2, 2024

[HOLD for payment 2024-04-09] [Simplified Collect][Members] Polish items for Transfer owner flow #39005

Closed

blazejkustra reviewed Nov 4, 2024

View reviewed changes

blazejkustra mentioned this pull request Nov 5, 2024

[Chore] Fix components where react rules aren't followed #52040

Merged

48 tasks

Conversation

burczu commented Mar 27, 2024 • edited by luacmartins Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot bot commented Mar 28, 2024

Uh oh!

burczu commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Mar 28, 2024

Uh oh!

luacmartins commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins commented Mar 28, 2024

Uh oh!

melvin-bot bot commented Mar 28, 2024

Uh oh!

OSBotify commented Mar 28, 2024

Uh oh!

luacmartins commented Mar 28, 2024

Uh oh!

OSBotify commented Mar 29, 2024

Uh oh!

kavimuru commented Mar 31, 2024

Uh oh!

luacmartins commented Apr 1, 2024

Uh oh!

OSBotify commented Apr 2, 2024

Uh oh!

blazejkustra Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

blazejkustra Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins Nov 4, 2024

Choose a reason for hiding this comment

Uh oh!

blazejkustra Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

burczu commented Mar 27, 2024 •

edited by luacmartins

Loading

burczu commented Mar 28, 2024 •

edited

Loading

luacmartins commented Mar 28, 2024 •

edited

Loading

blazejkustra Nov 4, 2024 •

edited

Loading