Add backup transaction again by DylanDylann · Pull Request #39144 · Expensify/App

DylanDylann · 2024-03-28T03:50:30Z

Details

This fixes a regression introduced in PR

Fixed Issues

$ #38853
$ #35173
$ #38864

PROPOSAL: NA

Tests

Section 1:

Go to workspace chat
Create a distance request
Go to the request details page
Click Distance
Add a waypoint
Click outside the distance editor (Or click back button on mobile) to dismiss it instead of saving the edit
Click Distance
Verify that the distance editor will not show the new waypoint added in Step 5 because the edit is not saved

Section 2:

Go to workspace chat.
Create a distance request.
Go to the request details page.
Click Distance.
Click the Save button without editing the addresses.
Verify that the map will not reload. Distance row will not show the Route pending

Verify that no errors appear in the JS console

Offline tests

Same above

QA Steps

Same above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-08.at.17.09.21.mov

Android: mWeb Chrome

Screen.Recording.2024-04-08.at.16.55.03.mov

iOS: Native

Screen.Recording.2024-04-08.at.16.54.13.mov

iOS: mWeb Safari

Screen.Recording.2024-04-08.at.16.51.32.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-08.at.16.45.24.mp4

MacOS: Desktop

Screen.Recording.2024-04-08.at.16.50.36.mov

melvin-bot · 2024-03-28T03:50:34Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/iou/request/step/IOURequestStepDistance.js

jakub-trzebiatowski · 2024-03-28T11:04:32Z

Missing "Details"

hoangzinh · 2024-03-28T14:18:09Z

@cubuspl42 I don't know how to unassign myself from this PR so just go ahead.

DylanDylann · 2024-03-28T14:45:56Z

@cubuspl42 I tried to revert the previous PR yesterday, but it is so late

jakub-trzebiatowski · 2024-03-29T10:45:04Z

Missing "Tests" section and videos, basically appears untested

DylanDylann · 2024-03-29T11:17:53Z

@cubuspl42 We still have some problem here, I am trying to resolve

jakub-trzebiatowski · 2024-03-29T11:20:01Z

I understand. You can consider marking the PR as a draft when it's being worked on actively, and some aspects are not ready.

DylanDylann · 2024-04-02T10:04:00Z

@cubuspl42 @puneetlath Marked this PR as ready for review to get more eyes.

Before we used transactionBackup to handle cases that users edit distance without saving it. When going to the distance page we will create a copy of the transaction called transactionBackup, we still save any update to the transaction but if users don't click the save button we will restore the transaction based on transactionBackup.

In the previous PR, we missed to migrate the above logic. It caused these bugs #38864, #38853

In this PR, I moved that logic again but this bug still be happening

Screen.Recording.2024-04-02.at.16.40.32.mov

Let's see the above video, the transactionBackup always be empty even after creating transactionBackup (I suspect this is a bug of React-Native-ONYX)

This bug hasn't happened before because previously we created transactionBackup and used transactionBackup in 2 components (EditRequestDistancePage, DistanceRequest/index.tsx we can check here for more detail). But when migrating all logics to new component IOURequestStepDistance, both creating and getting transactionBackup are handled in one component

jakub-trzebiatowski · 2024-04-02T12:51:27Z

I suspect this is a bug of React-Native-ONYX

Sometimes, I don't feel confident with Onyx, but if you suspect that there's a bug here, this makes this situation even more tricky 🙁

@puneetlath Do you have any hints or ideas here?

puneetlath · 2024-04-04T21:09:48Z

Hmm, interesting. I don't have any theories off the top of my head. @DylanDylann what makes you think it's an Onyx bug?

DylanDylann · 2024-04-08T09:29:40Z

@cubuspl42 After investigating again, I see this is not a bug from Onyx. I made a mistake in here.

jakub-trzebiatowski · 2024-04-08T09:35:08Z

@DylanDylann So what's the current state of the PR? Is everything finished and tested from your side, and things are ready for a new review round?

DylanDylann · 2024-04-08T09:35:29Z

I updated this PR to fix these issues: #38853 #35173 #38864

For [$500] Distance - Distance editor still shows new waypoint after dismissing the editor without saving #38853, I created a new field transactionsBackup to save the original transaction while editing. Before we used transactionDraft, it caused bugs because we were also using transactionDraft to save information when creating distance. The transactionBackup has been used before as mentioned above

Before we used transactionBackup to handle cases that users edit distance without saving it. When going to the distance page we will create a copy of the transaction called transactionBackup, we still save any update to the transaction but if users don't click the save button we will restore the transaction based on transactionBackup.

With this fix, #35173 also be resolved

For [HOLD for payment 2024-05-02] Distance - Map reloads with "Route pending" when clicking Save button without any changes #38864, I made a mistake while getting transactionBackup from Onyx. I also updated it to get transactionID from route

DylanDylann · 2024-04-08T09:36:29Z

@cubuspl42 I tested and everything works well, I am uploading the video. You can start your work now.

jakub-trzebiatowski · 2024-04-08T11:28:59Z

to fix #34610

I'm sorry about this mess, but please change the word "fix" to something else so we revert the auto-linking:

DylanDylann · 2024-04-10T07:07:36Z

Is this section platform-specific? I just tried to do this on Android and I don't think it makes sense. Please mark platform-specific testing steps.

Updated

DylanDylann · 2024-04-10T07:50:23Z

@cubuspl42 We need to wait for the map to be loaded before going to the next step to prevent this bug

Screen.Recording.2024-04-10.at.14.44.25.mp4

I don't think it relates to the Distance Page. Even though we don't open the distance page, the map still reload

jakub-trzebiatowski · 2024-04-10T10:03:10Z

We need to wait for the map to be loaded before going to the next step to prevent this bug
I don't think it relates to the Distance Page. Even though we don't open the distance page, the map still reload

Okey, thanks for confirming. Maybe we should clarify this in the QA steps, so the QA doesn't raise a false alarm? Technically speaking, the test (as phrased right now) failed in my case.

jakub-trzebiatowski · 2024-04-10T12:10:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

add-backup-transaction-again-section-1-android-web-compressed.mp4

add-backup-transaction-again-section-2-android-web-compressed.mp4

iOS: Native

add-backup-transaction-again-section-1-ios-compressed.mp4

add-backup-transaction-again-section-2-ios-compressed.mp4

iOS: mWeb Safari

add-backup-transaction-again-section-1-ios-web-compressed.mp4

add-backup-transaction-again-section-2-ios-web-compressed.mp4

MacOS: Chrome / Safari

add-backup-transaction-again-section-1-web-converted.mp4

add-backup-transaction-again-section-2-web-converted.mp4

MacOS: Desktop

puneetlath

One very small comment.

src/pages/iou/request/step/IOURequestStepDistance.js

DylanDylann · 2024-04-11T06:33:13Z

@puneetlath Updated. All yours

OSBotify · 2024-04-11T14:14:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-18T04:55:26Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

src/libs/actions/TransactionEdit.ts

mountiny · 2024-04-20T20:59:38Z

@DylanDylann Based on this comment #40392 (comment) the PR failed to fix #38864

can you look into this? thanks

kavimuru · 2024-04-20T21:08:01Z

This PR is still failing with #38864, not fixed.

The issue is reproducible in all the platforms

https://platform.applause.com/services/links/v1/external/57d6594cf88fd8935926a363259c65b1202c84b05f9d1736f43d4428abb14a81
https://platform.applause.com/services/links/v1/external/86476af8572e129051e9113cc9f7384ff6dbd5b82e820e69dce76e931f113995
https://platform.applause.com/services/links/v1/external/68dcf3a36100cccb2afe83c6cbfbc7e2a5ed6673eea35cfd2ef2b3eb112fed7a
https://platform.applause.com/services/links/v1/external/5b01522c2b60a20e184a4684f2803d1763d1b6bfe5f27ea6df0696e888b50baf
https://platform.applause.com/services/links/v1/external/12fd0b2061c7861b779294f36dfe061e167ac6e65ff1734289876fe55ee9e477

OSBotify · 2024-04-22T14:56:25Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jakub-trzebiatowski · 2024-04-23T07:53:09Z

@DylanDylann Bump

DylanDylann · 2024-04-23T07:54:01Z

@cubuspl42 What bump?

jakub-trzebiatowski · 2024-04-23T08:02:10Z

@DylanDylann

This comment (slightly above). Or do you mean that it is outdated? 🤔

DylanDylann · 2024-04-23T08:28:50Z

It resolved. More information here

jakub-trzebiatowski · 2024-04-23T09:05:44Z

Sorry then!

allroundexperts · 2024-12-18T22:45:30Z

src/pages/iou/request/step/IOURequestStepDistance.js

+        if (!isCreatingNewRequest) {
+            transactionWasSaved.current = true;
+        }


We should have checked if isEditing was false here as well. This caused #52241

add backup transaction again

6379d9d

DylanDylann requested a review from a team as a code owner March 28, 2024 03:50

melvin-bot bot removed the request for review from a team March 28, 2024 03:50

melvin-bot bot requested a review from hoangzinh March 28, 2024 03:50

DylanDylann added 2 commits March 28, 2024 16:04

add isDraft param

d85d48c

lint fix

752d578

jakub-trzebiatowski reviewed Mar 28, 2024

View reviewed changes

src/pages/iou/request/step/IOURequestStepDistance.js Show resolved Hide resolved

DylanDylann marked this pull request as draft March 29, 2024 11:21

jakub-trzebiatowski mentioned this pull request Apr 2, 2024

[Pay 4/29][$250] Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js #34610

Closed

merge main

298876e

DylanDylann marked this pull request as ready for review April 2, 2024 09:39

stephanieelliott mentioned this pull request Apr 4, 2024

[HOLD on #39144] [$500] [MEDIUM] Distance - Blank fields when editing distance and returning online with distance editor open #34441

Closed

6 tasks

DylanDylann added 3 commits April 5, 2024 18:03

merge main

1e96d99

merge main

3e5bca2

add new field and get correct transactionID

d7f3b45

merge main

f0fa143

jakub-trzebiatowski approved these changes Apr 10, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath April 10, 2024 12:10

puneetlath requested changes Apr 10, 2024

View reviewed changes

src/pages/iou/request/step/IOURequestStepDistance.js Outdated Show resolved Hide resolved

update comment

db75ccd

puneetlath approved these changes Apr 11, 2024

View reviewed changes

puneetlath merged commit 7d19f82 into Expensify:main Apr 11, 2024

DylanDylann mentioned this pull request Apr 11, 2024

[On Hold App #38864] [$500] Distance - Distance is saved when editor is dismissed without saving the changes #35173

Closed

6 tasks

greg-schroeder mentioned this pull request Apr 15, 2024

[$500] Distance - Distance editor still shows new waypoint after dismissing the editor without saving #38853

Closed

6 tasks

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

bernhardoj mentioned this pull request Apr 19, 2024

IOU - Currency in the amount editor is USD when the request is created in local currency #40543

Closed

6 tasks

Beamanator reviewed Apr 19, 2024

View reviewed changes

src/libs/actions/TransactionEdit.ts Show resolved Hide resolved

Beamanator mentioned this pull request Apr 19, 2024

[CP Staging] Use correct, new transactions backup key for Money Request amounts #40605

Merged

50 tasks

s77rt mentioned this pull request Apr 20, 2024

[$250] IOU - Unable to change currency in transaction thread #40631

Closed

6 tasks

allroundexperts reviewed Dec 18, 2024

View reviewed changes

Conversation

DylanDylann commented Mar 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 28, 2024

Uh oh!

Uh oh!

jakub-trzebiatowski commented Mar 28, 2024

Uh oh!

hoangzinh commented Mar 28, 2024

Uh oh!

DylanDylann commented Mar 28, 2024

Uh oh!

jakub-trzebiatowski commented Mar 29, 2024

Uh oh!

DylanDylann commented Mar 29, 2024

Uh oh!

jakub-trzebiatowski commented Mar 29, 2024

Uh oh!

DylanDylann commented Apr 2, 2024

Uh oh!

jakub-trzebiatowski commented Apr 2, 2024

Uh oh!

puneetlath commented Apr 4, 2024

Uh oh!

DylanDylann commented Apr 8, 2024

Uh oh!

jakub-trzebiatowski commented Apr 8, 2024

Uh oh!

DylanDylann commented Apr 8, 2024

Uh oh!

DylanDylann commented Apr 8, 2024

Uh oh!

jakub-trzebiatowski commented Apr 8, 2024

Uh oh!

DylanDylann commented Apr 10, 2024

Uh oh!

DylanDylann commented Apr 10, 2024

Uh oh!

jakub-trzebiatowski commented Apr 10, 2024

Uh oh!

jakub-trzebiatowski commented Apr 10, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

puneetlath left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DylanDylann commented Apr 11, 2024

Uh oh!

OSBotify commented Apr 11, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

Uh oh!

mountiny commented Apr 20, 2024

Uh oh!

kavimuru commented Apr 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Apr 22, 2024

Uh oh!

jakub-trzebiatowski commented Apr 23, 2024

Uh oh!

DylanDylann commented Apr 23, 2024

Uh oh!

jakub-trzebiatowski commented Apr 23, 2024

Uh oh!

DylanDylann commented Apr 23, 2024

Uh oh!

jakub-trzebiatowski commented Apr 23, 2024

Uh oh!

DylanDylann commented Mar 28, 2024 •

edited

Loading

kavimuru commented Apr 20, 2024 •

edited

Loading