Immediately show file size message for large attachments by ShridharGoel · Pull Request #39334 · Expensify/App

ShridharGoel · 2024-03-31T19:16:24Z

Details

Immediately show file size message for large attachments.

Fixed Issues

$ #38478
PROPOSAL: #38478 (comment)

Tests

On iOS, go to any chat.
Click on + and select "Add attachment"
Select a large video for uploading using "Choose from gallery".
Message telling about size limit should show immediately.

QA Steps

On iOS, go to any chat.
Click on + and select "Add attachment"
Select a large video for uploading using "Choose from gallery".
Message telling about size limit should show immediately.

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-31.at.1.37.40.PM.mov

Android: mWeb Chrome

video_20240406_001529_edit.mp4

iOS: Native

Screen.Recording.2024-03-31.at.1.05.05.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-04-04.at.11.40.52.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-04.at.11.38.07.PM.mov

MacOS: Desktop

Screen.Recording.2024-04-04.at.11.46.55.PM.mov

melvin-bot · 2024-03-31T19:16:29Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ShridharGoel · 2024-03-31T19:40:31Z

Will check the typecheck issue.

ShridharGoel · 2024-04-01T20:35:57Z

@hoangzinh Updated

hoangzinh · 2024-04-02T14:32:48Z

@ShridharGoel if we declare the type of imagePickerOptions as Partial<CameraOptions | ImageLibraryOptions>, then it's fine to set assetRepresentationMode: 'current' in imagePickerOptions

ShridharGoel · 2024-04-02T16:11:08Z

@hoangzinh Thanks for the suggestion, updated.

ShridharGoel · 2024-04-03T08:29:39Z

@hoangzinh This is ready for review, kindly have a look when possible.

hoangzinh · 2024-04-04T13:42:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-04.at.21.04.38.android.mov

Android: mWeb Chrome

Screen.Recording.2024-04-04.at.20.52.05.android.chrome.mov

iOS: Native

Screen.Recording.2024-04-04.at.21.02.50.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-04-04.at.21.03.41.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-04.at.20.48.34.web.mov

MacOS: Desktop

Screen.Recording.2024-04-04.at.20.50.13.desktop.mov

hoangzinh · 2024-04-04T13:46:19Z

Hi @ShridharGoel are you able to merge latest main branch again? I saw this when trying to do a recording

hoangzinh · 2024-04-04T14:06:20Z

@ShridharGoel can you complete recording for mWeb + web + desktop as well?

ShridharGoel · 2024-04-04T17:51:38Z

@hoangzinh The changes are only in index.native.ts so I had skipped the videos for other platforms. Will add them as well.

…nt-fix

ShridharGoel · 2024-04-04T19:25:03Z

@hoangzinh Added videos except Android mWeb one, facing some issue while trying to run there. Will check and try to update that later.

ShridharGoel · 2024-04-05T19:09:52Z

@hoangzinh Added Android mweb video as well.

hoangzinh

LGTM

ShridharGoel · 2024-04-08T19:07:38Z

@tylerkaraszewski Can you have a look when possible?

tylerkaraszewski · 2024-04-09T00:15:46Z

The performance tests are failing on this.

hoangzinh · 2024-04-09T02:36:47Z

Hi @tylerkaraszewski are you able to re-run it? The error is weird

tylerkaraszewski · 2024-04-09T16:56:36Z

I re-ran it and it still doesn't pass.

ShridharGoel · 2024-04-09T17:23:04Z

It's flaky, there is already an issue to investigate.

…

On Tue, Apr 9, 2024, 10:26 PM Tyler Karaszewski ***@***.***> wrote: I re-ran it and it still doesn't pass. — Reply to this email directly, view it on GitHub <#39334 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIPLJHDQRNELAWL3FSO5U3DY4QMVVAVCNFSM6AAAAABFQURZ7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBVGY3DGNZXGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

ShridharGoel · 2024-04-09T17:24:25Z

But here it is failing with some other issue, as mentioned by @hoangzinh.

hoangzinh · 2024-04-09T20:27:55Z

@ShridharGoel could you try to merge latest main? We disabled some flaky tests recently #39952

…nt-fix

ShridharGoel · 2024-04-10T06:47:17Z

@hoangzinh All checks pass now, thanks.

hoangzinh

LGTM

ShridharGoel · 2024-04-15T18:44:26Z

Any idea why this didn't get deployed to staging?

hoangzinh · 2024-04-17T13:47:54Z

cc @tylerkaraszewski could you help to deploy this PR to staging? Thanks

OSBotify · 2024-04-18T04:55:41Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T14:56:40Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ShridharGoel requested a review from a team as a code owner March 31, 2024 19:16

melvin-bot bot requested review from hoangzinh and removed request for a team March 31, 2024 19:16

Immediately show file size message for large attachments

1c2078c

ShridharGoel force-pushed the attachment-fix branch from a9ae677 to 1c2078c Compare March 31, 2024 19:18

Update index.native.tsx

c509b2f

ShridharGoel force-pushed the attachment-fix branch from d80f464 to c509b2f Compare April 2, 2024 16:10

ShridharGoel added 5 commits April 3, 2024 00:25

Update index.native.tsx

f98b733

Update index.native.tsx

a23585e

Fix lint

2642935

Merge branch 'main' into attachment-fix

31384cf

Move to alphabetical order in import type list

1f1fd18

Merge branch 'main' of https://github.com/Expensify/App into attachme…

31bdacc

…nt-fix

hoangzinh approved these changes Apr 6, 2024

View reviewed changes

melvin-bot bot requested a review from tylerkaraszewski April 6, 2024 11:02

tylerkaraszewski approved these changes Apr 9, 2024

View reviewed changes

ShridharGoel added 2 commits April 10, 2024 11:33

Merge

d1fd4e4

Merge branch 'main' of https://github.com/Expensify/App into attachme…

685f6d5

…nt-fix

hoangzinh approved these changes Apr 10, 2024

View reviewed changes

melvin-bot bot requested a review from tylerkaraszewski April 10, 2024 11:39

tylerkaraszewski approved these changes Apr 10, 2024

View reviewed changes

tylerkaraszewski merged commit 0c79e89 into Expensify:main Apr 10, 2024

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

This was referenced Apr 18, 2024

Chat - File types MP4, PDF, DOC etc other than images can not be attached to a report #40492

Closed

[CP Staging]Revert "Immediately show file size message for large attachments" #40510

Merged

ShridharGoel mentioned this pull request May 4, 2024

[HOLD for payment 2024-08-19] [$500] No feedback and delay when uploading a large attachment #38478

Closed

6 tasks

Conversation

ShridharGoel commented Mar 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 31, 2024

Uh oh!

ShridharGoel commented Mar 31, 2024

Uh oh!

ShridharGoel commented Apr 1, 2024

Uh oh!

hoangzinh commented Apr 2, 2024

Uh oh!

ShridharGoel commented Apr 2, 2024

Uh oh!

ShridharGoel commented Apr 3, 2024

Uh oh!

hoangzinh commented Apr 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Apr 4, 2024

Uh oh!

hoangzinh commented Apr 4, 2024

Uh oh!

ShridharGoel commented Apr 4, 2024

Uh oh!

ShridharGoel commented Apr 4, 2024

Uh oh!

ShridharGoel commented Apr 5, 2024

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Apr 8, 2024

Uh oh!

tylerkaraszewski commented Apr 9, 2024

Uh oh!

hoangzinh commented Apr 9, 2024

Uh oh!

tylerkaraszewski commented Apr 9, 2024

Uh oh!

ShridharGoel commented Apr 9, 2024 via email

Uh oh!

ShridharGoel commented Apr 9, 2024

Uh oh!

hoangzinh commented Apr 9, 2024

Uh oh!

ShridharGoel commented Apr 10, 2024

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Apr 15, 2024

Uh oh!

hoangzinh commented Apr 17, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ShridharGoel commented Mar 31, 2024 •

edited

Loading

hoangzinh commented Apr 4, 2024 •

edited

Loading