Skip to content

[CP Staging]Revert "Immediately show file size message for large attachments"#40510

Merged
amyevans merged 1 commit intomainfrom
revert-39334-attachment-fix
Apr 18, 2024
Merged

[CP Staging]Revert "Immediately show file size message for large attachments"#40510
amyevans merged 1 commit intomainfrom
revert-39334-attachment-fix

Conversation

@AndrewGable
Copy link
Copy Markdown
Contributor

@AndrewGable AndrewGable commented Apr 18, 2024

Straight revert of #39334

Fixes #40492

Tests

  1. Confirmed on iOS AdHoc that I could upload a ZIP attachment

@AndrewGable AndrewGable requested a review from a team as a code owner April 18, 2024 22:15
@melvin-bot melvin-bot bot requested review from amyevans and removed request for a team April 18, 2024 22:15
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 18, 2024

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@AndrewGable AndrewGable changed the title Revert "Immediately show file size message for large attachments" [HOLD]Revert "Immediately show file size message for large attachments" Apr 18, 2024
@github-actions
Copy link
Copy Markdown
Contributor

@AndrewGable AndrewGable changed the title [HOLD]Revert "Immediately show file size message for large attachments" [CP Staging]Revert "Immediately show file size message for large attachments" Apr 18, 2024
@amyevans amyevans merged commit 2a6b276 into main Apr 18, 2024
@amyevans amyevans deleted the revert-39334-attachment-fix branch April 18, 2024 22:56
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 18, 2024

@amyevans looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@amyevans
Copy link
Copy Markdown
Contributor

Not an emergency - skipped the checklists since it's a straight revert

OSBotify pushed a commit that referenced this pull request Apr 18, 2024
[CP Staging]Revert "Immediately show file size message for large attachments"

(cherry picked from commit 2a6b276)
@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chat - File types MP4, PDF, DOC etc other than images can not be attached to a report

3 participants