Update the Group Chat creation flow UI and Details page#39639
Merged
marcaaron merged 1 commit intoExpensify:feature-groupChats2from Apr 5, 2024
Merged
Update the Group Chat creation flow UI and Details page#39639marcaaron merged 1 commit intoExpensify:feature-groupChats2from
marcaaron merged 1 commit intoExpensify:feature-groupChats2from
Conversation
Contributor
Author
|
@marcaaron Created a PR as I will be OOO from Monday and tomorrow will be unavailable after 13:00 |
Contributor
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 1.4.63-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀
|
jjcoffee
reviewed
May 6, 2024
| ); | ||
| } | ||
|
|
||
| result.push({ |
Contributor
There was a problem hiding this comment.
Coming from #40442. We missed adding the isDisabled param here for members pending deletion.
6 tasks
6 tasks
dukenv0307
reviewed
May 19, 2025
| Report.inviteMembersToGroupChat(reportID, invitedEmailsToAccountIDs); | ||
| } | ||
| SearchInputManager.searchInput = ''; | ||
| Navigation.navigate(backRoute); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Update the Group Chat creation flow UI and Details page
Fixed Issues
$ #34927
Tests
TO ADD
Offline tests
Same as tests
QA Steps
None
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.