Scan - No error modal shown after selecting corrupted image. by Krishna2323 · Pull Request #40162 · Expensify/App

Krishna2323 · 2024-04-12T05:05:14Z

Details

Fixed Issues

$ #37435
PROPOSAL: #37435 (comment)

Tests

Go to workspace chat.
Go to + > Request money > Scan.
Upload a corrupted image (attached below).
Verify error modal is shown and the flow doesn't proceed to confirmation page

Verify that no errors appear in the JS console

Offline tests

Go to workspace chat.
Go to + > Request money > Scan.
Upload a corrupted image (attached below).
Verify error modal is shown and the flow doesn't proceed to confirmation page

QA Steps

Go to workspace chat.
Go to + > Request money > Scan.
Upload a corrupted image (attached below).
Verify error modal is shown and the flow doesn't proceed to confirmation page

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-04-12T05:05:18Z

@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

paultsimura · 2024-04-12T10:43:26Z

src/components/AttachmentPicker/index.native.tsx

    const validateAndCompleteAttachmentSelection = useCallback(
        (fileData: FileResponse) => {
-            if (fileData.width === -1 || fileData.height === -1) {
+            if (fileData.width === -1 || fileData.height === -1 || (fileData.height === 0 && fileData.width === 0)) {


Is this some edge case when fileData.height === 0 && fileData.width === 0?

Yeah, on ios native the image width/height for corrupted image is 0 and on android native it is -1.

@paultsimura, you mean you are unable to find corrupted image on ios attachment picker or something else?

Sorry, I've removed the previous comment – finally figured out how to upload the corrupted image into my simulator

paultsimura · 2024-04-12T11:25:26Z

src/libs/fileDownload/FileUtils.ts

+function checkIfImageIsCorrupted(file: FileObject) {
+    return new Promise((resolve, reject) => {
+        if (!Str.isImage(file.name ?? '')) {
+            resolve(true);
+        }
+        ImageSize.getSize(file.uri ?? '')
+            .then(() => {
+                resolve(true);
+            })
+            .catch(() => {
+                reject(new Error(`'Error reading file: The file is corrupted`));
+            });
+    });
+}


Let's better go this way:

Rename the function;

If the file is not an image – return the resolve instead of simply calling it;

Suggested change

function checkIfImageIsCorrupted(file: FileObject) {

return new Promise((resolve, reject) => {

if (!Str.isImage(file.name ?? '')) {

resolve(true);

}

ImageSize.getSize(file.uri ?? '')

.then(() => {

resolve(true);

})

.catch(() => {

reject(new Error(`'Error reading file: The file is corrupted`));

});

});

}

function validateImageForCorruption(file: FileObject): Promise<void> {

if (!Str.isImage(file.name ?? '')) {

return Promise.resolve();

}

return new Promise((resolve, reject) => {

ImageSize.getSize(file.uri ?? '')

.then(() => resolve())

.catch(() => reject(new Error('Error reading file: The file is corrupted')));

});

}

Just a friendly piece of advice: for a better review process, please click the "refresh" button here once the changes are ready for re-review. This way, the reviewer will get a proper notification.

Sure, will keep this in mind from next time. I appreciate the tip :)

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

paultsimura · 2024-04-12T15:30:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android17.29.mp4

Android: mWeb Chrome

chrome11.09.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-12.at.17.08.4717.29.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-13.at.11.06.5011.09.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-04-12.at.17.34.4410.57.mp4

MacOS: Desktop

Screen.Recording.2024-04-13.at.11.00.4211.01.mp4

paultsimura · 2024-04-13T09:14:32Z

src/components/AttachmentPicker/index.native.tsx

+                    .catch(() => {
+                        showImageCorruptionAlert();
+                    });


NAB: could you please update this?

Suggested change

.catch(() => {

showImageCorruptionAlert();

});

.catch(() => showImageCorruptionAlert());

paultsimura

LGTM ✔️

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

src/components/AttachmentPicker/index.native.tsx

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

kubabutkiewicz · 2024-04-17T12:47:48Z

Hi, I noticed that recently I am not able to scan correct pdf file and I believe its related to that PR

1.mp4

2.mp4

Krishna2323 · 2024-04-17T13:21:25Z

@kubabutkiewicz, thanks a lot for the heads up. I'll check this ASAP.

OSBotify · 2024-04-18T04:59:56Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T15:00:55Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Scan - No error shown after selecting corrupted image.

7cf12f5

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner April 12, 2024 05:05

melvin-bot bot removed the request for review from a team April 12, 2024 05:05

melvin-bot bot requested a review from paultsimura April 12, 2024 05:05

Krishna2323 added 2 commits April 12, 2024 13:24

fix: no error alert for corrupt image in native devices.

3f819b8

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/37435

a7a7729

paultsimura reviewed Apr 12, 2024

View reviewed changes

paultsimura suggested changes Apr 12, 2024

View reviewed changes

update image validator function name.

5e41d85

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

paultsimura reviewed Apr 13, 2024

View reviewed changes

paultsimura approved these changes Apr 13, 2024

View reviewed changes

melvin-bot bot requested a review from arosiclair April 13, 2024 09:15

minor fix.

dc28844

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from paultsimura April 13, 2024 10:12

paultsimura approved these changes Apr 13, 2024

View reviewed changes

arosiclair requested changes Apr 15, 2024

View reviewed changes

src/components/AttachmentPicker/index.native.tsx Outdated Show resolved Hide resolved

update validateAndCompleteAttachmentSelection and add comments.

028748b

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested review from arosiclair and paultsimura April 15, 2024 18:02

arosiclair approved these changes Apr 15, 2024

View reviewed changes

arosiclair merged commit 4cf2976 into Expensify:main Apr 15, 2024

kubabutkiewicz mentioned this pull request Apr 16, 2024

[LOW] [Splits] [$500] Mweb/Chrome - Scan request created using corrupt pdf displays incorrect error message #34032

Closed

6 tasks

Krishna2323 mentioned this pull request Apr 17, 2024

fix: wrong attachment corrupt alert for pdf. #40351

Merged

50 tasks

github-actions bot mentioned this pull request Apr 18, 2024

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

paultsimura mentioned this pull request Apr 18, 2024

[$250] Submit Expense - Error message about corrupted file when dragging and dropping image receipt #40440

Closed

6 tasks

rushatgabhane mentioned this pull request Apr 18, 2024

fix: Submit Expense - Error message about corrupted file when dragging and dropping image receipt #40471

Merged

50 tasks

Krishna2323 mentioned this pull request Apr 22, 2024

fix: IOU Scan - In dark mode, the damaged PDF - file is barely visible. #40607

Merged

50 tasks

Conversation

Krishna2323 commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 12, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paultsimura commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paultsimura left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kubabutkiewicz commented Apr 17, 2024

Uh oh!

Krishna2323 commented Apr 17, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Krishna2323 commented Apr 12, 2024 •

edited

Loading

paultsimura commented Apr 12, 2024 •

edited

Loading