fix: wrong attachment corrupt alert for pdf. by Krishna2323 · Pull Request #40351 · Expensify/App

Krishna2323 · 2024-04-17T13:46:13Z

Details

Fixed Issues

$ #37435
PROPOSAL:

Tests

Go to workspace chat.
Go to + > Request money > Scan.
Upload a valid pdf file.
Verify no alert modal is shown and the IOU flow continues.

Verify that no errors appear in the JS console

Offline tests

Go to workspace chat.
Go to + > Request money > Scan.
Upload a valid pdf file.
Verify no alert modal is shown and the IOU flow continues.

QA Steps

Go to workspace chat.
Go to + > Request money > Scan.
Upload a valid pdf file.
Verify no alert modal is shown and the IOU flow continues.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-04-17T13:46:44Z

@francoisl Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2024-04-17T13:48:18Z

@francoisl sorry for the ping :(

cc: @paultsimura

paultsimura · 2024-04-17T14:07:32Z

@Krishna2323 could you please explain this change a little? What specifically caused the issue with PDF?

paultsimura · 2024-04-17T14:24:25Z

src/components/AttachmentPicker/index.native.tsx

+                        // The width/height for corrupt file is -1 on android native and 0 on ios native
+                        if (width <= 0 || height <= 0) {
+                            throw new Error('Image dimensions are invalid.');
+                        }


Suggested change

// The width/height for corrupt file is -1 on android native and 0 on ios native

if (width <= 0 || height <= 0) {

throw new Error('Image dimensions are invalid.');

}

paultsimura · 2024-04-17T14:27:23Z

src/components/AttachmentPicker/index.native.tsx

            // Check if the file dimensions indicate corruption
-            // The width/height for corrupt file is -1 on android native and 0 on ios native
-            if (!fileData.width || !fileData.height || (fileData.width <= 0 && fileData.height <= 0)) {
+            if (fileData.width === -1 || fileData.height === -1) {


Can't we go this way instead?

// Check if the file dimensions indicate corruption // The width/height for a corrupted file is -1 on android native and 0 on ios native // We must check only numeric values because the width/height can be undefined for non-image files if (typeof fileData.width === 'number' && fileData.width <= 0 || typeof fileData.height === 'number' && fileData.height <= 0) { showImageCorruptionAlert(); return Promise.resolve(); }

Yes, this will also work.

I think it's better because we'll keep validating the dimensions in one place. Please update

Krishna2323 · 2024-04-17T14:32:49Z

This function also runs for non-image files, and width/height is undefined in that case.

App/src/components/AttachmentPicker/index.native.tsx

Lines 238 to 245 in 553e54f

    
           const validateAndCompleteAttachmentSelection = useCallback( 
        
               (fileData: FileResponse) => { 
        
                   // Check if the file dimensions indicate corruption 
        
                   // The width/height for corrupt file is -1 on android native and 0 on ios native 
        
                   if (!fileData.width || !fileData.height || (fileData.width <= 0 && fileData.height <= 0)) { 
        
                       showImageCorruptionAlert(); 
        
                       return Promise.resolve(); 
        
                   }

paultsimura · 2024-04-17T15:14:32Z

Also, please fill in the checklist

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

paultsimura · 2024-04-17T22:09:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android00.06.mp4

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-17.at.23.23.5700.06.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-18.at.00.09.0100.09.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-04-18.at.00.04.2500.06.mp4

MacOS: Desktop

Screen.Recording.2024-04-18.at.00.06.1400.06.mp4

paultsimura · 2024-04-17T22:10:09Z

@Krishna2323 please put #37435 under the fixed issues instead of the PR link you've added.

melvin-bot · 2024-04-17T22:10:31Z

🎯 @paultsimura, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #40384.

paultsimura · 2024-04-17T22:11:23Z

@arosiclair this is a follow-up of #40162. Please review when you have a minute 🙇

arosiclair

Thanks for the fix 👍

OSBotify · 2024-04-18T15:10:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-23T23:43:43Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: wrong attachment corrupt alert for pdf.

895dd20

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner April 17, 2024 13:46

melvin-bot bot requested review from francoisl and removed request for a team April 17, 2024 13:46

paultsimura reviewed Apr 17, 2024

View reviewed changes

placed validating the dimensions in one place.

484344f

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

brunovjk mentioned this pull request Apr 17, 2024

Remove MoneyRequestConfirmationList and replace to MoneyTemporaryForRefactorRequestConfirmationList #40176

Merged

50 tasks

paultsimura approved these changes Apr 17, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Apr 17, 2024

Payment issue for E/App PR#40351 #40384

Closed

paultsimura approved these changes Apr 18, 2024

View reviewed changes

melvin-bot bot requested a review from arosiclair April 18, 2024 13:52

arosiclair approved these changes Apr 18, 2024

View reviewed changes

arosiclair merged commit 9500169 into Expensify:main Apr 18, 2024

Krishna2323 mentioned this pull request Apr 18, 2024

Submit Expense - PDF files can not be added to scan expense on mobile apps #40486

Closed

6 tasks

paultsimura mentioned this pull request Apr 19, 2024

[LOW] [Splits] [$500] Mweb/Chrome - Scan request created using corrupt pdf displays incorrect error message #34032

Closed

6 tasks

github-actions bot mentioned this pull request Apr 22, 2024

Deploy Checklist: New Expensify 2024-04-22 #40702

Closed

95 tasks

Conversation

Krishna2323 commented Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 17, 2024

Uh oh!

Krishna2323 commented Apr 17, 2024

Uh oh!

paultsimura commented Apr 17, 2024

Uh oh!

paultsimura Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

paultsimura Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

paultsimura Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Apr 17, 2024

Uh oh!

paultsimura commented Apr 17, 2024

Uh oh!

paultsimura commented Apr 17, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

paultsimura commented Apr 17, 2024

Uh oh!

melvin-bot bot commented Apr 17, 2024

Uh oh!

paultsimura commented Apr 17, 2024

Uh oh!

arosiclair left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Krishna2323 commented Apr 17, 2024 •

edited

Loading