Show Closed Rooms as "Deleted" in E.Cash by yuwenmemon · Pull Request #4023 · Expensify/App

yuwenmemon · 2021-07-13T23:30:28Z

@TomatoToaster pleas review

HOLD ON https://github.com/Expensify/Auth/pull/5781

Details

Show Closed (status=2, state=2) Default Chat rooms as "Deleted" in E.Cash

Fixed Issues

For https://github.com/Expensify/Expensify/issues/165433

Tests/QA

Create a new Policy on the legacy (oldDot) app, invite some users to it (make sure it's on an expensify domain so you have access to the beta)
Open up E.cash, make sure that you can load up the #announce and #admins chat reports for that policy
Delete the policy
Reload the E.cash app, make sure that the #announce/admins rooms now show up as deleted:

- Make sure that the icon for the room has been replaced with a trash can icon - Make sure that the room shows up with `(deleted)` in the title - Make sure that the room input is disabled - Make sure that the room detail section does not contain any editable actions about the room (should just show an empty page)

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

src/components/RoomAvatar.js

TomatoToaster

Just had one suggestion but otherwise everything looks good 👍🏾 .

…n-deletedRooms

TomatoToaster

LGTM

TomatoToaster

Actually wait, there's just one thing I caught.

TomatoToaster · 2021-07-16T15:06:24Z

src/languages/en.js

        blockedFromConcierge: 'Communication is barred',
        youAppearToBeOffline: 'You appear to be offline.',
        fileUploadFailed: 'Upload Failed. File is not supported.',
+        localTime: ({user, time}) => `It's ${time} for ${user}`,


I think you're not using this right? I think this was changed in main since you made this branch.

It looks like it was removed here: https://github.com/Expensify/Expensify.cash/pull/4020/files

TomatoToaster · 2021-07-16T15:07:03Z

src/languages/es.js

        writeSomething: 'Escribe algo...',
        blockedFromConcierge: 'Comunicación no permitida',
        youAppearToBeOffline: 'Parece que estás desconectado.',
+        localTime: ({user, time}) => `Son las ${time} para ${user}`,


Same as above, I think this can be deleted.

TomatoToaster · 2021-07-16T21:57:46Z

There's a bug with K2 on ECash repos. The button is green but don't merge it's on HOLD!

github-actions · 2021-07-20T04:52:19Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

yuwenmemon · 2021-07-20T06:02:31Z

I have read the CLA Document and I hereby sign the CLA

yuwenmemon · 2021-07-20T06:20:29Z

Removing HOLD!

yuwenmemon · 2021-07-20T18:26:41Z

@sketchydroide please feel free to give this a look now!

sketchydroide · 2021-07-20T18:32:08Z

will probably do it tomorrow as it's a bit late for me :)

yuwenmemon · 2021-07-20T18:33:14Z

Of course buddy :) no worries!

sketchydroide

LGTM

sketchydroide · 2021-07-21T16:15:19Z

Code looks good, but I won't be able to test it, as I'm pretty much taking all my time to fill out the relocation excel file and the notes, and I'm OOO the next couple days moving house.

OSBotify · 2021-07-21T16:56:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2021-07-23T21:35:07Z

🚀 Deployed to staging in version: 1.0.79-5🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

isagoico · 2021-07-25T23:57:44Z

'Deleted' is not displayed in room channel after policy has been deleted

Action Performed

Step 1:

Create a policy in OldDot
Add a member to the policy
Navigate to NewDot and search for the #admin room
Send a message in the #Admin room
Navigate to OldDot and delete the policy
Navigate to NewDot and check that the #Admin room for the policy has the deleted status.

Expected Result

#announce/admins rooms should show up as deleted.

Actual Result

The #announce/admins rooms doesn't have the deleted status. The only thing visible is the Trash Can icon.

Notes/Images/Video

OSBotify · 2021-07-26T00:41:42Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

yuwenmemon · 2021-07-26T22:47:38Z

Ah whoops! Fix incoming ^

TomatoToaster · 2021-07-27T15:32:23Z

Forgot to mention, but that is merged, this is ready for a retest!

isagoico · 2021-07-27T18:57:56Z

@yuwenmemon @TomatoToaster when testing this we noticed that the LHN does not update after the refresh. It only updates and shows the deleted status when the user clicks ok the conversation

yuwenmemon · 2021-07-27T19:00:24Z

Hmmm.. that might be a symptom of the bug that was just fixed? Can we retest on a fresh account?

yuwenmemon · 2021-07-27T19:06:27Z

Just retested locally, worked fine for me:

isagoico · 2021-07-27T19:08:37Z

Tester just confirmed he tried on a new account. He's testing again just in case.

isagoico · 2021-07-27T19:55:34Z

Tester has the same behaviour in windows chrome. Maybe we could open this as a separate issue?

yuwenmemon · 2021-07-27T22:22:30Z

@isagoico yeah, let's do that and remove the blocker since I wouldn't want to hold up the deploy while I look into this (it doesn't seem obvious since I'm not able to reproduce)

OSBotify · 2021-07-28T21:08:35Z

🚀 Deployed to production in version: 1.0.80-2🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

yuwenmemon added 3 commits July 13, 2021 13:58

Use trashcan icon when room is in closed state

0f58b1c

Show deleted as part of report title when report is archived

3188970

Disable chat input when room is deleted

6080340

yuwenmemon requested a review from TomatoToaster July 13, 2021 23:30

yuwenmemon self-assigned this Jul 13, 2021

yuwenmemon requested a review from a team as a code owner July 13, 2021 23:30

MelvinBot requested review from sketchydroide and removed request for a team July 13, 2021 23:30

yuwenmemon changed the title ~~Show Closed Rooms as "Deleted" in E.Cash~~ [WIP] Show Closed Rooms as "Deleted" in E.Cash Jul 13, 2021

yuwenmemon changed the title ~~[WIP] Show Closed Rooms as "Deleted" in E.Cash~~ [HOLD - AUTH#5775] Show Closed Rooms as "Deleted" in E.Cash Jul 14, 2021

yuwenmemon added 2 commits July 14, 2021 15:32

Fix conflicts

27f02d5

JS Style

199afa1

TomatoToaster reviewed Jul 15, 2021

View reviewed changes

src/components/RoomAvatar.js Show resolved Hide resolved

TomatoToaster suggested changes Jul 15, 2021

View reviewed changes

yuwenmemon changed the title ~~[HOLD - AUTH#5775] Show Closed Rooms as "Deleted" in E.Cash~~ Show Closed Rooms as "Deleted" in E.Cash Jul 15, 2021

yuwenmemon added 3 commits July 15, 2021 16:20

Merge branch 'main' of github.com:Expensify/ReactNativeChat into yuwe…

359f6c1

…n-deletedRooms

Show old policy name in subheader if we're dealing with an Archived Room

49ac184

Stylesheet.flatten

33e5d99

yuwenmemon changed the title ~~Show Closed Rooms as "Deleted" in E.Cash~~ [HOLD AUTH#5781] Show Closed Rooms as "Deleted" in E.Cash Jul 16, 2021

Use state/status

4bb44ed

TomatoToaster approved these changes Jul 16, 2021

View reviewed changes

TomatoToaster suggested changes Jul 16, 2021

View reviewed changes

Fix bad merge of master

97c649c

TomatoToaster previously approved these changes Jul 16, 2021

View reviewed changes

Make deleted icon circular

4ee3e73

yuwenmemon dismissed TomatoToaster’s stale review via 4ee3e73 July 20, 2021 04:51

yuwenmemon changed the title ~~[HOLD AUTH#5781] Show Closed Rooms as "Deleted" in E.Cash~~ Show Closed Rooms as "Deleted" in E.Cash Jul 20, 2021

TomatoToaster approved these changes Jul 20, 2021

View reviewed changes

sketchydroide approved these changes Jul 21, 2021

View reviewed changes

yuwenmemon merged commit 2d673cc into main Jul 21, 2021

yuwenmemon deleted the yuwen-deletedRooms branch July 21, 2021 16:55

OSBotify mentioned this pull request Jul 23, 2021

Deploy Checklist: Expensify.cash 2021-07-23 #4198

Closed

60 tasks

isagoico added the DeployBlockerCash This issue or pull request should block deployment label Jul 26, 2021

github-actions bot added Engineering Hourly KSv2 labels Jul 26, 2021

yuwenmemon mentioned this pull request Jul 26, 2021

Make sure we get state/status from the right variable name when we get chat report name #4239

Merged

yuwenmemon removed the DeployBlockerCash This issue or pull request should block deployment label Jul 27, 2021

Conversation

yuwenmemon commented Jul 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests/QA

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Uh oh!

Uh oh!

TomatoToaster left a comment

Choose a reason for hiding this comment

Uh oh!

TomatoToaster left a comment

Choose a reason for hiding this comment

Uh oh!

TomatoToaster left a comment

Choose a reason for hiding this comment

Uh oh!

TomatoToaster Jul 16, 2021

Choose a reason for hiding this comment

Uh oh!

TomatoToaster Jul 16, 2021

Choose a reason for hiding this comment

Uh oh!

TomatoToaster commented Jul 16, 2021

Uh oh!

github-actions bot commented Jul 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuwenmemon commented Jul 20, 2021

Uh oh!

yuwenmemon commented Jul 20, 2021

Uh oh!

yuwenmemon commented Jul 20, 2021

Uh oh!

sketchydroide commented Jul 20, 2021

Uh oh!

yuwenmemon commented Jul 20, 2021

Uh oh!

sketchydroide left a comment

Choose a reason for hiding this comment

Uh oh!

sketchydroide commented Jul 21, 2021

Uh oh!

OSBotify commented Jul 21, 2021

Uh oh!

OSBotify commented Jul 23, 2021

Uh oh!

isagoico commented Jul 25, 2021

'Deleted' is not displayed in room channel after policy has been deleted

Action Performed

Expected Result

Actual Result

Uh oh!

OSBotify commented Jul 26, 2021

Uh oh!

yuwenmemon commented Jul 26, 2021

Uh oh!

TomatoToaster commented Jul 27, 2021

Uh oh!

isagoico commented Jul 27, 2021

Uh oh!

yuwenmemon commented Jul 27, 2021

Uh oh!

yuwenmemon commented Jul 27, 2021

Uh oh!

isagoico commented Jul 27, 2021

Uh oh!

isagoico commented Jul 27, 2021

Uh oh!

yuwenmemon commented Jul 27, 2021

Uh oh!

OSBotify commented Jul 28, 2021

Uh oh!

yuwenmemon commented Jul 13, 2021 •

edited

Loading

github-actions bot commented Jul 20, 2021 •

edited

Loading