Make sure we get state/status from the right variable name when we get chat report name#4239
Make sure we get state/status from the right variable name when we get chat report name#4239TomatoToaster merged 1 commit intomainfrom
Conversation
…t chat report name
|
|
| if (isDefaultRoom({chatType})) { | ||
| return `#${fullReport.reportName}${(isArchivedRoom({ | ||
| chatType, | ||
| stateNum: fullReport.stateNum, |
There was a problem hiding this comment.
Out of curiosity, are we still passing stateNum from the back end, and if so is it being used anywhere in the front end?
There was a problem hiding this comment.
We're not. It comes from the back-end as state/status, but elsewhere in E.chat it's stateNum/statusNum
TomatoToaster
left a comment
TomatoToaster
left a comment
There was a problem hiding this comment.
This LGTM! Idk how CP staging works but feel free to merge it.
(cherry picked from commit c00186d)
|
🚀 Cherry-picked to staging in version: 1.0.80-2🚀
|
|
🚀 Cherry-picked to production in version: 1.0.80-2🚀
|
|
🚀 Deployed to staging in version: 1.0.80-3🚀
|
|
🚀 Deployed to production in version: 1.0.81-4🚀
|
4 participants
@TomatoToaster please review
Details
I messed up here and was pulling the
state/statusfromstateNum/statusNumrather thanstate/statusFixed Issues
$ #4023
Tests/QA
See: #4023 (comment)
Made sure
(deleted)was showing in the report name: