[Search v1] Implement Bottom Tab Bar Changes by grgia · Pull Request #40293 · Expensify/App

grgia · 2024-04-16T14:05:07Z

Rename Chats to Inbox, Add Search To Bottom Tab, Rearrange Icons

Details

Screen.Recording.2024-04-25.at.8.10.39.PM.mov

Screen.Recording.2024-04-25.at.8.15.52.PM.mov

Fixed Issues

$ #39886

Tests

Verify that no errors appear in the JS console
Verify that the order of icons is Inbox, Search, Account Settings, FAB
Click on Inbox, Verify LHN opens and icon turns green
Hover over Inbox, verify tooltip reads "Inbox"
Click on Search, Verify Search Route opens and icon turns green
Hover over Search, verify tooltip reads "Search"
Click on Profile, Verify Profile Page opens
Click on FAB, verify quick action menu opens

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

luacmartins · 2024-04-16T16:43:27Z

@grgia we might either wanna hide this button or hold on merging this PR until the rest of the functionality is ready.

grgia · 2024-04-16T17:09:00Z

@luacmartins We could just hold it since it also moves the global create button

melvin-bot · 2024-04-25T19:14:25Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

grgia · 2024-04-25T19:15:08Z

@WojtekBoman would you mind taking a look at the routes here?

shawnborton · 2024-04-25T19:25:29Z

Let's run a test build!

At first glance, it seems like the size of the bottom tabs is off? I was thinking they would each be equal widths:

luacmartins

LGTM. Seems like @shawnborton has some comments though

luacmartins

Ahh @grgia one thing that I just remembered, with this PR we can also remove the navigation from the troubleshoot page -

App/src/components/TestToolMenu.tsx

Lines 96 to 105 in 8b71b1b

    
           {/* Navigate to the new Search Page. This button is temporary and should be removed after passing QA tests. */} 
        
           <TestToolRow title="New Search Page"> 
        
               <Button 
        
                   small 
        
                   text="Navigate" 
        
                   onPress={() => { 
        
                       Navigation.navigate(ROUTES.SEARCH.getRoute(CONST.TAB_SEARCH.ALL)); 
        
                   }} 
        
               /> 
        
           </TestToolRow>

grgia · 2024-04-25T19:41:20Z

@shawnborton what size/padding should the FAB have? I can fix the flex row sizing but the button is bigger than that mock

edit: I was looking at the profile icon 🙃

grgia · 2024-04-25T19:48:02Z

Done @luacmartins

@shawnborton I fixed the even spacing and triggered a new test build for ya

shawnborton · 2024-04-25T20:13:43Z

Dope, thanks Georgia!

shawnborton · 2024-04-25T20:22:15Z

Styles look good to me! In theory, we could make tapping the entire tab area that surrounds the FAB tappable, but I don't feel too strongly since the FAB itself is quite big.

dannymcclain · 2024-04-25T20:38:21Z

Looking good to me too! I even have a (phantom 😩) RBR on my inbox and it looks dope.

we could make tapping the entire tab area that surrounds the FAB tappable, but I don't feel too strongly since the FAB itself is quite big.

Agree but also don't feel strongly at all. I'd be totally fine leaving it how it is TBH.

dubielzyk-expensify · 2024-04-26T02:05:28Z

This is looking great! 😄

luacmartins · 2024-04-26T14:34:58Z

@fedirjh please review this one when you're online. Let's get this one approved and ready to merge for the photo finish.

fedirjh · 2024-04-26T17:13:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

CleanShot.2024-04-26.at.18.41.48.mp4

Android: mWeb Chrome

CleanShot.2024-04-26.at.18.39.15.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-26.at.18.36.08.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-26.at.18.33.19.mp4

MacOS: Chrome / Safari

CleanShot.2024-04-26.at.18.17.24.mp4

MacOS: Desktop

CleanShot.2024-04-26.at.19.37.38.mp4

melvin-bot · 2024-04-26T18:49:03Z

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dannymcclain

Looks like all the designers have chimed in so I'm going to go ahead and approve from a design perspective! 🚀

github-actions · 2024-05-03T18:18:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40293/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40293/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40293/NewExpensify.dmg	https://40293.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

luacmartins · 2024-06-07T01:24:27Z

Removing the hold and merging to get this feature out tomorrow and start testing!

melvin-bot · 2024-06-07T01:24:36Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

luacmartins · 2024-06-07T01:28:06Z

hmm tests were passing when I merged it.

OSBotify · 2024-06-07T01:32:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

s77rt · 2024-06-09T20:55:39Z

src/languages/es.ts

        twoFactorCode: 'Autenticación de dos factores',
        workspaces: 'Espacios de trabajo',
-        chats: 'Chats',
+        inbox: 'Bandeja de entrada',


This text overflows #42772 (comment)

@s77rt do we have a fix for that yet?

Fix here #43429

OSBotify · 2024-06-11T23:31:13Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

grgia added 3 commits April 16, 2024 13:15

rename Chats to Inbox

8f03816

Add and rearrange bottom tab buttons

db8dd65

Use home icon, add comments

2af4fc0

grgia self-assigned this Apr 16, 2024

luacmartins self-requested a review April 25, 2024 16:45

grgia added 2 commits April 25, 2024 19:57

Merge branch 'main' into georgia-search-bottomTabBar

447210d

Add new assets, automatically go to search/all

584e3fc

grgia marked this pull request as ready for review April 25, 2024 19:14

grgia requested review from a team as code owners April 25, 2024 19:14

melvin-bot bot requested review from fedirjh and removed request for a team April 25, 2024 19:14

grgia added 2 commits April 25, 2024 20:19

prettier

f72a1c9

remove comments

56c6d57

shawnborton added the Ready To Build label Apr 25, 2024

luacmartins approved these changes Apr 25, 2024

View reviewed changes

luacmartins requested changes Apr 25, 2024

View reviewed changes

fix equal spacing between buttons

44901ed

grgia requested a review from luacmartins April 25, 2024 19:47

remove unused imports for lint

975fda1

This comment has been minimized.

Sign in to view

luacmartins approved these changes Apr 26, 2024

View reviewed changes

fedirjh approved these changes Apr 26, 2024

View reviewed changes

melvin-bot bot requested a review from marcochavezf April 26, 2024 18:49

dannymcclain approved these changes Apr 26, 2024

View reviewed changes

grgia changed the title ~~[HOLD][Search v1] Implement Bottom Tab Bar Changes~~ [HOLD until Release][Search v1] Implement Bottom Tab Bar Changes Apr 29, 2024

marcochavezf approved these changes Apr 29, 2024

View reviewed changes

Merge branch 'main' into georgia-search-bottomTabBar

0854c52

luacmartins mentioned this pull request May 3, 2024

Implement Search ListItems and table header #41347

Merged

60 tasks

luacmartins changed the title ~~[HOLD until Release][Search v1] Implement Bottom Tab Bar Changes~~ [Search v1] Implement Bottom Tab Bar Changes Jun 7, 2024

luacmartins merged commit c03552b into main Jun 7, 2024

luacmartins deleted the georgia-search-bottomTabBar branch June 7, 2024 01:24

melvin-bot bot added the Emergency label Jun 7, 2024

luacmartins removed the Emergency label Jun 7, 2024

s77rt reviewed Jun 9, 2024

View reviewed changes

s77rt mentioned this pull request Jun 10, 2024

Bump onyx to 2.0.48 (after revert) #42772

Merged

50 tasks

github-actions bot mentioned this pull request Jun 10, 2024

Deploy Checklist: New Expensify 2024-06-10 #43344

Closed

melvin-bot bot mentioned this pull request Jun 11, 2024

[HOLD for payment 2024-06-20] [HOLD][Search v1] Update BottomTabBar #39886

Closed

	{/* Navigate to the new Search Page. This button is temporary and should be removed after passing QA tests. */}
	<TestToolRow title="New Search Page">
	<Button
	small
	text="Navigate"
	onPress={() => {
	Navigation.navigate(ROUTES.SEARCH.getRoute(CONST.TAB_SEARCH.ALL));
	}}
	/>
	</TestToolRow>

Conversation

grgia commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rename Chats to Inbox, Add Search To Bottom Tab, Rearrange Icons

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

luacmartins commented Apr 16, 2024

Uh oh!

grgia commented Apr 16, 2024

Uh oh!

melvin-bot bot commented Apr 25, 2024

Uh oh!

grgia commented Apr 25, 2024

Uh oh!

shawnborton commented Apr 25, 2024

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

grgia commented Apr 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grgia commented Apr 25, 2024

Uh oh!

shawnborton commented Apr 25, 2024

Uh oh!

This comment has been minimized.

shawnborton commented Apr 25, 2024

Uh oh!

dannymcclain commented Apr 25, 2024

Uh oh!

dubielzyk-expensify commented Apr 26, 2024

Uh oh!

luacmartins commented Apr 26, 2024

Uh oh!

fedirjh commented Apr 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 26, 2024

Uh oh!

dannymcclain left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 3, 2024

Uh oh!

luacmartins commented Jun 7, 2024

Uh oh!

melvin-bot bot commented Jun 7, 2024

Uh oh!

luacmartins commented Jun 7, 2024

Uh oh!

OSBotify commented Jun 7, 2024

Uh oh!

s77rt Jun 9, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins Jun 10, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins Jun 10, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

grgia commented Apr 16, 2024 •

edited

Loading

grgia commented Apr 25, 2024 •

edited

Loading

fedirjh commented Apr 26, 2024 •

edited

Loading