Implement Search ListItems and table header by luacmartins · Pull Request #41347 · Expensify/App

luacmartins · 2024-04-30T16:19:13Z

Details

Introduces the TransactionListItem and SearchTableHeader to show list items in the search page

Fixed Issues

$ #39876
$ #39877

Tests

Navigate to Profile > Troubleshoot > New Search Page
Verify that you can see the table header and the transaction items.
Verify that clicking on a transaction item opens the transaction thread in the RHP

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I verified that similar component doesn't exist in the codebase
I verified that all props are defined accurately and each prop has a /** comment above it */
I verified that each file is named correctly
I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
I verified that the only data being stored in component state is data necessary for rendering and nothing else
In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
I verified that component internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
I verified that all JSX used for rendering exists in the render method
I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-05-02T22:22:09Z

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-05-03T00:34:24Z

Not related to this PR but seeing some weirdness with some of the expense views in the RHP:

As in, I shouldn't see a Join button and the header styles are a bit different from a proper report/expense in the RHP:

grgia · 2024-05-03T06:39:57Z

@rayane-djouah are you able to build IOS without error

grgia

changes LGTM, have we created issues for all the follow ups?

grgia · 2024-05-03T08:03:56Z

Coming from here should we sort by date descending to begin with? The transactions feel randomly organized right now

grgia · 2024-05-03T08:58:20Z

src/styles/utils/index.ts

+        let columnWidth;
+        switch (columnName) {
+            case CONST.SEARCH_TABLE_COLUMNS.DATE:
+                columnWidth = getWidthStyle(variables.w44);


NAB these variables are typically named by their use, so like variables.dateColumnWidth

rayane-d · 2024-05-03T10:20:06Z

@rayane-djouah are you able to build IOS without error

Yes, I'm able to. I merged main locally before testing.

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-05-03.at.11.18.10.mp4

luacmartins · 2024-05-03T14:17:31Z

Gonna merge this one to get the feature out and then create a follow up to address the remaining issues. Thanks for the reviews everyone!

OSBotify · 2024-05-03T14:24:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

luacmartins · 2024-05-03T14:35:57Z

Created follow up issues here:

[HOLD for payment 2024-06-20] [Search v1] Opening transactions on search page can lead to not found page #41578
[HOLD for Payment [2024-05-15][$250] [Search v1] Resizing the screen to switch from the large screen to small screen breaks the back navigation on RHP. #41579
[HOLD for payment 2024-06-06] [$250] [Search v1] Search page scroll is not smooth #41581
[Search v1] Sort transactions by date #41582
[$250] [Search v1] RHP reports show incorrect headers #41585

shawnborton · 2024-05-03T18:57:23Z

Some more follow ups - the headers don't seem aligned to the content below:

cc @Expensify/design

luacmartins · 2024-05-03T19:06:01Z

@shawnborton I don't see that, which version are you using? Could you try this adhoc build? #40293 (comment)

shawnborton · 2024-05-03T19:19:37Z

Yup I am using that adhoc build and noticed this.

luacmartins · 2024-05-03T19:21:38Z

Weird, I'm on the same build and don't see that

luacmartins · 2024-05-03T19:22:13Z

I do see some issues on iOS with the from/to fields though

shawnborton · 2024-05-03T19:30:17Z

It's probably because I have a mouse plugged in and the fixed header is above the scrollable area? And then the scroll bar pushes everything over?

luacmartins · 2024-05-03T20:40:35Z

Hmm I didn't test it with a mouse but I also just see the scrollbar below the header

Screen.Recording.2024-05-03.at.2.40.02.PM.mov

luacmartins · 2024-05-03T20:42:23Z

@shawnborton do you see an additional right padding on the header? I see this padding, which makes the alignment correct

shawnborton · 2024-05-06T11:34:29Z

Try testing it with a mouse though - I think the mouse creates that fixed scrollbar that is pushing the table to be over to the left a bit.

luacmartins · 2024-05-06T18:22:25Z

Yea, adding the mouse shifted everything and that's also happening on other table views with scroll.

Gonna create a separate issue for this since multiple views are affected by it.

shawnborton · 2024-05-06T18:46:49Z

Sounds good!

OSBotify · 2024-05-09T02:11:13Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

create searchtableheader

adcd8fa

luacmartins self-assigned this Apr 30, 2024

luacmartins added 28 commits April 30, 2024 10:24

fix header style

736f4e6

create receipt element

a54eed4

update row callback

f061806

add button translation and styles

d96a461

use display amounts

8f6fe42

refactor tag element

6006e97

create getSearchTableColumnWidth

cb97bab

add styles framework

eefa1a1

dry user element

071f4ea

style description

1c5016e

dry code

e573f9b

dry more code

372d09a

rm unused code

e14eb1d

use modified values if present

b829695

rm getCleanResults

1de539b

inject from/to into listitem

792c3da

refactor code

8ae1e53

style narrow view

2e8245c

style narrow view

90fa358

refactor cells

2e2fa84

fix lint

61acc00

fix lint, typecheck

92caa11

fix typecheck

7950e9d

fix lint

5b7e9a9

fix amounts, use utils methods

eebf75d

fix avatars

fc66433

fix ts

293e030

do not show default merchant

042e42b

melvin-bot bot requested a review from amyevans May 2, 2024 22:22

grgia approved these changes May 3, 2024

View reviewed changes

grgia reviewed May 3, 2024

View reviewed changes

luacmartins merged commit da2cd90 into main May 3, 2024

luacmartins deleted the cmartins-transactionListItem branch May 3, 2024 14:17

luacmartins mentioned this pull request May 3, 2024

[$250] [Search v1] RHP reports show incorrect headers #41585

Closed

6 tasks

luacmartins mentioned this pull request May 3, 2024

Fix layout on ios #41615

Merged

50 tasks

luacmartins mentioned this pull request May 6, 2024

[$250] Table headers are misaligned when external mouse is connected #41693

Closed

6 tasks

github-actions bot mentioned this pull request May 7, 2024

Deploy Checklist: New Expensify 2024-05-07 #41716

Closed

luacmartins mentioned this pull request May 10, 2024

[HOLD for payment 2024-05-22] [$250] [Search v1] Create SearchPage #39880

Closed

Conversation

luacmartins commented Apr 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 2, 2024

Uh oh!

shawnborton commented May 3, 2024

Uh oh!

grgia commented May 3, 2024

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

grgia commented May 3, 2024

Uh oh!

grgia May 3, 2024

Choose a reason for hiding this comment

Uh oh!

rayane-d commented May 3, 2024

Uh oh!

luacmartins commented May 3, 2024

Uh oh!

OSBotify commented May 3, 2024

Uh oh!

luacmartins commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented May 3, 2024

Uh oh!

luacmartins commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented May 3, 2024

Uh oh!

luacmartins commented May 3, 2024

Uh oh!

luacmartins commented May 3, 2024

Uh oh!

shawnborton commented May 3, 2024

Uh oh!

luacmartins commented May 3, 2024

Uh oh!

luacmartins commented May 3, 2024

Uh oh!

shawnborton commented May 6, 2024

Uh oh!

luacmartins commented May 6, 2024

Uh oh!

shawnborton commented May 6, 2024

Uh oh!

OSBotify commented May 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

luacmartins commented Apr 30, 2024 •

edited

Loading

luacmartins commented May 3, 2024 •

edited

Loading

luacmartins commented May 3, 2024 •

edited

Loading