Fix padding for edit composer suggestions by dukenv0307 · Pull Request #41071 · Expensify/App

dukenv0307 · 2024-04-26T09:20:59Z

Details

Fixed Issues

$ #34442
#40861
#40864
#40856
#40854
PROPOSAL: #34442 (comment)

Tests

Open any report
Send some messages
Edit a message
Type @ and verify that the mention suggestion list appears with spacing between composer is 8px
Type :sm and verify that the emoji suggestion list appears with spacing between composer is 8px

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Open any report
Send some messages
Edit a message
Type @ and verify that the mention suggestion list appears with spacing between composer is 8px
Type :sm and verify that the emoji suggestion list appears with spacing between composer is 8px

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-28.at.16.19.33.mov

Android: mWeb Chrome

Screen.Recording.2024-08-28.at.16.30.52.mov

iOS: Native

Screen.Recording.2024-08-28.at.16.20.33.mov

iOS: mWeb Safari

Screen.Recording.2024-08-28.at.16.18.25.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-28.at.16.17.02.mov

MacOS: Desktop

Screen.Recording.2024-08-28.at.16.26.40.mov

melvin-bot · 2024-05-21T09:59:36Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2024-05-21T09:59:48Z

@eVoloshchak The PR is ready for review.

shawnborton · 2024-05-21T12:57:10Z

Design-wise this seems pretty good.

src/styles/utils/getAutoCompleteSuggestionContainerStyle/index.ts

src/styles/utils/getAutoCompleteSuggestionContainerStyle/index.native.ts

src/pages/home/report/ReportActionItemMessageEdit.tsx

src/libs/SuggestionUtils.ts

src/CONST.ts

src/styles/utils/getAutoCompleteSuggestionContainerStyle/index.ts

.../home/report/ReportActionCompose/ComposerWithSuggestionsEdit/ComposerWithSuggestionsEdit.tsx

src/pages/home/report/ReportActionItem.tsx

src/styles/utils/getAutoCompleteSuggestionContainerStyle/index.ts

src/libs/SuggestionUtils.ts

.../home/report/ReportActionCompose/ComposerWithSuggestionsEdit/ComposerWithSuggestionsEdit.tsx

eVoloshchak · 2024-05-29T20:33:19Z

src/styles/utils/getAutoCompleteSuggestionContainerPosition/index.ts

+    _containerHeight: number,
+): ViewStyle {
+    return {
+        top: -(height + (shouldBeDisplayedBelowParentContainer ? -2 : 1) * (suggestionsPadding + (shouldPreventScroll ? 0 : borderWidth))),


Suggested change

top: -(height + (shouldBeDisplayedBelowParentContainer ? -2 : 1) * (suggestionsPadding + (shouldPreventScroll ? 0 : borderWidth))),

top: -(height + (shouldBeDisplayedBelowParentContainer ? -CONST.AUTO_COMPLETE_SUGGESTER.BORDER_WIDTH : 1) * (suggestionsPadding + (shouldPreventScroll ? 0 : borderWidth))),

2 here does not mean CONST.AUTO_COMPLETE_SUGGESTER.BORDER_WIDTH.

dukenv0307 · 2024-06-06T07:35:01Z

@eVoloshchak I updated please help to check again.

eVoloshchak

On iOS, the following error pops up when suggestions or emoji list is opened (I suspect this might be resolved by merging main)

Screen.Recording.2024-06-11.at.14.33.25.mov

eVoloshchak · 2024-06-18T15:16:59Z

@dukenv0307, I'm still encountering the same error

Screen.Recording.2024-06-18.at.17.13.15.mov

Verified this doesn't exist on main. Could you double-check if this is working for you on iOS?

dukenv0307 · 2024-06-24T10:26:59Z

@eVoloshchak I tested and this bug is fixed now.

eVoloshchak

Suggestions and emoji list are displayed on top of the composer, this doesn't look right, can we remove it to the top?

It looks correctly on mWeb

shawnborton · 2024-06-25T20:46:21Z

We recently changed the top/bottom padding of our popovers to be 16px instead of 12px, so I wonder if we need to update the offset by 8px to correct that.

dannymcclain · 2024-06-26T14:33:52Z

We recently changed the top/bottom padding of our popovers to be 16px instead of 12px, so I wonder if we need to update the offset by 8px to correct that.

Oh good call Shawn, I bet that's why we're getting this little overlap with the composer.

dukenv0307 · 2024-07-04T08:41:57Z

@eVoloshchak I can't reproduce this bug above.

Screen.Recording.2024-07-04.at.15.41.28.mov

eVoloshchak

@dukenv0307, it is reproducible on Web and mWeb

Screen.Recording.2024-07-08.at.12.18.47.mov

It's also reproducible for the regular composer (not the edit one) on staging, we don't need to fix that in this PR, but I suspect it will be fixed for both with a single fix (@dukenv0307, could you please check if this does the trick?)

dukenv0307 · 2024-07-23T03:53:03Z

@eVoloshchak So we want to add a space between the suggestion and the composer, right?

eVoloshchak

So we want to add a space between the suggestion and the composer, right?

@dukenv0307, yes, it should have the same padding as the emoji modal for default composer

Currently, it overlaps with the edit composer

dukenv0307 · 2024-07-24T09:06:44Z

@eVoloshchak I updated, please help to check again.

eVoloshchak

Looking good now! (noting the same problem exists for the emoji modal, but that exists on staging and unrelated to this PR)

@dukenv0307, I'm a bit late, apologies for that, could you resolve the conflicts and I'll give this the last round of testing?

dukenv0307 · 2024-08-01T05:12:41Z

@eVoloshchak I updated.

eVoloshchak · 2024-08-05T09:41:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-07.at.13.41.32.mov

Android: mWeb Chrome

Screen.Recording.2024-10-07.at.13.44.50.mov

iOS: Native

Screen.Recording.2024-10-07.at.13.23.45.mov

iOS: mWeb Safari

Screen.Recording.2024-10-07.at.13.34.49.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-07.at.13.22.20.mov

MacOS: Desktop

Screen.Recording.2024-10-07.at.13.45.52.mov

eVoloshchak · 2024-08-05T10:07:04Z

@dukenv0307, when testing this I noticed that emoji suggestions have already been implemented for the edit composer

screen-20240805-120423.mp4

Am I missing something? Looks like the previous PR was reverted, was this added by another PR?

dukenv0307 · 2024-08-21T17:15:45Z

@eVoloshchak I updated.

eVoloshchak · 2024-08-21T19:30:23Z

@dukenv0307, we don't need any other changes besides different padding (fix for #41071 (review)). Treat this like a new PR (or go ahead and create a new PR, your choice)

dukenv0307 · 2024-08-22T03:55:35Z

we don't need any other changes besides different padding (fix for #41071 (review)). Treat this like a new PR (or go ahead and create a new PR, your choice)

@eVoloshchak This is all changes that we need to fix the padding issue.

eVoloshchak

Bug 1

suggestions list doesn't open when typing "@", emoji suggestions list doesn't open when starting to type an emoji name (this doesn't happen 100% of the times, but pretty consistently)

Screen.Recording.2024-08-27.at.14.54.37.mov

Bug 2 (Android)

Both lists overlap with the keyboard/UI (padding calculation is not correct)

Screen.Recording.2024-08-27.at.14.51.37.mov

In addition to that, could you please update the testing steps, retest this on all of the platforms and update the Screenshots/Videos section please?

dukenv0307 · 2024-08-28T09:34:08Z

suggestions list doesn't open when typing "@", emoji suggestions list doesn't open when starting to type an emoji name (this doesn't happen 100% of the times, but pretty consistently)

@eVoloshchak Is this bug reproducible on the latest main

Both lists overlap with the keyboard/UI (padding calculation is not correct)

I can't reproduce this bug.

In addition to that, could you please update the testing steps, retest this on all of the platforms and update the Screenshots/Videos section please?

I updated the test steps and screenshots.

eVoloshchak · 2024-09-04T15:03:52Z

Is this bug reproducible on the latest main

Confirmed this is reproducible on staging

I can't reproduce this bug.

I can reliably reproduce it on native Android

Screen.Recording.2024-09-04.at.17.01.54.mov

dukenv0307 · 2024-09-05T10:45:46Z

@eVoloshchak Did you try to disable the strict mode?

eVoloshchak · 2024-09-12T11:01:20Z

Turns out this is working correctly on a physical device, must be a problem with an emulator
@dukenv0307, could you pull the latest main please?

dukenv0307 · 2024-09-12T11:33:17Z

@eVoloshchak I updated.

eVoloshchak

Still doesn't look right on mWeb Safari. This isn't a simulator issue, current staging works fine in a simulator

Screen.Recording.2024-09-15.at.10.23.24.mov

dukenv0307 · 2024-09-24T04:15:04Z

Investigating.

dukenv0307 · 2024-09-25T10:53:13Z

@eVoloshchak This bug happens because measureInWindow returns the wrong y position on mWeb safari when the keyboard is opened. We can also reproduce this bug in staging and production.

Screen.Recording.2024-09-25.at.17.48.09.mov

Screen.Recording.2024-09-25.at.17.51.56.mov

Screen.Recording.2024-09-25.at.17.50.42.mov

dukenv0307 · 2024-10-02T08:08:02Z

@eVoloshchak Friendly bump.

eVoloshchak

LGTM!

github-actions · 2024-10-07T22:28:18Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.0.46-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

IuliiaHerets · 2024-10-08T08:32:14Z

This PR is failing for Android app because of issue #50377

github-actions · 2024-10-09T20:28:07Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.46-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

test commit

d03d194

Beamanator mentioned this pull request Apr 29, 2024

[HOLD for payment 2024-06-06] Chat - Suggestion list does not appear below composer when it is near chat header #40864

Closed

6 tasks

dukenv0307 marked this pull request as ready for review May 21, 2024 09:59

dukenv0307 requested review from a team as code owners May 21, 2024 09:59

melvin-bot bot requested review from eVoloshchak and removed request for a team May 21, 2024 09:59

eVoloshchak suggested changes May 22, 2024

View reviewed changes

eVoloshchak suggested changes May 24, 2024

View reviewed changes

src/pages/home/report/ReportActionItem.tsx Outdated Show resolved Hide resolved

src/styles/utils/getAutoCompleteSuggestionContainerStyle/index.ts Outdated Show resolved Hide resolved

eVoloshchak suggested changes May 29, 2024

View reviewed changes

eVoloshchak reviewed Jun 11, 2024

View reviewed changes

eVoloshchak mentioned this pull request Jun 18, 2024

[HOLD for payment 2024-10-16] [$500] Feature Request: Add :emojicode: selectors when editing messages. #34442

Closed

6 tasks

eVoloshchak reviewed Jun 25, 2024

View reviewed changes

eVoloshchak reviewed Jul 8, 2024

View reviewed changes

eVoloshchak reviewed Jul 24, 2024

View reviewed changes

eVoloshchak reviewed Jul 31, 2024

View reviewed changes

fix position issue of suggestion

7b4bedb

eVoloshchak reviewed Aug 27, 2024

View reviewed changes

Merge branch 'main' into fix/34442

e5fdccd

merge main

9435d87

eVoloshchak reviewed Sep 15, 2024

View reviewed changes

Merge branch 'main' into fix/34442

3fe6e4e

Merge branch 'main' into fix/34442

29bfe8b

eVoloshchak approved these changes Oct 7, 2024

View reviewed changes

melvin-bot bot requested a review from stitesExpensify October 7, 2024 11:49

stitesExpensify approved these changes Oct 7, 2024

View reviewed changes

stitesExpensify changed the title ~~Implement suggestion for edit composer~~ Fix padding for edit composer suggestions Oct 7, 2024

stitesExpensify merged commit 2859dc2 into Expensify:main Oct 7, 2024

github-actions bot mentioned this pull request Oct 7, 2024

Deploy Checklist: New Expensify 2024-10-07 #50366

Closed

50 tasks

lakchote mentioned this pull request Oct 8, 2024

Composer - Suggestion list is above the composer when typing @ in multiline text #50373

Closed

6 tasks

IuliiaHerets mentioned this pull request Oct 8, 2024

[$250] Android - Composer - Suggestion list is overlapping with text in the composer and buttons #50377

Closed

6 tasks

lakchote mentioned this pull request Oct 8, 2024

[CP Staging] Revert "Fix padding for edit composer suggestions" #50380

Merged

	top: -(height + (shouldBeDisplayedBelowParentContainer ? -2 : 1) * (suggestionsPadding + (shouldPreventScroll ? 0 : borderWidth))),
	top: -(height + (shouldBeDisplayedBelowParentContainer ? -CONST.AUTO_COMPLETE_SUGGESTER.BORDER_WIDTH : 1) * (suggestionsPadding + (shouldPreventScroll ? 0 : borderWidth))),

Conversation

dukenv0307 commented Apr 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 21, 2024

Uh oh!

dukenv0307 commented May 21, 2024

Uh oh!

shawnborton commented May 21, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eVoloshchak May 29, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Jun 6, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Jun 6, 2024

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented Jun 18, 2024

Uh oh!

dukenv0307 commented Jun 24, 2024

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Jun 25, 2024

Uh oh!

dannymcclain commented Jun 26, 2024

Uh oh!

dukenv0307 commented Jul 4, 2024

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Jul 23, 2024

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Jul 24, 2024

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Aug 1, 2024

Uh oh!

eVoloshchak commented Aug 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented Aug 5, 2024

Uh oh!

dukenv0307 commented Aug 21, 2024

Uh oh!

eVoloshchak commented Aug 21, 2024

dukenv0307 commented Apr 26, 2024 •

edited

Loading

eVoloshchak commented Aug 5, 2024 •

edited

Loading