Skip to content

[CP Staging] Revert "Fix padding for edit composer suggestions"#50380

Merged
lakchote merged 1 commit intomainfrom
revert-41071-fix/34442
Oct 8, 2024
Merged

[CP Staging] Revert "Fix padding for edit composer suggestions"#50380
lakchote merged 1 commit intomainfrom
revert-41071-fix/34442

Conversation

@lakchote
Copy link
Contributor

@lakchote lakchote commented Oct 8, 2024

Reverts #41071 (see this discussion)

Will fix blocker #50373

@lakchote lakchote self-assigned this Oct 8, 2024
@lakchote lakchote requested a review from a team as a code owner October 8, 2024 09:08
@melvin-bot melvin-bot bot requested a review from stitesExpensify October 8, 2024 09:08
@melvin-bot
Copy link

melvin-bot bot commented Oct 8, 2024

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team October 8, 2024 09:08
@lakchote lakchote merged commit ab2c314 into main Oct 8, 2024
@lakchote lakchote deleted the revert-41071-fix/34442 branch October 8, 2024 09:43
@melvin-bot melvin-bot bot added the Emergency label Oct 8, 2024
@melvin-bot
Copy link

melvin-bot bot commented Oct 8, 2024

@lakchote looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@lakchote
Copy link
Contributor Author

lakchote commented Oct 8, 2024

Since it's just a revert PR, no author nor reviewer checklists are needed. Removing the emergency label.

@lakchote lakchote removed the Emergency label Oct 8, 2024
OSBotify pushed a commit that referenced this pull request Oct 8, 2024
[CP Staging] Revert "Fix padding for edit composer suggestions"

(cherry picked from commit ab2c314)

(CP triggered by mountiny)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Oct 8, 2024
@OSBotify
Copy link
Contributor

OSBotify commented Oct 8, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.46-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.46-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants