Fix QBO config types + fix inputs in config pages by aldo-expensify · Pull Request #41463 · Expensify/App

aldo-expensify · 2024-05-01T22:25:14Z

Details

Fix QBO config and data types to contain the real properties we use in the backend
Rename some constants and move some translation code around
Fix some fields that we not working, for example: default vendor for reimbursable (card export)

With this PR the default settings should appear correctly selected in the Import/Export/Advance settings

Fixed Issues

$ #41095
$ #41155 (comment)
PROPOSAL:

Tests

Create account in NewDot
Create Workspace
Enable "Accounting" in "More Features"
Connect QBO
Check that the Import/Export/Advanced settings look correct

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create account in NewDot
Create Workspace
Enable "Accounting" in "More Features"
Connect QBO
Check that the Import/Export/Advanced settings look correct

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I verified that similar component doesn't exist in the codebase
I verified that all props are defined accurately and each prop has a /** comment above it */
I verified that each file is named correctly
I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
I verified that the only data being stored in component state is data necessary for rendering and nothing else
In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
I verified that component internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
I verified that all JSX used for rendering exists in the render method
I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-05-01.at.6.48.59.PM.mov

MacOS: Desktop

aldo-expensify · 2024-05-02T01:44:51Z

@trjExpensify I'm building an adhoc build, when you have some time, I would appreciate if you can test the Import, Export and Advance settings.

Know issues that this PR is not solving: When you change field that triggers a change on another field are still not handled well.

melvin-bot · 2024-05-02T01:51:00Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-05-02T01:51:06Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2024-05-02T04:10:38Z

@aldo-expensify Is it necessary to create a new account?

aldo-expensify · 2024-05-02T04:18:02Z

Nop, neither a new workspace

…

On Wed, May 1, 2024, 21:11 Manan ***@***.***> wrote: @aldo-expensify <https://github.com/aldo-expensify> Is it necessary to create a new account? — Reply to this email directly, view it on GitHub <#41463 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AU2LVBRO6CSMSH3LZYDKHFLZAG4FJAVCNFSM6AAAAABHCU2MCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBZGQ4TMMBRHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

mananjadhav · 2024-05-02T04:28:25Z

Cool I’ll use my existing workspace then.

hayata-suenaga

the code looks good to me

I gonna rely on @allroundexperts' tests 🙇

allroundexperts · 2024-05-02T13:56:26Z

You meant @mananjadhav. No @hayata-suenaga?

mananjadhav · 2024-05-02T14:09:13Z

src/languages/en.ts

+            importTypes: {
+                [CONST.INTEGRATION_ENTITY_MAP_TYPES.IMPORTED]: 'Imported, displayed as tags',
+                [CONST.INTEGRATION_ENTITY_MAP_TYPES.TAG]: 'Imported, displayed as tags',
+                [CONST.INTEGRATION_ENTITY_MAP_TYPES.DEFAULT]: 'Imported, displayed as tags',


Should this be displayed as tags? or Xero default?

Oh, your are right, I think before this was showing as Imported

mananjadhav · 2024-05-02T14:14:26Z

src/types/onyx/Policy.ts

    creditCards: Account[];
    accountsReceivable: Account[];
-    accountsPayable: Account[];
+    accountPayable: Account[];


I saw this change at a few places with accountsPayable replaced with accountPayable, but considering it's an array should we be retaining plural form?

Pretty sure accountPayable is how we get it from the QBO connection data. The accountsPayable typo we have now in prod on NewDot causes the list of AP accounts to be blank.

Thanks for confirming. Just about to test it now.

We can't rename this fields at this point otherwise the backend won't recognize them. We have to stick with accountPayable even if it is an array

mananjadhav · 2024-05-02T14:29:48Z

@aldo-expensify When I click on Preferred Exporter, it takes me to Not found page.

Screen.Recording.2024-05-02.at.7.56.45.PM.mov

trjExpensify · 2024-05-02T14:30:34Z

Haha, is this adhoc build bust? #41463 (comment)

Nothing worked 😂

2024-05-02_15-21-55.mp4

mananjadhav · 2024-05-02T14:34:04Z

I tried running the adhoc build, but I didn't receive the magic code. The error that I got was on the local build.

mananjadhav · 2024-05-02T15:30:55Z

I found two errors and both of them are reproducible on staging as well. So I am assuming unrelated to the PR.

mananjadhav · 2024-05-02T15:32:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-qbo-config.mov

Android: mWeb Chrome

mweb-chrome-qbo-config.mov

iOS: Native

ios-qbo-config.mov

iOS: mWeb Safari

mweb-safari-qbo-config.mov

MacOS: Chrome / Safari

web-qbo-config.mov

MacOS: Desktop

desktop-qbo-config.mov

aldo-expensify · 2024-05-02T17:48:38Z

@aldo-expensify When I click on Preferred Exporter, it takes me to Not found page.

Good catch, I'll fix it

aldo-expensify · 2024-05-02T17:54:38Z

Haha, is this adhoc build bust? #41463 (comment)

Nothing worked 😂

haha I also tried, I don't know why it is so broken :(

aldo-expensify · 2024-05-02T18:04:00Z

@aldo-expensify When I click on Preferred Exporter, it takes me to Not found page.

Good catch, I'll fix it

Ah, I see this is a problem that already exists in main. The page QuickBooksExportPreferredExporterPage is not used at all.

I'll merge this to avoid conflicts considering the size of the PR.
I'll fix the exporter in a follow up.

aldo-expensify · 2024-05-02T18:08:38Z

@hayata-suenaga @mananjadhav , I'll address the problems that were already in main in a follow up. I fixed the translations I made.

Please review again :)

github-actions · 2024-05-02T19:13:41Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the web build failed

👀 View the workflow run that generated this build 👀

OSBotify · 2024-05-09T02:12:01Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix QBO config types

988b2da

aldo-expensify self-assigned this May 1, 2024

aldo-expensify mentioned this pull request May 1, 2024

Fix account type name constants #41155

Merged

48 tasks

aldo-expensify added 12 commits May 1, 2024 16:12

Fix account types

e27022f

Fix constants/types/variables

4e159bd

Fix export configuration

598c540

More fix constants/types/variables

8cde034

Fix receivableAccount

6fa0225

Improve select options

8239da5

Fix dependencies

8bb20a0

Add default vendor select / more type and config fixes

678b68f

Fix chart of accounts and improve import page

f106db7

Fix sync taxes translations

2bcaa09

Fix broken translation

c647a57

Add default vendor select page

a0ff802

aldo-expensify added the Ready To Build label May 2, 2024

aldo-expensify marked this pull request as ready for review May 2, 2024 01:50

aldo-expensify requested a review from a team as a code owner May 2, 2024 01:50

melvin-bot bot requested review from hoangzinh and removed request for a team May 2, 2024 01:50

aldo-expensify requested review from a team and hayata-suenaga and removed request for hoangzinh May 2, 2024 01:51

melvin-bot bot requested review from mananjadhav and removed request for a team May 2, 2024 01:51

aldo-expensify changed the title ~~Fix QBO config types~~ Fix QBO config types + fix inputs in config pages May 2, 2024

This comment has been minimized.

Sign in to view

hayata-suenaga previously approved these changes May 2, 2024

View reviewed changes

mananjadhav reviewed May 2, 2024

View reviewed changes

Fix translations

145ccf8

aldo-expensify dismissed hayata-suenaga’s stale review via 145ccf8 May 2, 2024 18:07

aldo-expensify requested review from hayata-suenaga and mananjadhav May 2, 2024 18:09

hayata-suenaga approved these changes May 2, 2024

View reviewed changes

aldo-expensify merged commit daf3045 into main May 2, 2024

aldo-expensify deleted the aldo_fix-inputs-qbo-accounting branch May 2, 2024 18:54

aldo-expensify mentioned this pull request May 2, 2024

Fix Preferred exporter page + country crash #41530

Merged

50 tasks

github-actions bot mentioned this pull request May 7, 2024

Deploy Checklist: New Expensify 2024-05-07 #41716

Closed

s77rt mentioned this pull request May 29, 2024

[HOLD for payment 2024-06-03] [QBO] Not all default settings & accounts are selected when establishing the connection to QBO #41046

Closed

6 tasks

Conversation

aldo-expensify commented May 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

aldo-expensify commented May 2, 2024

Uh oh!

melvin-bot bot commented May 2, 2024

Uh oh!

melvin-bot bot commented May 2, 2024

Uh oh!

This comment has been minimized.

mananjadhav commented May 2, 2024

Uh oh!

aldo-expensify commented May 2, 2024 via email

Uh oh!

mananjadhav commented May 2, 2024

Uh oh!

hayata-suenaga left a comment

Choose a reason for hiding this comment

Uh oh!

allroundexperts commented May 2, 2024

Uh oh!

mananjadhav May 2, 2024

Choose a reason for hiding this comment

Uh oh!

aldo-expensify May 2, 2024

Choose a reason for hiding this comment

Uh oh!

mananjadhav May 2, 2024

Choose a reason for hiding this comment

Uh oh!

trjExpensify May 2, 2024

Choose a reason for hiding this comment

Uh oh!

mananjadhav May 2, 2024

Choose a reason for hiding this comment

Uh oh!

aldo-expensify May 2, 2024

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented May 2, 2024

Uh oh!

trjExpensify commented May 2, 2024

Uh oh!

mananjadhav commented May 2, 2024

Uh oh!

mananjadhav commented May 2, 2024

Uh oh!

mananjadhav commented May 2, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

aldo-expensify commented May 2, 2024

Uh oh!

aldo-expensify commented May 2, 2024

Uh oh!

aldo-expensify commented May 2, 2024

Uh oh!

aldo-expensify commented May 2, 2024

Uh oh!

github-actions bot commented May 2, 2024

Uh oh!

OSBotify commented May 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aldo-expensify commented May 1, 2024 •

edited

Loading