Fix Preferred exporter page + country crash by aldo-expensify · Pull Request #41530 · Expensify/App

aldo-expensify · 2024-05-02T19:35:51Z

Details

Fixes the Preferred exporter page for the QBO Export settings
Fixes this country crash: #41095 (comment)

Fixed Issues

$ #41463 (comment) (preferred exporter page not working)
$ #41095 (comment) (country crash)
PROPOSAL:

Tests

Create Workspace
Enable "Accounting" in "More Settings"
Connect to Qbo
Once the connection is done, go to "Export"
Click on the first setting "Preferred exporter"
Verify that the page to change the settings opens correctly and you don't get a "Not Found"

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create Workspace
Enable "Accounting" in "More Settings"
Connect to Qbo
Once the connection is done, go to "Export"
Click on the first setting "Preferred exporter"
Verify that the page to change the settings opens correctly and you don't get a "Not Found"

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-05-02.at.12.34.01.PM.mov

MacOS: Desktop

melvin-bot · 2024-05-02T19:35:56Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-05-02T20:08:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/41530/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/41530/NewExpensify.dmg	https://41530.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

hayata-suenaga · 2024-05-02T20:09:05Z

src/pages/workspace/accounting/qbo/import/QuickbooksImportPage.tsx

    ];

-    if (policy?.connections?.quickbooksOnline.data.country !== CONST.COUNTRY.US) {
+    if (policy?.connections?.quickbooksOnline?.data?.country !== CONST.COUNTRY.US) {


NAB: should we also mark these fields optional in the TS definition (Policy.ts)?

hmm that is probably a good idea, then we wouldn't get a random crash because our types would catch it

I tried it, but it breaks all calls to updatePolicyConnectionConfig because something goes wrong with the parameter types:

I'll leave investigating this for another occasion

hayata-suenaga · 2024-05-02T20:14:18Z

@alitoshmatov, we needed review quite quickly so I assigned @ikevin127 who was available at this time

trjExpensify · 2024-05-02T20:49:23Z

Few things when testing, not sure if I should have all the recent code merged to main + the changes in this PR:

None of the defaults were set when connecting to QBO, even Chart of Accounts shows Not imported
We're missing the A/P accounts returned in the list still
Choosing Account for Credit card or Debit card shows a page for "Default vendor" instead of Account
The Vendor row appears before you've toggled on Default vendor (Nikolay's PR was initially looking at this)
The preferred exporter list returns the assignedGuide admin on the workspace, we should filter those out like we do in the Members table
Invoices page is blank, it doesn't have the account receivables accounts returned
When trying to enable "Sync reimbursed reports" I'm still getting this TypeError: Uncaught TypeError: TaskQueue: Error with task : Cannot read properties of undefined (reading 'id')
I don't understand the note on Locations, I'll dive into that in a bit

2024-05-02_21-29-29.mp4

aldo-expensify · 2024-05-02T20:51:46Z

Few things when testing, not sure if I should have all the recent code merged to main + the changes in this PR:

Yeah, it looks massively broken in your tests, but I will blame the adhoc builds again. You seem to be getting some network errors that should have work, for example:

So that may be making everything fail after

…on to undefined

aldo-expensify · 2024-05-02T21:00:04Z

src/libs/actions/connections/index.ts

    connectionName: TConnectionName,
    settingName: TSettingName,
-    settingValue?: Partial<Connections[TConnectionName]['config'][TSettingName]>,
+    settingValue: Partial<Connections[TConnectionName]['config'][TSettingName]>,


Fixed this here because settingValue is NOT optional. This was causing backend server errors.

aldo-expensify · 2024-05-02T21:00:26Z

src/pages/workspace/accounting/qbo/export/QuickbooksOutOfPocketExpenseEntitySelectPage.tsx

-    useEffect(() => {
-        if (!isTaxError && !isLocationError) {
-            return;
-        }
-        Connections.updatePolicyConnectionConfig(policyID, CONST.POLICY.CONNECTIONS.NAME.QBO, CONST.QUICK_BOOKS_CONFIG.REIMBURSABLE_EXPENSES_EXPORT_DESTINATION);
-    }, [policyID, isTaxError, isLocationError]);
-


This was calling updatePolicyConnectionConfig with an invalid value, which did nothing and is an anti-pattern in our app.

We can fix this as part 1. of this issue: https://github.com/Expensify/Expensify/issues/390731

ikevin127 · 2024-05-02T21:05:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native *

ios.MP4

iOS: mWeb Safari

MacOS: Chrome / Safari *

web.mov

MacOS: Desktop

ikevin127

Tests well following PR's description steps regarding the "Not found" page error.

✅ Additionally, following #41095 (comment), the country undefined crash seems to be fixed on my side with the following steps:

Toggle "Sync reimbursed reports" on and off.
Click on Import to open the Import RHP, then also click on every RHP option.

LGTM 🚀 ~~(lint check should pass though)~~ ✅

melvin-bot · 2024-05-02T21:10:28Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aldo-expensify · 2024-05-02T21:12:09Z

Thanks @ikevin127 , please re-approve, I had to remove an unused import (lint)

ikevin127 · 2024-05-02T21:18:29Z

@aldo-expensify All good, the only issue was lint not passing but you got that covered. I pulled latest changes and re-tested the steps mentioned at #41530 (review) -> everything works as expected.

Approved ✅

trjExpensify · 2024-05-02T21:47:43Z

Looking at Kevin's video in the checklist. This one seems incorrect:

Credit card export should not have a list of Vendors returned:

Here's OldDot for reference:

trjExpensify · 2024-05-02T21:51:30Z

Debit card should be bank accounts:

Vendor bills should be:

Account payable accounts:

If default vendor is toggled on, then an additional row and a list of vendors to pick from:

trjExpensify · 2024-05-02T22:13:36Z

Alright, I did a sync now on the adhoc build and now I can at least see all the accounts and stuff.

This is still showing, so looks like a bug: Fix Preferred exporter page + country crash #41530 (comment)
When you select Vendor bill for non-reimbursable export, you get Capital one (a card account) as a placeholder in the push input of the Accounts payable account field.

2024-05-02_22-57-15.mp4

The preferred exporter isn't filtering out the assignedGuide in the list like the members table:

aldo-expensify · 2024-05-02T22:41:24Z

This is still showing, so looks like a bug: #41530 (comment)

Are you referring to that it is showing in the placeholder an account of the wrong type selected? This is out of the scope here.

When you select Vendor bill for non-reimbursable export, you get Capital one (a card account) as a placeholder in the push input of the Accounts payable account field.

I think this problem will remain until we solve: https://github.com/Expensify/Expensify/issues/390731

The preferred exporter isn't filtering out the assignedGuide in the list like the members table:

Note that his PR is only enabling the existing Preferred exporter page, I'm not fixing bugs found inside it. If I find it an easy fix, I'll do it here, otherwise in a follow up pr

aldo-expensify · 2024-05-02T22:49:32Z

I'll merge this since filtering out the guide is a bit more complicated and it is a bug that was already there. I'll fix it in a follow up.

OSBotify · 2024-05-02T22:55:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-09T02:12:52Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aldo-expensify added 2 commits May 2, 2024 12:19

Fix country crash

051b199

Fix preferred exporter page

e8dba5b

aldo-expensify requested a review from hayata-suenaga May 2, 2024 19:35

aldo-expensify self-assigned this May 2, 2024

aldo-expensify requested a review from a team as a code owner May 2, 2024 19:35

melvin-bot bot requested review from alitoshmatov and removed request for a team May 2, 2024 19:35

aldo-expensify added the Ready To Build label May 2, 2024

hayata-suenaga reviewed May 2, 2024

View reviewed changes

hayata-suenaga previously approved these changes May 2, 2024

View reviewed changes

hayata-suenaga requested review from ikevin127 and removed request for alitoshmatov May 2, 2024 20:13

Remove invalid call trying to set reimbursableExpensesExportDestinati…

14afd15

…on to undefined

aldo-expensify dismissed hayata-suenaga’s stale review via 14afd15 May 2, 2024 20:59

aldo-expensify commented May 2, 2024

View reviewed changes

aldo-expensify requested a review from hayata-suenaga May 2, 2024 21:00

ikevin127 approved these changes May 2, 2024

View reviewed changes

melvin-bot bot requested a review from carlosmiceli May 2, 2024 21:10

Lint

55a5cb4

hayata-suenaga approved these changes May 2, 2024

View reviewed changes

aldo-expensify merged commit 5808670 into main May 2, 2024

aldo-expensify deleted the aldo_fix-preferred-exporter branch May 2, 2024 22:49

aldo-expensify mentioned this pull request May 2, 2024

Exclude guides from preferred exporter #41548

Merged

50 tasks

ikevin127 mentioned this pull request May 3, 2024

Add missing multi tag view #41351

Merged

50 tasks

github-actions bot mentioned this pull request May 7, 2024

Deploy Checklist: New Expensify 2024-05-07 #41716

Closed

ikevin127 mentioned this pull request May 9, 2024

[Awaiting Payment May 15th] [QBO] advanced configuration: selected accounts are not selected after Relogin #41095

Closed

6 tasks

Conversation

aldo-expensify commented May 2, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 2, 2024

Uh oh!

github-actions bot commented May 2, 2024

Uh oh!

hayata-suenaga May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aldo-expensify May 2, 2024

Choose a reason for hiding this comment

Uh oh!

aldo-expensify May 2, 2024

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga commented May 2, 2024

Uh oh!

trjExpensify commented May 2, 2024

Uh oh!

aldo-expensify commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldo-expensify May 2, 2024

Choose a reason for hiding this comment

Uh oh!

aldo-expensify May 2, 2024

Choose a reason for hiding this comment

Uh oh!

aldo-expensify May 2, 2024

Choose a reason for hiding this comment

Uh oh!

ikevin127 commented May 2, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

ikevin127 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented May 2, 2024

Uh oh!

aldo-expensify commented May 2, 2024

Uh oh!

ikevin127 commented May 2, 2024

Uh oh!

trjExpensify commented May 2, 2024

Uh oh!

trjExpensify commented May 2, 2024

Uh oh!

trjExpensify commented May 2, 2024

Uh oh!

aldo-expensify commented May 2, 2024

Uh oh!

aldo-expensify commented May 2, 2024

Uh oh!

OSBotify commented May 2, 2024

Uh oh!

OSBotify commented May 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hayata-suenaga May 2, 2024 •

edited

Loading

aldo-expensify commented May 2, 2024 •

edited

Loading

ikevin127 left a comment •

edited

Loading