fix: admin can access member details page after member leaves by tienifr · Pull Request #41492 · Expensify/App

tienifr · 2024-05-02T11:47:14Z

Details

The side bar for the member remains open on the admin side after member leaves the workspace. This PR fixes that.

Fixed Issues

$ #40416
PROPOSAL: #40416 (comment)

Tests

[Admin] Invite an user to a Collect workspace
Open that member's details page
[Member] Leave the workspace
[Admin] Verify the member details page shows not found
=====
[Admin] Invite an user to a workspace
Open that member's details page in 2 tabs
Remove that member from the first tab
Verify the member details page dismisses

Verify that no errors appear in the JS console

Offline tests

QA Steps

[Admin] Invite an user to a Collect workspace
Open that member's details page
[Member] Leave the workspace
[Admin] Verify the member details page shows not found
=====
[Admin] Invite an user to a workspace
Open that member's details page in 2 tabs
Remove that member from the first tab
Verify the member details page dismisses

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

video_2024-05-04_23-21-05.mp4

Android: mWeb Chrome

video_2024-05-04_23-21-00.mp4

iOS: Native

Screen.Recording.2024-05-04.at.22.57.13-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-05-04.at.22.54.45-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-04.at.22.43.11-compressed.mov

Untitled.mov

MacOS: Desktop

Screen.Recording.2024-05-04.at.22.50.35-compressed.mov

melvin-bot · 2024-05-04T16:23:56Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

alitoshmatov · 2024-05-07T19:25:00Z

Sorry I was busy with other issues, I will finish reviewing tomorrow

alitoshmatov · 2024-05-08T21:09:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

employee-page404-mweb.mov

iOS: Native

employee-page404-ios.mp4

iOS: mWeb Safari

employee-page404-safari.mp4

MacOS: Chrome / Safari

employee-page404-web.mov

MacOS: Desktop

employee-age404-desktop.mov

alitoshmatov

LGTM!

madmax330 · 2024-05-13T11:24:59Z

src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

        Navigation.navigate(ROUTES.WORKSPACE_OWNER_CHANGE_CHECK.getRoute(policyID, accountID, 'amountOwed' as ValueOf<typeof CONST.POLICY.OWNERSHIP_ERRORS>));
    }, [accountID, policyID]);

+    // eslint-disable-next-line rulesdir/no-negated-variables


Hmm I don't think you should use the lint rule here.

You can just change the conditional

I think the lint rule is a bit too strict, it should only block actual negated variable names like shouldNotShow but not shouldShowNotFoundPage because the not here is not really a negated adverb. I think it's fine since we're already using it many places in App.

But I still updated as your feedback.

const shouldShowPage = member && (member.pendingAction !== DELETE || prevMember?.pendingAction !== DELETE);

Ah ok, that makes sense, I guess that OK
Maybe you can add a comment to explain why the lint exception is appropriate.
I agree that shouldShowPage is a confusing name.

This reverts commit 83b9cc7.

OSBotify · 2024-05-16T06:15:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-23T00:39:24Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.4.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-27T14:02:32Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.75-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2025-02-04T15:53:33Z

src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx


+    // eslint-disable-next-line rulesdir/no-negated-variables
+    const shouldShowNotFoundPage =
+        !member || (member.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && prevMember?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);


Coming from #54938, we missed the case of removing a member whilst offline. The useNetwork hook triggers an extra render, so member.pendingAction and prevMember.pendingAction are both delete as the modal is closing. See the proposal for more details.

c3024 · 2025-07-15T16:54:36Z

src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

+        if (!prevMember || prevMember?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || member?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
+            return;
+        }
+        Navigation.goBack();


This navigation should happen after the interactions are complete for iOS. It caused #65142.

tienifr added 3 commits May 2, 2024 18:46

fix: admin can access member details page after member leaves

e724493

Merge branch 'main' of https://github.com/tienifr/App into fix/40416

e834286

not found page with wrapper

f1d86f0

tienifr marked this pull request as ready for review May 4, 2024 16:23

tienifr requested a review from a team as a code owner May 4, 2024 16:23

melvin-bot bot requested review from alitoshmatov and removed request for a team May 4, 2024 16:23

alitoshmatov approved these changes May 8, 2024

View reviewed changes

melvin-bot bot requested a review from madmax330 May 8, 2024 21:09

madmax330 requested changes May 13, 2024

View reviewed changes

tienifr added 4 commits May 15, 2024 16:10

Merge branch 'main' of https://github.com/tienifr/App into fix/40416

fc15f14

do not use negated variable name

83b9cc7

Revert "do not use negated variable name"

f913df5

This reverts commit 83b9cc7.

Merge branch 'main' of https://github.com/tienifr/App into fix/40416

59918af

madmax330 approved these changes May 16, 2024

View reviewed changes

madmax330 merged commit 18bc082 into Expensify:main May 16, 2024

github-actions bot mentioned this pull request May 22, 2024

Deploy Checklist: New Expensify 2024-05-22 #42496

Closed

45 tasks

lanitochka17 mentioned this pull request May 23, 2024

[Hold #43508] Workspace - "Hidden" members appear in the list when a member leaves #42555

Closed

6 tasks

melvin-bot bot mentioned this pull request May 27, 2024

[HOLD for payment 2024-06-03] [$250] Workspace - Admin can access member details side bar after member leaves workspace #40416

Closed

6 tasks

alitoshmatov mentioned this pull request Jun 2, 2024

#35715 workspace member details page #37715

Merged

50 tasks

twilight2294 mentioned this pull request Jan 10, 2025

[HOLD for payment 2025-02-05] [$250] Web - Workspace - "It's not here" error briefly appears when removing a member offline #54938

Closed

8 tasks

jjcoffee reviewed Feb 4, 2025

View reviewed changes

c3024 reviewed Jul 15, 2025

View reviewed changes

Conversation

tienifr commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 4, 2024

Uh oh!

alitoshmatov commented May 7, 2024

Uh oh!

alitoshmatov commented May 8, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

alitoshmatov left a comment

Choose a reason for hiding this comment

Uh oh!

madmax330 May 13, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

madmax330 May 15, 2024

Choose a reason for hiding this comment

Uh oh!

madmax330 May 15, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr May 16, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 16, 2024

Uh oh!

OSBotify commented May 23, 2024

Uh oh!

OSBotify commented May 27, 2024

Uh oh!

jjcoffee Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

c3024 Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tienifr commented May 2, 2024 •

edited

Loading

tienifr May 15, 2024 •

edited

Loading