Fix split amount input does not animate smoothly by bernhardoj · Pull Request #42241 · Expensify/App

bernhardoj · 2024-05-16T06:03:26Z

Details

The input currently use autoGrow which needs to initialize the width from the onLayout event, so for a brief moment, the width is 0. This PR changes it to a fixed width input.

Fixed Issues

$ #41751
PROPOSAL: #41751 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open split bill from FAB and enter any amount
Select any user participant and press next
In the confirm page, verify the split input shows without delay

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-16.at.13.56.47.mov

Android: mWeb Chrome

Screen.Recording.2024-05-16.at.13.54.10.mov

iOS: Native

Screen.Recording.2024-05-16.at.13.52.11.mov

iOS: mWeb Safari

Screen.Recording.2024-05-16.at.13.53.09.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-16.at.13.54.48.mov

MacOS: Desktop

Screen.Recording.2024-05-16.at.13.56.03.mov

melvin-bot · 2024-05-16T06:03:31Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2024-05-16T06:03:32Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-05-16T06:06:50Z

@youssef-lr I noticed another issue. The cents amount doesn't show immediately as you can see from the video below (0:10)

Screen.Recording.2024-05-16.at.13.56.47.mov

This is because the initial state of the amount is always converted to the FE amount that removes the cent (/ 100).

App/src/components/MoneyRequestAmountInput.tsx

Lines 116 to 118 in e9cf0c5

    
           const selectedAmountAsString = amount ? CurrencyUtils.convertToFrontendAmount(amount).toString() : ''; 
        
           const [currentAmount, setCurrentAmount] = useState(selectedAmountAsString);

I want to do it like this

App/src/components/MoneyRequestAmountInput.tsx

Line 185 in e9cf0c5

    
           const frontendAmount = formatAmountOnBlur ? CurrencyUtils.convertToDisplayStringWithoutCurrency(amount, currency) : CurrencyUtils.convertToFrontendAmount(amount).toString();

but I think formatAmountOnBlur doesn't sound correct. Should we rename it to something else or just keep the name?

bernhardoj · 2024-05-20T10:12:25Z

Ok I fixed it by moving the logic to a prop (onFormatAmount), this allows for more reusablity for having different formatting logic.

youssef-lr · 2024-05-20T10:16:36Z

I noticed another issue. The cents amount doesn't show immediately as you can see from the video below

I don't remember seeing this issue initially, could it be from the refactor to using UserListItem?

bernhardoj · 2024-05-20T10:18:32Z

src/components/MoneyRequestAmountInput.tsx

    const textInput = useRef<BaseTextInputRef | null>(null);

    const decimals = CurrencyUtils.getCurrencyDecimals(currency);
-    const selectedAmountAsString = amount ? CurrencyUtils.convertToFrontendAmount(amount).toString() : '';


I think it's been there because this is an old logic. selectedAmountAsString is used as the initial state for the amount and we don't use the correct formatting logic for our case.

ah okay, that makes sense, thanks for catching this!

youssef-lr · 2024-05-22T17:24:02Z

bump @abdulrahuman5196 for review please

abdulrahuman5196 · 2024-05-28T10:27:51Z

Checking now

abdulrahuman5196 · 2024-05-28T12:47:32Z

@bernhardoj I am seeing layout issues in android chrome which is not present in staging. Other platforms there is no issue. Could you check on this?

Screen.Recording.2024-05-28.at.6.14.07.PM.mov

bernhardoj · 2024-05-28T12:57:38Z

IT's a known issue. I have merged with main to pull the fix.

abdulrahuman5196 · 2024-05-28T17:53:44Z

IT's a known issue. I have merged with main to pull the fix.

Got it. Thank you.

abdulrahuman5196 · 2024-05-28T17:55:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-28.at.6.04.41.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-05-28.at.11.23.12.PM.mov

iOS: Native

Screen.Recording.2024-05-28.at.5.58.47.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-05-28.at.6.03.54.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-28.at.5.31.12.PM.mov

MacOS: Desktop

Screen.Recording.2024-05-28.at.5.48.18.PM.mov

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @youssef-lr

🎀 👀 🎀
C+ Reviewed

youssef-lr

LGTM

OSBotify · 2024-05-29T16:45:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-30T21:54:23Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:30:53Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-04T13:56:55Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

make the split amount input a fixed width

70584ff

bernhardoj requested a review from a team as a code owner May 16, 2024 06:03

melvin-bot bot removed the request for review from a team May 16, 2024 06:03

melvin-bot bot requested a review from abdulrahuman5196 May 16, 2024 06:03

refactor formatting logic to be a props

2522b60

move the amount chceking outside the function

3f7b486

bernhardoj commented May 20, 2024

View reviewed changes

pass currency

d1aa802

Merge branch 'main' into fix/41751-split-amount-doesnt-animate-smoothly

f784e54

abdulrahuman5196 approved these changes May 28, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr May 28, 2024 18:00

youssef-lr approved these changes May 29, 2024

View reviewed changes

youssef-lr merged commit 0cce499 into Expensify:main May 29, 2024

github-actions bot mentioned this pull request May 30, 2024

Deploy Checklist: New Expensify 2024-05-30 #42872

Closed

95 tasks

melvin-bot bot mentioned this pull request Jun 4, 2024

[HOLD for payment 2024-06-11] [$250] [Uneven Splits] [Polish] Android - Split amount input does not animate smoothly #41751

Closed

6 tasks

Conversation

bernhardoj commented May 16, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 16, 2024

Uh oh!

melvin-bot bot commented May 16, 2024

Uh oh!

bernhardoj commented May 16, 2024

Uh oh!

bernhardoj commented May 20, 2024

Uh oh!

youssef-lr commented May 20, 2024

Uh oh!

bernhardoj May 20, 2024

Choose a reason for hiding this comment

Uh oh!

youssef-lr May 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

youssef-lr commented May 22, 2024

Uh oh!

abdulrahuman5196 commented May 28, 2024

Uh oh!

abdulrahuman5196 commented May 28, 2024

Uh oh!

bernhardoj commented May 28, 2024

Uh oh!

abdulrahuman5196 commented May 28, 2024

Uh oh!

abdulrahuman5196 commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

youssef-lr left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented May 29, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented May 30, 2024

Uh oh!

OSBotify commented Jun 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

youssef-lr May 20, 2024 •

edited

Loading

abdulrahuman5196 commented May 28, 2024 •

edited

Loading