Prevent large attachment

[rushatgabhane]

Details

Acceptable API attachment size: Less than 50 MB (52428800 bytes). Source

ConfirmModal is used to display a message when a larger file is uploaded.

The following language is added.

English

Attachment too large
Attachment size is larger than 50 MB limit.

Spanish (Source & verification)

Archivo adjunto demasiado grande
El archivo adjunto supera el límite de 50 MB.

Fixed Issues

$ #3926

Tests / QA

1. Create a dummy file of size at least 50 MB (52428800 bytes).

• Windows: fsutil file createnew test50 52428800
• MacOS: mkfile -n test50 50m

2. Login to New Expensify.
3. Navigate to any user.
4. Press + in chat, then press Add Attachment.
5. Select the dummy file.
6. Verify that Attachment too large message is shown.
7. Similarly, verify that you can upload a file smaller than 50 MB.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

English

Spanish

Mobile Web

Desktop

iOS

Android

[rushatgabhane]

I went with this style because 3 out of 3 non-tech people agreed with it.
What do you think?

Current style

Alternative style

[shawnborton]

I agree, I like the current style you have.

[deetergp]

Had one minor style change. Otherwise looks good and tests well 👍

[deetergp]

LGTM!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.81-5🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[isagoico]

Issue found for this PR #4356

[OSBotify]

🚀 Deployed to production in version: 1.0.82-7🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[trjExpensify]

👋 blast from the past! Heads up as part of the new BugZero checklist. This PR caused a regression whereby the max file size was set to 50 MB, but the server only allows for 25 MB. One to look out for in the future. Thanks!

CC: @mountiny @Santhosh-Sellavel @Tushu17

[hoangzinh]

Hi team, because we don't have any recording videos so I'm not 100%, but coming from this issue #38478, it might be an issue that we haven't covered yet