[ESM] Localize system messages#43079
Conversation
deetergp
left a comment
deetergp
left a comment
There was a problem hiding this comment.
Overall looks pretty good to me. Thanks! I had a couple comments inline. Let's address those, get testing steps added, and complete the checklist.
| - React-Core | ||
| - ReactCommon/turbomodule/core | ||
| - RNReanimated (3.7.2): | ||
| - RNReanimated (3.8.1): |
There was a problem hiding this comment.
Did you explicitly need these changes? If not, let's not include these.
| CREATED: 'CREATED', | ||
| DELEGATE_SUBMIT: 'DELEGATESUBMIT', // OldDot Action | ||
| DELETED_ACCOUNT: 'DELETEDACCOUNT', // OldDot Action | ||
| DELETED_ACCOUNT: 'DELETEDACCOUNT', // Deprecated OldDot Action |
There was a problem hiding this comment.
Let's go ahead and just remove all the deprecated actions. They are blocked at the back end.
There was a problem hiding this comment.
Is sequenceNumber case covered as well? This temporary fallback has been there for over a year
// HACK ALERT: We're temporarily filtering out any reportActions keyed by sequenceNumber
// to prevent bugs during the migration from sequenceNumber -> reportActionID
if (String(reportAction.sequenceNumber) === key) {
Log.info('Front-end filtered out reportAction keyed by sequenceNumber!', false, reportAction);
return true;
}
There was a problem hiding this comment.
Let's leave that one be for now
src/libs/ReportUtils.ts
Outdated
| // /** | ||
| // * Detect and return a modified field name based on the original message. | ||
| // * | ||
| // * At the moment, we only allow changing one transaction field at a time. | ||
| // * @param originalMessage | ||
| // */ |
There was a problem hiding this comment.
| // /** | |
| // * Detect and return a modified field name based on the original message. | |
| // * | |
| // * At the moment, we only allow changing one transaction field at a time. | |
| // * @param originalMessage | |
| // */ | |
| /** | |
| * Detect and return a modified field name based on the original message. | |
| * | |
| * At the moment, we only allow changing one transaction field at a time. | |
| * @param originalMessage | |
| */ |
deetergp
left a comment
deetergp
left a comment
There was a problem hiding this comment.
I Meant to hit "Request changes" not "Approve."
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@BrtqKr You should be able to at least test the Export to CSV part of this by creating a collect workspace with two users, submitting an expense from one user to the other, approving the report in OldDot, and exporting it to CSV. |
|
There's one thing you'll need to fix in order for it to work: diff --git a/src/libs/ReportActionsUtils.ts b/src/libs/ReportActionsUtils.ts
index 204fec860a..a4de4c544d 100644
--- a/src/libs/ReportActionsUtils.ts
+++ b/src/libs/ReportActionsUtils.ts
@@ -192,6 +192,10 @@ function getWhisperedTo(reportAction: OnyxInputOrEntry<ReportAction>): number[]
const originalMessage = getOriginalMessage(reportAction);
const message = reportAction?.message;
+ if (originalMessage == '[]') {
+ return [];
+ }
+
if (!(originalMessage && 'whisperedTo' in originalMessage) && !(message && 'whisperedTo' in message)) {
return [];
} |
Screen.Recording.2024-06-24.at.10.21.56.AM.mov |
|
@parasharrajat just a heads up this is an important one to jump on reviewing ASAP for #wave-collect. Thanks! |
src/languages/en.ts
Outdated
| exportedToIntegration: ({label}: ExportedToIntegrationParams) => `exported this report to ${label}`, | ||
| forwarded: ({amount, currency}: ForwardedParams) => `approved ${currency}${amount}`, | ||
| // verify errorMessage | ||
| integrationsMessage: ({errorMessage}: IntegrationsMessageParams) => `failed to export this report to NetSuite. ${errorMessage}`, |
There was a problem hiding this comment.
Just checking but NetSuite here doesn't seem to be variable depending on what accounting solution is connected? I.e they could be exporting to Xero, not NetSuite, for example.
|
@trjExpensify I've added a template label as in @parasharrajat I've added a conditional case for that
@deetergp is it possible that Apart from that I believe this is everything from the things listed |
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
PR looks good to me. |
deetergp
left a comment
deetergp
left a comment
There was a problem hiding this comment.
PR Looks good to me too 👍
No, I don't think that is possible. |
deetergp
left a comment
deetergp
left a comment
There was a problem hiding this comment.
@BrtqKr The perf-tests are failing consistently due to FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory and I believe it is related to the changes in tests/utils/collections/reportActions.ts. We ran into a similar issue in an earlier PR and those changes are what resolved it. Can you undo those changes?
|
@deetergp I've merged main and reverted tests it seems to be passing the check |
deetergp
left a comment
deetergp
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the changes 👍
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.0.4-0 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀
|
| reimbursementACHCancelled: `canceled the payment`, | ||
| reimbursementAccountChanged: `couldn’t process the payment, as the payer changed bank accounts`, | ||
| reimbursementDelayed: `processed the payment but it’s delayed by 1-2 more business days`, | ||
| selectedForRandomAudit: `[randomly selected](https://help.expensify.com/articles/expensify-classic/reports/Set-a-random-report-audit-schedule) for review`, |
There was a problem hiding this comment.
For this olddot action, it shows a message in a plain text instead of converted markdown which caused the issue #45819
6 participants
Details
PR includes changes for updated handling and translating OldDot system messages.
Fixed Issues
$ #42923
PROPOSAL:
Tests
Some of the messages aren't available, but taking export to CSV action as an example:
Sign in to the NewDot using account A and create a workspace with account B
Submit expense
Sign in to the OldDot using account A
Go to reports
Mark a checkbox next to the report consisting of the submitted expense
Export to CSV
Go back to the NewDot, sign in to the account B
After a moment a system message from the account A
exported this report to CSVshould be visibleGo to the settings => preferences => langugage
Change english to spanish
go back to the report
verify that the message is correctly localized
Offline tests
Since this is just another variant of the action, there's nothing special in terms of offline testing - the message should be available when the device reconnects.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop