[No QA] Replace usages of useWindowDimensions with useResponsiveLayout hook in pages folder by rayane-d · Pull Request #43961 · Expensify/App

rayane-d · 2024-06-18T21:24:07Z

Details

Fixed Issues

Tests

Do general regression tests and focus on layouts; test all the app's most important features and verify there are no layout breaks.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Do general regression tests and focus on layouts; test all the app's most important features and verify there are no layout breaks.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-21.at.12.16.05.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-06-21.at.12.07.17.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-21.at.12.01.37.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-21.at.03.19.42.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-06-21.at.2.38.18.AM.mp4

MacOS: Desktop

Screen.Recording.2024-06-21.at.2.45.42.AM.mov

…h-useResponsiveLayout-in-pages-folder

melvin-bot · 2024-06-21T11:22:49Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-d · 2024-06-21T11:23:38Z

@getusha - PR ready for review

…h-useResponsiveLayout-in-pages-folder

getusha · 2024-06-27T15:44:17Z

I will start testing this today

getusha · 2024-07-01T11:53:01Z

Bug 1: No animation when the training modal shows

Press on the global +
Track expense

Screen.Recording.2024-07-01.at.2.50.21.in.the.afternoon.mov

Staging:

Screen.Recording.2024-07-01.at.2.51.41.in.the.afternoon.mov

getusha · 2024-07-01T11:59:21Z

Bug 2: Missing background overlay for AttachmentPickerWithMenuItems

…h-useResponsiveLayout-in-pages-folder

rayane-d · 2024-07-10T01:10:16Z

@getusha bugs 1 & 2 are not reproducible when we disable react strict mode, they will not be reproducible on production builds. When react strict mode is enabled all components render twice on dev.

rayane-d · 2024-07-18T23:10:57Z

Updated

cc @getusha

getusha · 2024-07-22T05:19:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-24.at.11.16.22.in.the.morning.mov

Android: mWeb Chrome

Screen.Recording.2024-07-24.at.10.48.18.in.the.morning.mov

iOS: Native

Screen.Recording.2024-07-24.at.11.29.10.in.the.morning.mov

iOS: mWeb Safari

Screen.Recording.2024-07-24.at.10.55.35.in.the.morning.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-22.at.7.51.54.in.the.morning.mov

MacOS: Desktop

Screen.Recording.2024-07-24.at.11.02.43.in.the.morning.mov

getusha · 2024-07-22T05:19:58Z

BUG: Emoji picker flickers on status page - not sure if this is related

Settings > Profile > Status

Screen.Recording.2024-07-22.at.8.18.52.in.the.morning.mov

rayane-d · 2024-07-22T13:01:53Z

BUG: Emoji picker flickers on status page - not sure if this is related

Settings > Profile > Status

Screen.Recording.2024-07-22.at.8.18.52.in.the.morning.mov

@getusha - Unable to reproduce. Are you able to reproduce this consistently?

Screen.Recording.2024-07-22.at.1.59.16.PM.mov

…h-useResponsiveLayout-in-pages-folder

getusha · 2024-07-24T08:33:19Z

@getusha - Unable to reproduce. Are you able to reproduce this consistently?

Was able to reproduce on staging probably an issue from my emulator.

getusha · 2024-07-24T08:33:47Z

@rayane-djouah Isn't it better to mark this as No QA since we don't have clear testing steps?

rayane-d · 2024-07-24T09:15:30Z

@rayane-djouah Isn't it better to mark this as No QA since we don't have clear testing steps?

Agree, done!

…h-useResponsiveLayout-in-pages-folder

rayane-d · 2024-07-24T20:32:11Z

Fixed the conflicts

melvin-bot · 2024-07-25T16:28:18Z

🎯 @getusha, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #46208.

roryabraham · 2024-07-25T18:25:08Z

@rayane-djouah fresh conflicts

…h-useResponsiveLayout-in-pages-folder

rayane-d · 2024-07-25T18:44:46Z

Updated

OSBotify · 2024-07-25T19:28:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-26T05:35:59Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-29T18:39:23Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.13-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

jayeshmangwani · 2025-11-26T05:51:15Z

src/pages/home/report/ReportFooter.tsx

                </View>
            )}
-            {!shouldHideComposer && (!!shouldShowComposeInput || !isSmallScreenWidth) && (
+            {!shouldHideComposer && (!!shouldShowComposeInput || !shouldUseNarrowLayout) && (


Coming from this issue #73444, it seems that changing isSmallScreenWidth to shouldUseNarrowLayout caused the compose box to disappear on the web for the report screen RHP.

rayane-d added 2 commits June 18, 2024 22:22

Replace usages of useWindowDimensions with useResponsiveLayout hook

81f0653

Merge branch 'main' into Replace-usages-of-is-useWindowDimensions-wit…

bca35cf

…h-useResponsiveLayout-in-pages-folder

This was referenced Jun 18, 2024

[HOLD for payment 2024-10-30] [$1000] Create a useResponsiveLayout hook #30528

Closed

[HOLD] Replace usages of is small screen widt from use window dimensions with should use narrow layout from use responsive layout in pages folder #36293

Closed

rayane-d added 5 commits June 18, 2024 22:34

replace useIsReportOpenInRHP with useResponsiveLayout

cbbb79a

Fix type error

38cc6b0

Fix type error

0f21ec8

Merge branch 'main' into Replace-usages-of-is-useWindowDimensions-wit…

9ad5d26

…h-useResponsiveLayout-in-pages-folder

Merge branch 'main' into Replace-usages-of-is-useWindowDimensions-wit…

62171c5

…h-useResponsiveLayout-in-pages-folder

rayane-d marked this pull request as ready for review June 21, 2024 11:22

rayane-d requested a review from a team as a code owner June 21, 2024 11:22

melvin-bot bot requested review from arosiclair and removed request for a team June 21, 2024 11:22

rayane-d changed the title ~~Replace usages of useWindowDimensions with useResponsiveLayout hook~~ Replace usages of useWindowDimensions with useResponsiveLayout hook in pages folder Jun 21, 2024

arosiclair requested review from getusha and removed request for arosiclair June 21, 2024 13:58

roryabraham self-requested a review June 23, 2024 07:10

rayane-d added 3 commits June 26, 2024 02:48

Merge branch 'main' into Replace-usages-of-is-useWindowDimensions-wit…

962dab5

…h-useResponsiveLayout-in-pages-folder

fix lint errors

54b1250

prettier

defc32a

rayane-d added 4 commits July 8, 2024 22:52

Merge branch 'main' into Replace-usages-of-is-useWindowDimensions-wit…

67e6c56

…h-useResponsiveLayout-in-pages-folder

Merge branch 'main' into Replace-usages-of-is-useWindowDimensions-wit…

3704ee1

…h-useResponsiveLayout-in-pages-folder

fix lint error

9c7df68

Merge branch 'main' into Replace-usages-of-is-useWindowDimensions-wit…

72bd5fa

…h-useResponsiveLayout-in-pages-folder

rayane-d added 2 commits July 22, 2024 14:02

Merge branch 'main' into Replace-usages-of-is-useWindowDimensions-wit…

db1635e

…h-useResponsiveLayout-in-pages-folder

Merge branch 'main' into Replace-usages-of-is-useWindowDimensions-wit…

c69339d

…h-useResponsiveLayout-in-pages-folder

rayane-d changed the title ~~Replace usages of useWindowDimensions with useResponsiveLayout hook in pages folder~~ [No QA] Replace usages of useWindowDimensions with useResponsiveLayout hook in pages folder Jul 24, 2024

Merge branch 'main' into Replace-usages-of-is-useWindowDimensions-wit…

030bc47

…h-useResponsiveLayout-in-pages-folder

fix type error after merging main

50657ea

getusha approved these changes Jul 25, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Jul 25, 2024

Payment issue for E/App PR#43961 #46208

Closed

rayane-d added 2 commits July 25, 2024 19:26

Merge branch 'main' into Replace-usages-of-is-useWindowDimensions-wit…

9590046

…h-useResponsiveLayout-in-pages-folder

Merge branch 'main' into Replace-usages-of-is-useWindowDimensions-wit…

c267426

…h-useResponsiveLayout-in-pages-folder

roryabraham approved these changes Jul 25, 2024

View reviewed changes

roryabraham merged commit 9d8f5d6 into Expensify:main Jul 25, 2024

rayane-d deleted the Replace-usages-of-is-useWindowDimensions-with-useResponsiveLayout-in-pages-folder branch July 25, 2024 19:29

github-actions bot mentioned this pull request Jul 26, 2024

Deploy Checklist: New Expensify 2024-07-26 #46264

Closed

48 tasks

nyomanjyotisa mentioned this pull request Jul 29, 2024

[Payment due Sept 6] [$250] Search - Expense page composer loses bottom margin when going offline #46404

Closed

6 tasks

huult mentioned this pull request Oct 29, 2025

[C+ Checklist Needs Completion] [$250] Chat - Compose box is disappearing when editing a message in the expense chat #73444

Closed

8 tasks

jayeshmangwani reviewed Nov 26, 2025

View reviewed changes

Conversation

rayane-d commented Jun 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 21, 2024

Uh oh!

rayane-d commented Jun 21, 2024

Uh oh!

getusha commented Jun 27, 2024

Uh oh!

getusha commented Jul 1, 2024

Uh oh!

getusha commented Jul 1, 2024

Uh oh!

rayane-d commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rayane-d commented Jul 18, 2024

Uh oh!

getusha commented Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

getusha commented Jul 22, 2024

Uh oh!

rayane-d commented Jul 22, 2024

Uh oh!

getusha commented Jul 24, 2024

Uh oh!

getusha commented Jul 24, 2024

Uh oh!

rayane-d commented Jul 24, 2024

Uh oh!

rayane-d commented Jul 24, 2024

Uh oh!

melvin-bot bot commented Jul 25, 2024

Uh oh!

roryabraham commented Jul 25, 2024

Uh oh!

rayane-d commented Jul 25, 2024

Uh oh!

OSBotify commented Jul 25, 2024

Uh oh!

OSBotify commented Jul 26, 2024

Uh oh!

OSBotify commented Jul 29, 2024

Uh oh!

jayeshmangwani Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rayane-d commented Jun 18, 2024 •

edited

Loading

rayane-d commented Jul 10, 2024 •

edited

Loading

getusha commented Jul 22, 2024 •

edited

Loading