fix: [Track tax] Disabled tax rate can be selected. by Krishna2323 · Pull Request #44046 · Expensify/App

Krishna2323 · 2024-06-19T21:16:02Z

Details

Fixed Issues

$ #43613
PROPOSAL: #43613 (comment)

Tests

Precondition:

Distance rates and Taxes are enabled
Track tax is enabled

Go to workspace settings > Taxes
Disable a tax rate
Go to Distance rates
Click on any distance rate > Tax rate
Verify disabled tax rate is not shown

Verify that no errors appear in the JS console

Offline tests

Precondition:

Distance rates and Taxes are enabled
Track tax is enabled

Go to workspace settings > Taxes
Disable a tax rate
Go to Distance rates
Click on any distance rate > Tax rate
Verify disabled tax rate is not shown

QA Steps

Precondition:

Distance rates and Taxes are enabled
Track tax is enabled

Go to workspace settings > Taxes
Disable a tax rate
Go to Distance rates
Click on any distance rate > Tax rate
Verify disabled tax rate is not shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native_2.mp4

iOS: mWeb Safari

ios_native.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-06-19T21:16:07Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-06-20T02:57:56Z

Is this ready? Can you please complete the checklist before marking it as ready 🤔

Krishna2323 · 2024-06-20T06:58:58Z

Recordings are left, I'm on it.

hungvu193 · 2024-06-20T08:54:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

internet issue.

iOS: Native

IOS.mov

iOS: mWeb Safari

mSafari.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Desktop.mov

hungvu193

LGTM

MonilBhavsar

Hmm, we agreed to update the TaxPicker component. Then why this changes?

MonilBhavsar · 2024-06-20T11:38:35Z

src/pages/workspace/distanceRates/PolicyDistanceRateTaxRateEditPage.tsx

+                        <HeaderWithBackButton
+                            title={translate('workspace.taxes.taxRate')}
+                            shouldShowBackButton


Does header needs to be wrapped in the function?

Since we used the insets, I believe we should do that.
We also did that in other places where we wanted to use insets ie BaseSidebarScreen or WorkspaceNewRoomPage

App/src/pages/home/sidebar/SidebarScreen/BaseSidebarScreen.tsx

Lines 40 to 46 in 633e708

{({insets}) => (

<>

<TopBar

breadcrumbLabel={translate('common.inbox')}

activeWorkspaceID={activeWorkspaceID}

/>

<View style={[styles.flex1]}>

Krishna2323 · 2024-06-21T07:26:29Z

Hmm, we agreed to update the TaxPicker component. Then why this changes?

WDYM? We agreed to use TaxPicker instead of SelectionList.

hungvu193 · 2024-06-24T02:39:43Z

Friendly bump @MonilBhavsar for your final review 😄

MonilBhavsar · 2024-06-26T05:44:09Z

Okay, i got it wrong. I was thinking that there's something wrong in TaxPicker and we'll be fixing it too 😄

OSBotify · 2024-07-03T19:39:15Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T10:57:50Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ishpaul777 · 2025-03-13T16:51:41Z

src/pages/workspace/distanceRates/PolicyDistanceRateTaxRateEditPage.tsx

    };

+    const dismiss = () => {
+        Navigation.goBack(ROUTES.WORKSPACE_TAXES_SETTINGS.getRoute(policyID));


This caused a regression #57233, we should navigate to WORKSPACE_DISTANCE_RATE_DETAILS page not WORKSPACE_TAXES_SETTINGS

fix: [Track tax] Disabled tax rate can be selected.

46c0a51

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner June 19, 2024 21:16

melvin-bot bot requested review from hungvu193 and removed request for a team June 19, 2024 21:16

Krishna2323 marked this pull request as draft June 20, 2024 05:04

Krishna2323 marked this pull request as ready for review June 20, 2024 08:32

hungvu193 approved these changes Jun 20, 2024

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar June 20, 2024 08:54

MonilBhavsar reviewed Jun 20, 2024

View reviewed changes

MonilBhavsar approved these changes Jun 26, 2024

View reviewed changes

MonilBhavsar merged commit 9862fdb into Expensify:main Jun 26, 2024

This was referenced Jun 26, 2024

Investigate workflow job failing on main: lint / Run ESLint #44425

Closed

Investigate workflow job failing on main: confirmPassingBuild #44426

Closed

Deploy Checklist: New Expensify 2024-06-27 #44575

Closed

stephanieelliott mentioned this pull request Jul 3, 2024

[HOLD for payment 2024-07-10] [$250] [Track tax] Disabled tax rate can be selected #43613

Closed

6 tasks

twilight2294 mentioned this pull request Feb 21, 2025

[Due for payment 2025-03-13] [$250] Track tax - RHP opens tax settings instead of distance rate after selecting the same tax rate #57233

Closed

8 tasks

ishpaul777 reviewed Mar 13, 2025

View reviewed changes

	{({insets}) => (
	<>
	<TopBar
	breadcrumbLabel={translate('common.inbox')}
	activeWorkspaceID={activeWorkspaceID}
	/>
	<View style={[styles.flex1]}>

Conversation

Krishna2323 commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 19, 2024

Uh oh!

hungvu193 commented Jun 20, 2024

Uh oh!

Krishna2323 commented Jun 20, 2024

Uh oh!

hungvu193 commented Jun 20, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar Jun 20, 2024

Choose a reason for hiding this comment

Uh oh!

hungvu193 Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Jun 21, 2024

Uh oh!

hungvu193 commented Jun 24, 2024

Uh oh!

MonilBhavsar commented Jun 26, 2024

Uh oh!

OSBotify commented Jul 3, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

ishpaul777 Mar 13, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Krishna2323 commented Jun 19, 2024 •

edited

Loading

hungvu193 Jun 21, 2024 •

edited

Loading