One-expense-report old chat messages stays in chat by rinej · Pull Request #44529 · Expensify/App

rinej · 2024-06-27T09:59:04Z

Details

Problem
When opening one transaction report there is weird UI flickering bug, and it appears to load slow

Solution
The first was that the MoneyReportView was being displayed even when there were no transactions in the current state (optimistic approach). This led to the view covering the screen unnecessarily, and once the transactions were fetched, it disappeared, causing a flickering effect. To address this, I adjusted the logic to ensure that the MoneyReportView is only displayed when there are transactions to show.

The second issue was with the IOU message action in the one-view transaction screen. By default, the IOU action was displayed, even though it was not supposed to be shown. It would only be removed after several re-renders, which caused the flickering effect. To fix this, I implemented filtering logic to remove the IOU action before the view is rendered.

Video before fix on Main:

BAD.ON.MAIN.mp4

After the fix:

Fixed.One.mp4

Fixed Issues

$ #44162
PROPOSAL:

Tests

Offline tests

QA Steps

Create new Workspace with user A
Invite another member to it - user B
Go to the Workspace settings
More Features
Enable Workflows
Setup approvals
Set user A as the Approver on the workspace
Log out
Sign in as B
Submit expense in the created workspace
Sign in as A and navigate to the chat with B and open the expense report
Go back to the action
Open another expense report
See that report loads without flickering (no previous report action is seen)

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-06-27T10:38:51Z

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…n-chat

github-actions · 2024-06-28T16:42:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/44529/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/44529/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/44529/NewExpensify.dmg	https://44529.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

puneetlath · 2024-07-01T14:08:44Z

Ok nice. I tried it out in my account and it seems to work quite well. Here's a video.

Screen.Recording.2024-06-28.at.2.01.41.PM.mov

mkhutornyi · 2024-07-01T18:59:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web1.mov

web2.mov

MacOS: Desktop

rinej · 2024-07-02T10:16:36Z

@puneetlath thats great! Thank you for verifying ❤️

@mkhutornyi are you able to proceed with the review?

mkhutornyi · 2024-07-03T20:45:29Z

@rinej please add Tests / QA Steps

mkhutornyi · 2024-07-03T21:10:16Z

src/pages/home/report/ReportActionsView.tsx

        }

-        return [...actions, createdAction];
+        return moneyRequestActions.length === 1 ? ReportActionsUtils.getFilteredForOneTransactionView([...actions, createdAction]) : [...actions, createdAction];


NAB: Please add comment what moneyRequestActions.length === 1 means

mkhutornyi · 2024-07-03T21:11:19Z

src/libs/ReportActionsUtils.ts

 }

+/**
+ * Returns filtered list for one transaction view


NAB: Please explain what is filtered exactly.

rinej · 2024-07-04T13:13:31Z

Thank you @mkhutornyi for review, I added requested comments and QA steps

OSBotify · 2024-07-07T23:07:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-08T09:57:46Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.5-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-08T10:54:09Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.5-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:03:17Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:21:56Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2024-08-08T05:35:16Z

src/libs/ReportActionsUtils.ts

+function getFilteredForOneTransactionView(reportActions: ReportAction[]): ReportAction[] {
+    return reportActions.filter((action) => !isSentMoneyReportAction(action));
+}


This caused an issue where paid system message was not showing #45203

rinej added 2 commits June 27, 2024 11:56

fix: remove flickering effect when loading one-expense reports

11788a8

fix lint, cleanup

2f37c40

rinej marked this pull request as ready for review June 27, 2024 10:38

rinej requested a review from a team as a code owner June 27, 2024 10:38

melvin-bot bot requested review from mkhutornyi and removed request for a team June 27, 2024 10:38

rinej mentioned this pull request Jun 27, 2024

[HOLD for payment 2024-07-22] [Performance] Slow load of one-transaction reports #44162

Closed

rinej added 2 commits June 28, 2024 11:26

Merge branch 'main' into One-expense-report-old-chat-messages-stays-i…

6fa095c

…n-chat

adjust to new changes from main

bcca27b

puneetlath added the Ready To Build label Jun 28, 2024

mkhutornyi reviewed Jul 3, 2024

View reviewed changes

mkhutornyi approved these changes Jul 4, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath July 4, 2024 05:19

add comments

580243d

puneetlath approved these changes Jul 7, 2024

View reviewed changes

puneetlath merged commit b0947e0 into Expensify:main Jul 7, 2024

github-actions bot mentioned this pull request Jul 8, 2024

Deploy Checklist: New Expensify 2024-07-08 #44947

Closed

86 tasks

carlosmiceli mentioned this pull request Jul 8, 2024

[$250 BLOCKED BY #44388] Send invoice - Invoice report appears broken #44992

Closed

6 tasks

mkhutornyi mentioned this pull request Jul 24, 2024

Add One Transaction Report View #36934

Merged

50 tasks

parasharrajat reviewed Aug 8, 2024

View reviewed changes

parasharrajat mentioned this pull request Aug 8, 2024

[HOLD for payment 2024-08-14] [$250] Pay someone - Missing paid system message for paying someone #45203

Closed

6 tasks

Conversation

rinej commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 27, 2024

Uh oh!

github-actions bot commented Jun 28, 2024

Uh oh!

puneetlath commented Jul 1, 2024

Uh oh!

mkhutornyi commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rinej commented Jul 2, 2024

Uh oh!

mkhutornyi commented Jul 3, 2024

Uh oh!

mkhutornyi Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkhutornyi Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rinej commented Jul 4, 2024

Uh oh!

OSBotify commented Jul 7, 2024

Uh oh!

OSBotify commented Jul 8, 2024

Uh oh!

OSBotify commented Jul 8, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

parasharrajat Aug 8, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rinej commented Jun 27, 2024 •

edited

Loading

mkhutornyi commented Jul 1, 2024 •

edited

Loading

mkhutornyi Jul 3, 2024 •

edited

Loading

mkhutornyi Jul 3, 2024 •

edited

Loading