Sage intacct export: offline and error by war-in · Pull Request #44739 · Expensify/App

war-in · 2024-07-02T16:45:16Z

Details

Fixed Issues

$ #43534 - followup
PROPOSAL:

Tests

Add onyx errors for all possible fields

Onyx.merge('policy_570EBAEF494D3C0A', {connections: {intacct: {config: {errorFields: {exporter: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, exportDate: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, nonReimbursable: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, nonReimbursableAccount: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, nonReimbursableCreditCardChargeDefaultVendor: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, nonReimbursableVendor: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, reimbursable: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, reimbursableExpenseReportDefaultVendor: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}}}}}});

Go through each tab and check if error (red dot in menu item or message) is displayed.

Offline tests

Force offline
Go through each tab in Sage Intacct -> Export and change value.
Verify that each changed field has opacity 0.5 (is shown as an offline change).

QA Steps

Add onyx errors for all possible fields

Onyx.merge('policy_570EBAEF494D3C0A', {connections: {intacct: {config: {errorFields: {exporter: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, exportDate: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, nonReimbursable: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, nonReimbursableAccount: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, nonReimbursableCreditCardChargeDefaultVendor: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, nonReimbursableVendor: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, reimbursable: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, reimbursableExpenseReportDefaultVendor: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}}}}}});

Go through each tab and check if error (red dot in menu item or message) is displayed.

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-04.at.13.58.59.mov

Screen.Recording.2024-07-04.at.13.59.57.mov

Android: mWeb Chrome

Screen.Recording.2024-07-04.at.14.02.16.mov

Screen.Recording.2024-07-04.at.14.03.19.mov

iOS: Native

Screen.Recording.2024-07-04.at.13.36.54.mov

Screen.Recording.July.4.mov

iOS: mWeb Safari

Screen.Recording.2024-07-04.at.13.40.40.mov

Screen.Recording.2024-07-04.at.13.42.16.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-04.at.12.28.50.mov

Screen.Recording.2024-07-04.at.12.35.40.mov

MacOS: Desktop

Screen.Recording.2024-07-04.at.13.04.32.mov

Screen.Recording.2024-07-04.at.13.05.57.mov

war-in · 2024-07-02T16:46:34Z

Please note that this PR should be merged after #43776

war-in · 2024-07-02T16:48:15Z

@yuwenmemon @hungvu193 What do you think about such an errors?
I've added some details in this thread.
Maybe someone from the design team should look on it?

…-offline-error # Conflicts: # src/libs/API/types.ts # src/pages/workspace/accounting/PolicyAccountingPage.tsx

…in/sage-intacct-export-config-offline-error # Conflicts: # src/pages/workspace/accounting/intacct/export/SageIntacctNonReimbursableExpensesPage.tsx # src/pages/workspace/accounting/intacct/export/SageIntacctReimbursableExpensesPage.tsx

war-in · 2024-07-04T10:01:05Z

@hungvu193 I think offline state and errors are ready to be reviewed. Here is true diff between this and main export branch.

I'm going to record some videos and think of test steps now. Review would be appreciated 🙏

melvin-bot · 2024-07-04T10:01:25Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

war-in · 2024-07-04T10:37:47Z

You can check how it looks like on the web in the description (other recordings are coming soon 🔜 )

hungvu193 · 2024-07-04T11:19:54Z

@hungvu193 I think offline state and errors are ready to be reviewed. Here is true diff between this and main export branch.

I'm going to record some videos and think of test steps now. Review would be appreciated 🙏

Thank you. That's really helpful 🙏

war-in · 2024-07-04T12:04:59Z

All videos are there :)

src/languages/en.ts

src/pages/workspace/accounting/intacct/export/SageIntacctNonReimbursableExpensesPage.tsx

src/libs/actions/connections/SageIntacct.ts

src/libs/actions/Policy/Policy.ts

…in/sage-intacct-export-config-offline-error # Conflicts: # src/pages/workspace/accounting/intacct/export/SageIntacctNonReimbursableExpensesPage.tsx

…in/sage-intacct-export-config-offline-error

hungvu193 · 2024-07-05T15:05:50Z

I will review this weekend

…in/sage-intacct-export-config-offline-error

hungvu193 · 2024-07-09T06:49:08Z

I reviewed software-mansion-labs#92, I think it's looking good. I think we should wait for #43776 to be merged then I will test again 😄

…in/sage-intacct-export-config-offline-error

hungvu193 · 2024-07-11T11:08:19Z

Text color of selected option is changed in SageIntacctNonReimbursableExpensesPage.
How about this one @war-in 😄 ?

@hungvu193 I think it's also connected to the SelectionList focus. You can check that if you go to non-reimbursable page and choose other option its text gets gray. But if you click outside of the SelectionList it goes back to white. Do you think we should fix it here or I should write about it in yours issue? (please link the issue 🙏)

Here's the issue btw:
#44872

If it doesn't take time then we can fix it here, otherwise we should fix it in the issue I mentioned.

war-in · 2024-07-11T11:19:40Z

@hungvu193 I read through the issue and I'm not sure if it covers the same thing 🤔
In our case we want to change focus by clicking on the list row (and highlight it). Previously, we haven't had such a case because single-selection lists were always closed after selection.

Can you confirm that mentioned issue will fix it? If not we can try fixing it here

hungvu193 · 2024-07-11T11:21:54Z

@war-in My bad, the mentioned issue is about the highlight item.
So I think we should fix it here

war-in · 2024-07-11T11:24:39Z

Sure! So it'll take some time reading through focus-related stuff in SelectionList (and finding the fix). Do we want to wait for that in this PR or should we create another one and merge this?

hungvu193 · 2024-07-11T11:26:24Z

Sure! So it'll take some time reading through focus-related stuff in SelectionList (and finding the fix). Do we want to wait for that in this PR or should we create another one and merge this?

I think we can address it in a follow-up or polish PR. Let's keep this one moving forward! 😄

war-in · 2024-07-11T11:27:11Z

I think we can address it in a follow-up or polish PR. Let's keep this one moving forward! 😄

Nice! So it should be ready for final review now :)

war-in · 2024-07-11T11:59:18Z

@hungvu193 I found a solution for this not highlighting issue but it seems like a workaround for me. I think I need your opinion on this.

In the BaseSelectionList component we have renderItem function which is responsible for rendering each list item. There is also setFocusedIndex function which sets focus on provided item by the index.

Solution: I can modify the onSelectRow prop of the ListItem component and use setFocusedIndex here (behind some flag).

Flag solution will work but it requires adding another prop to the BaseSelectionListProps 😢

please share your thoughts 🙏 If it's acceptable the fix will be quick

hungvu193 · 2024-07-11T13:21:31Z

I'm afk now so I can't test it but I'm bot sure if it can fix this comment so we can skip it for now.

war-in · 2024-07-11T13:27:07Z

@hungvu193 Are you sure the linked comment is correct? It's from another issue 🤔

hungvu193 · 2024-07-11T13:34:56Z

Yes. I think if we try to modify the SelectionList to fix highlight issues, we probably need to fix the comment I mentioned too.
If we only update onSelectRow, I don't think it will resolve my comment. That feels like a workaround. I think there will be something to do with our highlight/focus logic when selections are changed.

war-in · 2024-07-11T14:24:48Z

@hungvu193 FYI, this is my investigation on 2. Text color...

#45213 (comment)

…-offline-error

hungvu193 · 2024-07-11T15:58:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-11.at.23.02.53.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-07-11.at.22.52.51.mov

iOS: mWeb Safari

Safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-11.at.21.33.31.mov

MacOS: Desktop

Screen.Recording.2024-07-11.at.21.32.50.mov

hungvu193

LGTM 🚀

hungvu193 · 2024-07-15T15:32:03Z

@war-in Can you please resolve the conflicts? Thank you 😄

…-offline-error # Conflicts: # src/libs/actions/Policy/Policy.ts # src/pages/workspace/accounting/intacct/export/SageIntacctExportPage.tsx

yuwenmemon · 2024-07-15T16:19:21Z

Thanks!

OSBotify · 2024-07-15T16:29:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-15T21:04:56Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T22:13:40Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-17T00:20:04Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-18T13:50:26Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

war-in added 2 commits July 2, 2024 18:34

update SelectionScreen and add Offline with feedback to components

7a0ba43

add offline with feedback to remaining pages

9088361

hungvu193 mentioned this pull request Jul 3, 2024

[HOLD for payment 2024-07-24] [#Wave-Control - Add Sage Intacct] Settings Configuration in NewDot: Export #43534

Closed

war-in added 6 commits July 3, 2024 16:10

show errors in correct places

91c62d9

style selection screen correctly

95da618

move error and pending fields up in onyx data

c420893

handle offline state

42f683c

Merge branch 'refs/heads/main' into war-in/sage-intacct-export-config…

d2c8472

…-offline-error # Conflicts: # src/libs/API/types.ts # src/pages/workspace/accounting/PolicyAccountingPage.tsx

war-in marked this pull request as ready for review July 4, 2024 10:01

war-in requested a review from a team as a code owner July 4, 2024 10:01

melvin-bot bot requested review from hungvu193 and removed request for a team July 4, 2024 10:01

track errors in (non)reimbursable in main page

80cc058

SzymczakJ reviewed Jul 4, 2024

View reviewed changes

war-in added 4 commits July 4, 2024 15:45

Merge branch 'refs/heads/war-in/sage-intacct-export-config' into war-…

968970a

…in/sage-intacct-export-config-offline-error # Conflicts: # src/pages/workspace/accounting/intacct/export/SageIntacctNonReimbursableExpensesPage.tsx

address comments

c836521

use already defined type

59c0fa8

Merge branch 'refs/heads/war-in/sage-intacct-export-config' into war-…

76b2328

…in/sage-intacct-export-config-offline-error

Merge branch 'refs/heads/war-in/sage-intacct-export-config' into war-…

32d879f

…in/sage-intacct-export-config-offline-error

Merge branch 'refs/heads/war-in/sage-intacct-export-config' into war-…

847706e

…in/sage-intacct-export-config-offline-error

hungvu193 mentioned this pull request Jul 11, 2024

[$250] [#Wave-Control - Add Sage Intacct] Non-reimbursable options text turns gray when clicked #45213

Closed

6 tasks

war-in added 2 commits July 11, 2024 16:50

Merge branch 'refs/heads/main' into war-in/sage-intacct-export-config…

51fe9f1

…-offline-error

fix selection list padding bottom in (non)reimbursable pages

4285951

hungvu193 approved these changes Jul 11, 2024

View reviewed changes

melvin-bot bot requested a review from yuwenmemon July 11, 2024 16:00

yuwenmemon mentioned this pull request Jul 15, 2024

[HOLD for payment 2024-09-17] [$250] Add Offline and Error Patterns to Remaining Integrations #45406

Closed

Merge branch 'refs/heads/main' into war-in/sage-intacct-export-config…

fcb95f9

…-offline-error # Conflicts: # src/libs/actions/Policy/Policy.ts # src/pages/workspace/accounting/intacct/export/SageIntacctExportPage.tsx

yuwenmemon approved these changes Jul 15, 2024

View reviewed changes

yuwenmemon merged commit 99bdad9 into Expensify:main Jul 15, 2024

github-actions bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-15 #45421

Closed

war-in deleted the war-in/sage-intacct-export-config-offline-error branch April 11, 2025 11:28

Conversation

war-in commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

war-in commented Jul 2, 2024

Uh oh!

war-in commented Jul 2, 2024

Uh oh!

war-in commented Jul 4, 2024

Uh oh!

melvin-bot bot commented Jul 4, 2024

Uh oh!

war-in commented Jul 4, 2024

Uh oh!

hungvu193 commented Jul 4, 2024

Uh oh!

war-in commented Jul 4, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hungvu193 commented Jul 5, 2024

Uh oh!

hungvu193 commented Jul 9, 2024

Uh oh!

hungvu193 commented Jul 11, 2024

Uh oh!

war-in commented Jul 11, 2024

Uh oh!

hungvu193 commented Jul 11, 2024

Uh oh!

war-in commented Jul 11, 2024

Uh oh!

hungvu193 commented Jul 11, 2024

Uh oh!

war-in commented Jul 11, 2024

Uh oh!

war-in commented Jul 11, 2024

Uh oh!

hungvu193 commented Jul 11, 2024

Uh oh!

war-in commented Jul 11, 2024

Uh oh!

hungvu193 commented Jul 11, 2024

Uh oh!

war-in commented Jul 11, 2024

Uh oh!

hungvu193 commented Jul 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Jul 15, 2024

Uh oh!

yuwenmemon commented Jul 15, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

OSBotify commented Jul 17, 2024

Uh oh!

OSBotify commented Jul 18, 2024

Uh oh!

Reviewers

Assignees

war-in commented Jul 2, 2024 •

edited

Loading

hungvu193 commented Jul 11, 2024 •

edited

Loading