[#Wave-Control: Add NetSuite] Reuse Existing Connection for NetSuite and Sage Intacct by mananjadhav · Pull Request #45375 · Expensify/App

mananjadhav · 2024-07-13T20:39:27Z

Details

Covers the implementation of Reusing an Existing Connection.
It loads a policy, copies over the requested connection into the new policy, and then saves the new policy.

Prerequisite

Collect workspace with accounting enabled.
NetSuite beta enabled for the user. You can return true in the canUseNetSuiteIntegration method.
Have NetSuite connected on another workspace.

Fixed Issues

$ #45349
PROPOSAL:

Tests

Open the app.
Have a workspace with NetSuite connected.
Take another workspace not connected to Accounting.
Go to Accounting from the LHS
Verify that you're able to see Net Suite in the available connections along with the Oracle NetSuite logo.
Click on the Connect button.
You should see two options: Create new connection and Reuse existing connection.
Clicking create new connection and verify that the token input steps work as expected.
Disconnect from the policy and repeat Connect with Reuse existing connection.
You should see a list of workspaces already connected to NetSuite with the last successful sync date.
Click on any of the policies, and verify that you're connected to NetSuite.

Verify that no errors appear in the JS console

Offline tests

Same as Test Steps

QA Steps

Same as Test Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-reuse-netsuite-connection.mov

Android: mWeb Chrome

mweb-chrome-reuse-netsuite-connection.mov

iOS: Native

ios-reuse-netsuite-connection.mov

iOS: mWeb Safari

mweb-safari-reuse-netsuite-connection.mov

MacOS: Chrome / Safari

web-reuse-netsuite-connection.mov

MacOS: Desktop

desktop-reuse-netsuite-connection.mov

melvin-bot · 2024-07-13T22:00:29Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2024-07-13T22:00:49Z

@parasharrajat Please ignore this PR.

@shubham1206agra @yuwenmemon For your review.

yuwenmemon

@mananjadhav Please remove the Intacct portions we'll be adding them in #44850

…use-connection

mananjadhav · 2024-07-16T10:43:46Z

@mananjadhav Please remove the Intacct portions we'll be adding them in #44850

@yuwenmemon I merged with main that included Intacct code. I still retained the pieces from this PR that refactored the methods.

yuwenmemon

LGTM!

yuwenmemon · 2024-07-16T17:33:12Z

src/libs/API/parameters/CopyExistingPolicyConnectionParams.ts

    policyID: string;
    targetPolicyID: string;
-    connectionName: string;
+    connectionName: ConnectionName;


yuwenmemon · 2024-07-16T17:34:30Z

src/libs/actions/Policy/Policy.ts

+function getAdminPoliciesConnectedToNetSuite(): Policy[] {
+    return Object.values(allPolicies ?? {}).filter<Policy>((policy): policy is Policy => !!policy && policy.role === CONST.POLICY.ROLE.ADMIN && !!policy?.connections?.netsuite);
+}


NAB: Instead of a method for each integration we could do getAdminPoliciesConnectedToIntegration and allow for a ConnectionName to be passed in.

I thought so. Will try to take care of it in any future PR.

yuwenmemon · 2024-07-16T17:36:02Z

src/libs/actions/connections/index.ts

+    );
+}
+
+export {removePolicyConnection, updatePolicyConnectionConfig, updateManyPolicyConnectionConfigs, hasSynchronizationError, syncConnection, copyExistingPolicyConnection};


NAB: time to put these on individual lines I'd say

I did and the prettier put this back in one line.

yuwenmemon · 2024-07-16T17:36:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-07-16T17:49:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-17T02:09:50Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.8-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-17T15:50:10Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.0.8-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-18T13:55:11Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-19T19:37:28Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.9-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mananjadhav added 9 commits July 14, 2024 00:04

refactor: move lang to common

34c1417

feat: added reuse connection options nesuite

fdb4d71

feat: route and nav setup

0ed5def

feat: copy intacct existing page to netsuite

42ef683

refactor: fix netsuite connections

70636fb

feat: added api

f639c6b

feat: integrate api call

26332b1

fix: add ref

c1e4a59

fix: added api call

03a3bb9

mananjadhav changed the title ~~Mj netsuite reuse connection~~ [#Wave-Control: Add NetSuite] Reuse Existing Connection for NetSuite and Sage Intacct Jul 13, 2024

mananjadhav added 2 commits July 14, 2024 02:46

refactor: rename copy refactor api

4be452d

refactor: use connection layout

5853fce

mananjadhav marked this pull request as ready for review July 13, 2024 22:00

mananjadhav requested a review from a team as a code owner July 13, 2024 22:00

melvin-bot bot requested review from parasharrajat and removed request for a team July 13, 2024 22:00

yuwenmemon requested changes Jul 15, 2024

View reviewed changes

mananjadhav added 4 commits July 16, 2024 12:55

refactor: remove intacct code

609e1b9

Merge branch 'main' of github.com:mananjadhav/App into mj-netsuite-re…

670823e

…use-connection

feat: code clean up

c3b1ff2

refactor: rename method and add admin check

46d367d

mananjadhav requested a review from yuwenmemon July 16, 2024 10:41

fix: connection name

95ab3d5

yuwenmemon approved these changes Jul 16, 2024

View reviewed changes

yuwenmemon merged commit 3f76344 into Expensify:main Jul 16, 2024

github-actions bot mentioned this pull request Jul 17, 2024

Deploy Checklist: New Expensify 2024-07-17 #45538

Closed

48 tasks

kosmydel mentioned this pull request Jul 17, 2024

[QBO Export] feat: handling auto-sync errors #45251

Merged

50 tasks

lanitochka17 mentioned this pull request Jul 17, 2024

Netsuite - Stuck in 'Initializing connection to NetSuite' when Reuse existing connection #45610

Closed

6 tasks

melvin-bot bot mentioned this pull request Jul 18, 2024

[HOLD for payment 2024-07-25] Add support for "Reuse existing connection" flow for NetSuite #45349

Closed

Conversation

mananjadhav commented Jul 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 13, 2024

Uh oh!

mananjadhav commented Jul 13, 2024

Uh oh!

yuwenmemon left a comment

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Jul 16, 2024

Uh oh!

yuwenmemon left a comment

Choose a reason for hiding this comment

Uh oh!

yuwenmemon Jul 16, 2024

Choose a reason for hiding this comment

Uh oh!

yuwenmemon Jul 16, 2024

Choose a reason for hiding this comment

Uh oh!

mananjadhav Jul 16, 2024

Choose a reason for hiding this comment

Uh oh!

yuwenmemon Jul 16, 2024

Choose a reason for hiding this comment

Uh oh!

mananjadhav Jul 16, 2024

Choose a reason for hiding this comment

Uh oh!

yuwenmemon commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Jul 16, 2024

Uh oh!

OSBotify commented Jul 17, 2024

Uh oh!

OSBotify commented Jul 17, 2024

Uh oh!

OSBotify commented Jul 18, 2024

Uh oh!

OSBotify commented Jul 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mananjadhav commented Jul 13, 2024 •

edited

Loading

yuwenmemon commented Jul 16, 2024 •

edited

Loading