Sage Intacct connection follow-up by SzymczakJ · Pull Request #44850 · Expensify/App

SzymczakJ · 2024-07-04T16:07:05Z

Details

This PR adds Entity page to Sage Intacct integration, reuse other integration connected to Sage intacct and fixes add user defined dimension feature in Sage Intacct Import

Fixed Issues

$ #44669
PROPOSAL: N/A

Tests

With policy connected to Sage Intacct.
Go on accounting page and try changing entity. Verify that it works and looks like this

3. Create new workspace and try reusing other integration to connect to Sage Intacct.

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

androidweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

iosweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-07-09T10:38:18Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-07-09T11:27:41Z

I'll review today

hungvu193 · 2024-07-09T16:35:46Z

src/pages/workspace/accounting/intacct/SageIntacctEntityPage.tsx

+    };
+
+    return (
+        <ConnectionLayout // switch to selection screen when https://github.com/Expensify/App/pull/44739 is merged


Let's hold this PR for #44739. I'll prioritize reviewing it 😄

hungvu193 · 2024-07-12T08:40:34Z

src/pages/workspace/accounting/intacct/SageIntacctEntityPage.tsx

+            return;
+        }
+
+        updateSageIntacctEntity(policyID, text ?? '');


We updated the entity as text here but we're using entity id to check the selected option, it will cause this bug:

Screen.Recording.2024-07-12.at.15.40.16.mov

hungvu193 · 2024-07-12T11:18:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-07-12.at.18.19.30.mov

iOS: Native

Screen.Recording.2024-07-12.at.18.29.27.mov

iOS: mWeb Safari

Screen.Recording.2024-07-12.at.18.37.06.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-12.at.18.15.23.mov

MacOS: Desktop

Screen.Recording.2024-07-12.at.18.10.49.mov

hungvu193

Codes look good. I think we should merge this PR and test again after we have some BE updates.

hungvu193

Small changes need after last update

hungvu193 · 2024-07-12T11:34:09Z

src/pages/workspace/accounting/intacct/advanced/SageIntacctAdvancedPage.tsx

            displayName={SageIntacctAdvancedPage.displayName}
            headerTitle="workspace.accounting.advanced"
-            headerSubtitle={currentSageIntacctOrganizationName}
+            headerSubtitle={entity}


This entity value now became entity_id after last update, can you update it to entity name please?

yuwenmemon · 2024-07-12T15:50:36Z

The fix for the loading spinner works with this branch btw:

Kapture.2024-07-12.at.11.32.08.mp4

SzymczakJ · 2024-07-15T08:42:12Z

fixed your comments @hungvu193!

OSBotify · 2024-07-15T15:32:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-15T21:05:26Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.7-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T22:14:10Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 9.0.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

lanitochka17 · 2024-07-16T19:24:59Z

This PR is failing because of issue #45514

Bug6543979_1721137204561.2024-07-16_16_27_26.mp4

OSBotify · 2024-07-17T00:20:46Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-18T13:50:57Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.8-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

add EntityScreen

1e6de2a

SzymczakJ mentioned this pull request Jul 5, 2024

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [#Wave-Control - Add Sage Intacct] Add the Connection option and Connection button in NewDot #43532

Closed

SzymczakJ added 6 commits July 5, 2024 11:37

add sync Sage Intacct connection

241bd1d

fix navigation bugs

e7132c7

refactor PolicyAccountingPage

d2846be

Merge branch 'main' into @szymczak/sage-intacct-connect-follow-up

9658d71

Merge branch 'main' into @szymczak/sage-intacct-connect-follow-up

97f85de

fix lint errors

25ce6cb

SzymczakJ marked this pull request as ready for review July 9, 2024 10:38

SzymczakJ requested a review from a team as a code owner July 9, 2024 10:38

melvin-bot bot removed the request for review from a team July 9, 2024 10:38

melvin-bot bot requested a review from hungvu193 July 9, 2024 10:38

hungvu193 reviewed Jul 9, 2024

View reviewed changes

SzymczakJ added 4 commits July 10, 2024 11:29

Merge branch 'main' into @szymczak/sage-intacct-connect-follow-up

4d3bcc7

add entity to headerSubtitle

b052438

fix UpdateSageIntacctUserDimension API calls

abb0495

add reusing existing integration

e956dcf

hungvu193 reviewed Jul 12, 2024

View reviewed changes

fix PR comments

2e198ad

hungvu193 approved these changes Jul 12, 2024

View reviewed changes

melvin-bot bot requested a review from yuwenmemon July 12, 2024 11:19

hungvu193 suggested changes Jul 12, 2024

View reviewed changes

SzymczakJ added 2 commits July 15, 2024 10:24

fix pr comments

614e0e3

Merge branch 'main' into @szymczak/sage-intacct-connect-follow-up

f2c6bb5

yuwenmemon mentioned this pull request Jul 15, 2024

[#Wave-Control: Add NetSuite] Reuse Existing Connection for NetSuite and Sage Intacct #45375

Merged

50 tasks

yuwenmemon approved these changes Jul 15, 2024

View reviewed changes

yuwenmemon merged commit ed7f515 into Expensify:main Jul 15, 2024

github-actions bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-15 #45421

Closed

SzymczakJ mentioned this pull request Jul 16, 2024

Sage Intacct - Back button on workspace editor returns to Accounting page again #44813

Closed

6 tasks

melvin-bot bot mentioned this pull request Jul 17, 2024

[#Wave-Control - Add Sage Intacct] Add connection sync progress and error handling. #44669

Closed

SzymczakJ deleted the @szymczak/sage-intacct-connect-follow-up branch April 8, 2025 09:10

Conversation

SzymczakJ commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 9, 2024

Uh oh!

hungvu193 commented Jul 9, 2024

Uh oh!

hungvu193 Jul 9, 2024

Choose a reason for hiding this comment

Uh oh!

hungvu193 Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 Jul 12, 2024

Choose a reason for hiding this comment

Uh oh!

yuwenmemon commented Jul 12, 2024

Uh oh!

SzymczakJ commented Jul 15, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

OSBotify commented Jul 15, 2024

Uh oh!

lanitochka17 commented Jul 16, 2024

Uh oh!

OSBotify commented Jul 17, 2024

Uh oh!

OSBotify commented Jul 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SzymczakJ commented Jul 4, 2024 •

edited

Loading

hungvu193 commented Jul 12, 2024 •

edited

Loading