Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
parasharrajat
left a comment
There was a problem hiding this comment.
@jp928 Please resolve conflicts. Add test videos for all platforms. Do not modify the template.
Fix these to use the default template. You can find other PRs to see how they look like.
|
@parasharrajat I think my fix is included in #45556 already. |
|
@jp928 Ok, no problem. we are good here then. |
|
@parasharrajat is this issue still count to me? |
|
@jp928 I didn't understand your question. If you are asking whether you will be paid for the linked issue or not. Then yes, you will be paid. |
|
@parasharrajat Sry for making you condused. I am asking if the payment still goes to me? |
|
Ok. Yeah, you will be paid. let's keep this PR open until that is confirmed on the issue. |
|
@jp928 We can close this pr. |
|
@jp928 Please close this PR. |
|
Close because the fix has been merged by another PR. |
Details
Fixed Issues
$ #44032
PROPOSAL: $ #44032 (comment)
Tests
Offline tests
QA Steps
_ahead of a asterisk e.g._*bold*sendboldPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2024-07-19.at.12.29.41.AM.mov
MacOS: Desktop