Fixing comment edits when cursor is in the middle #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiragsalian
changed the title
Contributor
Author
|
Ready for review. |
marcaaron
requested changes
Sep 11, 2020
chiragsalian
changed the title
Contributor
Author
|
Updated code and tested on web and ios. Ready for review 👍 |
chiragsalian
changed the title
AndrewGable
previously approved these changes
Sep 11, 2020
Contributor
AndrewGable
left a comment
AndrewGable
left a comment
There was a problem hiding this comment.
Looks good and tests well!
marcaaron
previously approved these changes
Sep 12, 2020
| // If it does let's update this.comment so that it matches the defaultValue that we show in textInput. | ||
| if (this.props.comment && prevProps.comment === '' && prevProps.comment !== this.props.comment) { | ||
| this.comment = this.props.comment; | ||
| } |
Contributor
There was a problem hiding this comment.
NAB, it's bugging me a little that we can't do this in the constructor but not much we can do right now
Contributor
Author
There was a problem hiding this comment.
Yeah it's a little annoying but its the best i could think off such that we could still use debounce and have this.comment always be up to date.
chiragsalian
dismissed stale reviews from marcaaron and AndrewGable
via
ed8551f
Contributor
Author
|
Updated to address recent review comment. |
marcaaron
approved these changes
Sep 12, 2020
AndrewGable
approved these changes
Sep 14, 2020
This was referenced Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#457
Tests