Invoicing bank accounts section by rezkiy37 · Pull Request #47218 · Expensify/App

rezkiy37 · 2024-08-12T09:45:10Z

Details

The PR introduces the invoice bank accounts section.

Fixed Issues

$ #45177
PROPOSAL: N/A

Tests

When no bank accounts

Open the invoices page.
Verify that the new bank accounts section is displayed.
Verify that the green "Add bank account" button is displayed.
Click on the "Add bank account" button.
Verify that the Plaid flow has been started.

When bank accounts are present

Open the invoices page.
Verify that the new bank accounts section is displayed.
Verify that the bank accounts list is displayed.
Verify that the transparent "Add bank account" button is displayed.
Click on the "Add bank account" button.
Verify that the Plaid flow has been started.
Click on non-default bank account.
Verify that there is a button to set the particular bank account as a default one.
Click on the button.
Verify that the badge has been attached to the new default bank account.

Verify that no errors appear in the JS console

Offline tests

Click on the "Add bank account" button.
Verify that the "Add bank account" page shows the offline view.

QA Steps

Same as "Tests".

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mp4

Android: mWeb Chrome

Android.Chrome.mp4

iOS: Native

IOS.mp4

iOS: mWeb Safari

IOS.Safari.mp4

MacOS: Chrome / Safari

Chrome.mp4

MacOS: Desktop

Desktop.mp4

…ture/45177-invoice-back-accounts-section

melvin-bot · 2024-09-26T09:47:23Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Pujan92 · 2024-09-27T05:49:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-09-27.at.15.54.09.mov

MacOS: Desktop

…e/45177-invoice-back-accounts-section' and 'main' of https://github.com/rezkiy37/Expensify into feature/45177-invoice-back-accounts-section

src/pages/settings/Wallet/PaymentMethodList.tsx

Pujan92 · 2024-09-27T10:15:20Z

As we are not showing the invoices option in the LHN yet, in the test steps we can add to open invoices page directly in URL

https://staging.new.expensify.com/settings/workspaces/policy_id/invoices

src/pages/workspace/invoices/WorkspaceInvoicesPage.tsx

Pujan92

LGTM!

madmax330

Looks good, just a couple of small comments

src/libs/actions/PaymentMethods.ts

src/pages/settings/Wallet/PaymentMethodList.tsx

…ture/45177-invoice-back-accounts-section

OSBotify · 2024-09-30T12:19:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-09-30T22:57:02Z

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.0.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-02T00:19:53Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.42-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2025-01-28T08:56:50Z

src/pages/workspace/invoices/WorkspaceInvoiceVBASection.tsx

+    const shouldShowEmptyState = !hasBankAccount;
+    // Determines whether or not the modal popup is mounted from the bottom of the screen instead of the side mount on Web or Desktop screens
+    const isPopoverBottomMount = anchorPosition.anchorPositionTop === 0 || shouldUseNarrowLayout;
+    const shouldShowMakeDefaultButton = !paymentMethod.isSelectedPaymentMethodDefault;


Coming from #53693, we were showing the Make default payment method even when there's only one payment method available.

hungvu193 · 2025-10-24T02:06:55Z

src/pages/workspace/invoices/WorkspaceInvoiceVBASection.tsx

+        if (paymentType === CONST.PAYMENT_METHODS.PERSONAL_BANK_ACCOUNT || paymentType === CONST.PAYMENT_METHODS.BUSINESS_BANK_ACCOUNT) {
+            BankAccounts.openPersonalBankAccountSetupView();
+            return;
+        }


As discussed in #68031, we decided to only allow connecting BBA inside Workflows.

#68031 (comment)

situchan

This feature PR didn't consider the case when bank account is partially setup.
So when click on payment method item, it showed 3-dot menu instead of showing modal with Continue setup and Start over button

rezkiy37 added 24 commits August 12, 2024 11:44

create raw WorkspaceInvoiceVBASection

67e37b9

add invoice types

c2b9af4

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

077a401

…ture/45177-invoice-back-accounts-section

integrate bank accounts logic

be90481

add translations

8e9d73e

integrate add bank account button

3661b67

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

e7a88a0

…ture/45177-invoice-back-accounts-section

omit card logic

97d6073

reuse types

54591c2

integrate usePaymentMethodState hook

2a8f11f

rename shouldUseSuccessAddBankAccountButton

cb90633

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

05af88f

…ture/45177-invoice-back-accounts-section

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

edd8507

…ture/45177-invoice-back-accounts-section

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

2bec476

…ture/45177-invoice-back-accounts-section

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

162d4da

…ture/45177-invoice-back-accounts-section

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

c3258e2

…ture/45177-invoice-back-accounts-section

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

68cb5a2

…ture/45177-invoice-back-accounts-section

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

676a0da

…ture/45177-invoice-back-accounts-section

implement setInvoicingTransferBankAccount

8094a1a

PaymentMethodList accepts invoiceTransferBankAccountID

6b2fff4

implement default back account in WorkspaceInvoiceVBASection

d273a5a

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

46f5e1b

…ture/45177-invoice-back-accounts-section

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

03b76f2

…ture/45177-invoice-back-accounts-section

Refactor PaymentMethodList component to use useOnyx

386dc9c

rezkiy37 changed the title ~~[WIP] [No QA] Invoicing bank accounts section~~ Invoicing bank accounts section Sep 26, 2024

rezkiy37 marked this pull request as ready for review September 26, 2024 09:47

rezkiy37 requested a review from a team as a code owner September 26, 2024 09:47

melvin-bot bot requested a review from Pujan92 September 26, 2024 09:47

melvin-bot bot removed the request for review from a team September 26, 2024 09:47

Merge branches 'feature/45177-invoice-back-accounts-section', 'featur…

7b0f675

…e/45177-invoice-back-accounts-section' and 'main' of https://github.com/rezkiy37/Expensify into feature/45177-invoice-back-accounts-section

Pujan92 reviewed Sep 27, 2024

View reviewed changes

src/pages/settings/Wallet/PaymentMethodList.tsx Show resolved Hide resolved

src/pages/settings/Wallet/PaymentMethodList.tsx Outdated Show resolved Hide resolved

update disabled prop

c8861f3

rezkiy37 requested a review from Pujan92 September 27, 2024 10:30

Pujan92 reviewed Sep 27, 2024

View reviewed changes

src/pages/workspace/invoices/WorkspaceInvoicesPage.tsx Show resolved Hide resolved

rename shouldShowAddBankAccountButton

5ae1ca6

This comment was marked as outdated.

Sign in to view

Pujan92 approved these changes Sep 27, 2024

View reviewed changes

melvin-bot bot requested a review from madmax330 September 27, 2024 11:28

madmax330 reviewed Sep 27, 2024

View reviewed changes

src/libs/actions/PaymentMethods.ts Outdated Show resolved Hide resolved

src/pages/settings/Wallet/PaymentMethodList.tsx Show resolved Hide resolved

tweak comment

5635b84

Pujan92 mentioned this pull request Sep 27, 2024

[HOLD for payment 2024-10-11] [$250] Invoicing verify that the user has the feature enabled on the page #49842

Closed

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

2ffc83e

…ture/45177-invoice-back-accounts-section

madmax330 approved these changes Sep 30, 2024

View reviewed changes

madmax330 merged commit 0e7d707 into Expensify:main Sep 30, 2024

github-actions bot mentioned this pull request Sep 30, 2024

Deploy Checklist: New Expensify 2024-09-30 #49960

Closed

49 tasks

daledah mentioned this pull request Oct 1, 2024

fix: requires validate when opening bank account #49230

Merged

50 tasks

rezkiy37 mentioned this pull request Oct 22, 2024

Invoice bank accounts section #45177

Closed

jjcoffee reviewed Jan 28, 2025

View reviewed changes

hungvu193 reviewed Oct 24, 2025

View reviewed changes

situchan reviewed Feb 23, 2026

View reviewed changes

situchan mentioned this pull request Feb 23, 2026

[$250] Invoice - Incomplete bank account on Invoices does not open bank setup RHP #79561

Closed

7 tasks

Conversation

rezkiy37 commented Aug 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

When no bank accounts

When bank accounts are present

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 26, 2024

Uh oh!

Pujan92 commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Pujan92 commented Sep 27, 2024

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Pujan92 left a comment

Choose a reason for hiding this comment

Uh oh!

madmax330 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Sep 30, 2024

Uh oh!

github-actions bot commented Sep 30, 2024

Uh oh!

github-actions bot commented Oct 2, 2024

Uh oh!

jjcoffee Jan 28, 2025

Choose a reason for hiding this comment

Uh oh!

hungvu193 Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rezkiy37 commented Aug 12, 2024 •

edited

Loading

Pujan92 commented Sep 27, 2024 •

edited

Loading