fix: requires validate when opening bank account by daledah · Pull Request #49230 · Expensify/App

daledah · 2024-09-15T20:49:44Z

Details

Fixed Issues

$ #48041
PROPOSAL: #48041 (comment)

Tests

Login with a new Account
Go to settings > wallet
Verify that: Add bank account button is not disabled
Click on Add bank account button
Verify that: Validation page appears
Click on Enable wallet button
Verify that: Validation page appears
Enter magic code
Verify that: Enable wallet page appears.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login with a new Account
Go to settings > wallet
Verify that: Add bank account button is not disabled
Click on Add bank account button
Verify that: Validation page appears
Click on Enable wallet button
Verify that: Validation page appears
Enter magic code
Verify that: Enable wallet page appears.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-18.at.18.10.51.mov

Android: mWeb Chrome

Screen.Recording.2024-09-18.at.18.12.56.mov

iOS: Native

Screen.Recording.2024-09-18.at.23.29.02.mov

iOS: mWeb Safari

Screen.Recording.2024-09-18.at.23.30.55.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-18.at.17.48.10.mov

MacOS: Desktop

Screen.Recording.2024-09-18.at.23.31.26.mov

melvin-bot · 2024-09-18T10:47:47Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

daledah · 2024-09-18T16:46:29Z

@hungvu193 I used the ValidateCodeForm that you added in #48628. Just one question: Why do we auto-remove the error when we have one in here:

App/src/components/ValidateCodeActionModal/ValidateCodeForm/BaseValidateCodeForm.tsx

Lines 131 to 137 in 8d19726

    
           useEffect(() => { 
        
               if (!validateError) { 
        
                   return; 
        
               } 
        
               clearError(); 
        
               // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps 
        
           }, [clearError, validateError]);

I see that in other places, we show the error after the modal is closed, but why don't we show the error directly in the form, so the user don't have to open the modal again?

hungvu193 · 2024-09-19T02:36:19Z

I see that in other places, we show the error after the modal is closed, but why don't we show the error directly in the form, so the user don't have to open the modal again?

Yeah, we have a plan to change that behavior in here, we should clear the error when modal is closed.

daledah · 2024-09-19T07:16:41Z

@jjcoffee According to #49230 (comment), should we hold until #49270 is resolved until we can continue on this one? cc @hungvu193

jjcoffee · 2024-09-19T07:28:08Z

should we hold until #49270 is resolved

@daledah Thanks for bringing that up! I don't think we need to hold on that since it doesn't affect the overall fix here.

jjcoffee · 2024-09-19T08:18:23Z

@daledah Didn't we agree to use ValidateCodeActionModal?

daledah · 2024-09-19T09:40:09Z

@jjcoffee I tried using ValidateCodeActionModal in this commit but it ended up causing a lot of unexpected bugs, so I had to come back to the original solution.

jjcoffee · 2024-09-19T11:57:52Z

@daledah Following the flow Enable wallet -> Add bank account, I think I'd expect that once the validate code is entered we are immediately navigated to the next step, rather than having to click Add bank account again.

jjcoffee · 2024-09-19T11:57:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2024-09-19_14.15.23.mp4

Android: mWeb Chrome

android-chrome-2024-09-19_14.17.18.mp4

iOS: Native

ios-app-2024-09-19_14.01.39.mp4

iOS: mWeb Safari

ios-safari-2024-09-19_13.55.34.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-09-19_14.04.03.mp4

MacOS: Desktop

desktop-app-2024-09-19_14.12.43.mp4

src/SCREENS.ts

jjcoffee · 2024-09-19T12:27:19Z

Tagging @Expensify/design to take a look! Do we need to tag anyone else to review the copy?

src/pages/AddPersonalBankAccountPage.tsx

shawnborton · 2024-09-19T12:58:26Z

Looks pretty good to me 👍

shawnborton · 2024-09-20T05:40:47Z

Could have sworn I saw @dannymcclain leave some feedback in another PR that we could use some more spacing between the inputs and the "Didn't receive a code?" line:

Does that sound right?

daledah · 2024-09-27T05:20:34Z

@jjcoffee Does this look good to you?

Screen.Recording.2024-09-27.at.12.19.17.mov

jjcoffee · 2024-09-27T07:42:37Z

Looks good to me! Any thoughts on the updated flow @dannymcclain @dubielzyk-expensify?

dannymcclain · 2024-09-27T13:32:50Z

Oh I think that feels much better. Let's see what Jon thinks too!

dubielzyk-expensify · 2024-09-30T01:00:42Z

Yep, looks good. Send it!

jjcoffee

LGTM!

src/pages/AddPersonalBankAccountPage.tsx

src/pages/settings/Wallet/VerifyAccountPage.tsx

daledah · 2024-10-01T03:57:47Z

@jjcoffee @arosiclair Looks like #47218 has implemented another add bank account button on Workspace invoices page. Should we keep current behavior on the button as well?

Video:

Screen.Recording.2024-10-01.at.10.57.07.mov

jjcoffee · 2024-10-01T12:01:42Z

Looks like #47218 has implemented another add bank account button on Workspace invoices page. Should we keep current behavior on the button as well?

It looks like that feature is in the process of being developed (it doesn't show up in the menu items yet), so I would say we shouldn't add it here yet. It also feels a bit janky to navigate back to the wallet page in the background as in your video, so we'd probably want to add this as a modal instead which would be out of scope of this particular issue. cc @arosiclair

dannymcclain · 2024-10-01T13:13:09Z

It also feels a bit janky to navigate back to the wallet page in the background as in your video, so we'd probably want to add this as a modal instead which would be out of scope of this particular issue

Agree!

daledah · 2024-10-02T04:36:31Z

@jjcoffee I updated. FYI, I left the new logic unchanged.

jjcoffee · 2024-10-02T07:40:15Z

Over to you @arosiclair!

OSBotify · 2024-10-02T13:41:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-03T03:53:46Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-04T20:57:49Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.44-12 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2024-10-25T07:49:57Z

src/libs/Navigation/linkingConfig/CENTRAL_PANE_TO_RHP_MAPPING.ts

        SCREENS.SETTINGS.WALLET.REPORT_VIRTUAL_CARD_FRAUD,
        SCREENS.SETTINGS.WALLET.CARDS_DIGITAL_DETAILS_UPDATE_ADDRESS,
+        SCREENS.SETTINGS.WALLET.VERIFY_ACCOUNT,
+        SCREENS.SETTINGS.ADD_BANK_ACCOUNT,


Coming from #50214 this caused an issue for Add bank account buttons that shouldn't show the settings page as the central pane.

daledah added 6 commits September 16, 2024 03:47

fix: requires validate when opening bank account

85c7680

Merge branch 'main' into fix/48041

a7c1e49

fix: add Verify account page

f7310b1

Merge branch 'main' into fix/48041

fc2bd89

fix: navigate when add bank account

a5b24fe

fix: request code on open page

56327f6

daledah marked this pull request as ready for review September 18, 2024 10:47

daledah requested a review from a team as a code owner September 18, 2024 10:47

melvin-bot bot requested a review from jjcoffee September 18, 2024 10:47

melvin-bot bot removed the request for review from a team September 18, 2024 10:47

daledah marked this pull request as draft September 18, 2024 11:04

fix: change fallback route

b0fc0d7

daledah marked this pull request as ready for review September 18, 2024 16:40

This comment was marked as resolved.

Sign in to view

jjcoffee reviewed Sep 19, 2024

View reviewed changes

src/SCREENS.ts Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

jjcoffee reviewed Sep 19, 2024

View reviewed changes

src/pages/AddPersonalBankAccountPage.tsx Outdated Show resolved Hide resolved

Merge branch 'main' into fix/48041

88aa696

fix: change enable wallet flow

12830ff

jjcoffee approved these changes Sep 30, 2024

View reviewed changes

melvin-bot bot requested a review from arosiclair September 30, 2024 09:28

arosiclair requested changes Sep 30, 2024

View reviewed changes

src/pages/AddPersonalBankAccountPage.tsx Outdated Show resolved Hide resolved

src/pages/settings/Wallet/VerifyAccountPage.tsx Outdated Show resolved Hide resolved

Merge branch 'main' into fix/48041

edfa9b1

daledah added 2 commits October 2, 2024 11:08

fix: merge main

1f17dba

fix: lint

d4db6a3

arosiclair approved these changes Oct 2, 2024

View reviewed changes

arosiclair merged commit 3946b22 into Expensify:main Oct 2, 2024

github-actions bot mentioned this pull request Oct 3, 2024

Deploy Checklist: New Expensify 2024-10-03 #50125

Closed

63 tasks

daledah mentioned this pull request Oct 4, 2024

[HOLD for payment 2024-10-24] Expense - Report view changes to Wallet page when Add bank account RHP opens #50214

Closed

6 tasks

jjcoffee mentioned this pull request Oct 4, 2024

fix: remove add bank account page from central pane mapping #50228

Merged

50 tasks

melvin-bot bot mentioned this pull request Oct 4, 2024

[PAID] [$250] Wallet empty state has disabled "Add bank account" button for new, unvalidated accounts #48041

Closed

6 tasks

ikevin127 mentioned this pull request Oct 7, 2024

[HOLD for payment 2024-11-21] [$250] Pay someone - User is signed out after verifying account during pay someone flow #50284

Closed

6 tasks

mkzie2 mentioned this pull request Oct 9, 2024

show validate code modal when adding bank account #49366

Closed

49 tasks

jjcoffee reviewed Oct 25, 2024

View reviewed changes

Conversation

daledah commented Sep 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 18, 2024

Uh oh!

daledah commented Sep 18, 2024

Uh oh!

hungvu193 commented Sep 19, 2024

Uh oh!

daledah commented Sep 19, 2024

Uh oh!

jjcoffee commented Sep 19, 2024

Uh oh!

jjcoffee commented Sep 19, 2024

Uh oh!

daledah commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjcoffee commented Sep 19, 2024

Uh oh!

jjcoffee commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

This comment was marked as resolved.

Uh oh!

jjcoffee commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

shawnborton commented Sep 19, 2024

Uh oh!

shawnborton commented Sep 20, 2024

Uh oh!

daledah commented Sep 27, 2024

Uh oh!

jjcoffee commented Sep 27, 2024

Uh oh!

dannymcclain commented Sep 27, 2024

Uh oh!

dubielzyk-expensify commented Sep 30, 2024

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

daledah commented Oct 1, 2024

Uh oh!

jjcoffee commented Oct 1, 2024

Uh oh!

dannymcclain commented Oct 1, 2024

Uh oh!

daledah commented Oct 2, 2024

Uh oh!

jjcoffee commented Oct 2, 2024

Uh oh!

OSBotify commented Oct 2, 2024

Uh oh!

github-actions bot commented Oct 3, 2024

Uh oh!

github-actions bot commented Oct 4, 2024

Uh oh!

jjcoffee Oct 25, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

daledah commented Sep 15, 2024 •

edited

Loading

daledah commented Sep 19, 2024 •

edited

Loading

jjcoffee commented Sep 19, 2024 •

edited

Loading

jjcoffee commented Sep 19, 2024 •

edited

Loading