create announce room when 3 or more participants by rojiphil · Pull Request #48660 · Expensify/App

rojiphil · 2024-09-05T17:18:59Z

Details

This PR removes the creation of #announce room during workspace creation and, instead, optimistically creates the workspace when 3 or more participants are added to the workspace.
Also, we hide the Go to #announce room menu option in Workspace settings when there are less than 3 participants.

Fixed Issues

$ #34929
PROPOSAL: #34929 (comment)

Tests

Sign-in using a new account and onboard using Manage my Team’s expenses to create a workspace.
Verify that LHN does not show #announce room (Test 1)
Go to Account Settings -> Workspaces
Click on 3Dots menu and verify that the menu option Go to #announce room is not displayed (Test 2)
Click on the workspace to go to Workspace Settings.
Click Members in LHN to navigate to Members page
Invite member to add a new member to workspace.
Navigate back to LHN and verify that the menu option Go to #announce room is not displayed (Test 3)
Navigate back to Members page and Invite member again.
Navigate back to LHN and verify that the menu option Go to #announce room is displayed (Test 4)

Verify that no errors appear in the JS console

Offline tests

Same as Steps for Tests Section.

QA Steps

Same as Steps for Tests Section.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Mobile Web - Chrome

48660-mweb-chrome-001.mp4

Mobile Web - Safari

48660-mweb-safari-001.mp4

Web

48660-web-safari-001.mp4

Desktop

48860-desktop-001.mp4

iOS

48860-ios-native-001.mp4

Android

48660-android-native-001.mp4

NikkiWines · 2024-09-18T21:01:27Z

@rojiphil the backend changes should be live now!

rojiphil · 2024-09-19T12:55:00Z

Tested with the BE changes and works well.
@allroundexperts PR is ready for review.

melvin-bot · 2024-09-19T12:55:09Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rojiphil · 2024-09-19T12:56:31Z

Note: Recent changes in ESLint has introduced some errors in the build but the errors are not due to our PR here.

allroundexperts · 2024-09-22T21:29:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-26.at.6.23.59.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-09-26.at.6.17.47.PM.mov

iOS: Native

Screen.Recording.2024-09-26.at.6.00.11.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-09-26.at.5.58.05.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-26.at.5.46.38.PM.mov

MacOS: Desktop

Screen.Recording.2024-09-26.at.5.51.29.PM.mov

NikkiWines · 2024-09-24T17:20:53Z

@allroundexperts friendly bump here

allroundexperts · 2024-09-24T19:38:28Z

@allroundexperts friendly bump here

Giving it another look today.

allroundexperts · 2024-09-24T19:39:22Z

@rojiphil You have lint errors. Can you please fix?

rojiphil · 2024-09-24T19:47:52Z

@rojiphil You have lint errors. Can you please fix?

@allroundexperts The errors are due to recent changes to eslint and is not related to our PR here. More specifically, it is related to getParentReportAction deprecated function which needs further discussion as mentioned here. Since this issue is to be taken up elsewhere it is better to ignore here. Does this make sense?

allroundexperts · 2024-09-24T19:49:05Z

Can you merge main please?

rojiphil · 2024-09-24T19:52:57Z

Can you merge main please?

Done

trjExpensify · 2024-09-26T10:45:36Z

Escalated here.

allroundexperts · 2024-09-26T12:48:05Z

Working very good. Finalising the checklist now.

Screen.Recording.2024-09-26.at.5.46.38.PM.mov

allroundexperts

Works great!

NikkiWines

Looks good and tests well so far, just one eslint error for WorkspaceInviteMessagePage.tsx with the following error:

error  'withOnyx' is deprecated. Use `useOnyx` instead of `withOnyx` whenever possible.

rojiphil · 2024-09-27T06:48:33Z

just one eslint error for WorkspaceInviteMessagePage.tsx

@NikkiWines Fixed the lint error.

NikkiWines

OSBotify · 2024-09-27T16:13:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-09-27T17:58:38Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.0.41-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dangrous · 2024-09-30T15:18:55Z

Hi all, as linked above - it looks like this caused #49899 - can you take a quick look, and we can decide how to proceed? Thanks!

github-actions · 2024-09-30T22:40:25Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.41-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rojiphil · 2024-10-24T15:22:26Z

src/pages/workspace/WorkspaceInviteMessagePage.tsx

    }, []);

+    useEffect(() => {
+        if (isEmptyObject(invitedEmailsToAccountIDsDraft)) {


We needed an early return here for cases where the welcomeNote is intentionally not set. This is to avoid default value being set for such cases. This caused #49899.

abdulrahuman5196 · 2024-11-11T15:16:30Z

src/pages/workspace/WorkspaceInviteMessagePage.tsx

        // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
    }, []);

+    useEffect(() => {


This caused issue where the welcome message re-appears when deleted - More information here #49996

rojiphil added 3 commits September 5, 2024 22:25

create announce room when 3 or more participants

6cb68e3

remove console log

e326b2c

jest, lint and typecheck fixes

dbebceb

NikkiWines self-requested a review September 10, 2024 00:40

rojiphil added 3 commits September 10, 2024 20:53

Merge branch 'main' into 34929-create-announce-room-later

380b604

lint fix

376502a

pass announce params to addmemberstoworkspace

76ec71a

NikkiWines mentioned this pull request Sep 12, 2024

[Hold #41442] [Guided Setup Stage 3][$500] Don't create default #announce rooms until a workspace has 3 or more members #34929

Closed

rojiphil added 3 commits September 19, 2024 07:37

Merge branch 'Expensify:main' into 34929-create-announce-room-later

e999184

cleanup

0b0f3b2

prettier fix

568e66c

rojiphil marked this pull request as ready for review September 19, 2024 12:55

rojiphil requested a review from a team as a code owner September 19, 2024 12:55

melvin-bot bot requested a review from allroundexperts September 19, 2024 12:55

melvin-bot bot removed the request for review from a team September 19, 2024 12:55

blimpich mentioned this pull request Sep 23, 2024

#announce - Not here page opens when #announce room is accessed via 3 dot menu #48371

Closed

6 tasks

Merge branch 'Expensify:main' into 34929-create-announce-room-later

07a4731

Merge branch 'Expensify:main' into 34929-create-announce-room-later

20cc414

allroundexperts approved these changes Sep 26, 2024

View reviewed changes

NikkiWines requested changes Sep 26, 2024

View reviewed changes

rojiphil added 3 commits September 27, 2024 07:55

Merge branch 'Expensify:main' into 34929-create-announce-room-later

3978c17

fixed eslint error

ea0cfb5

lint fix

a59988b

rojiphil requested a review from NikkiWines September 27, 2024 06:48

NikkiWines approved these changes Sep 27, 2024

View reviewed changes

NikkiWines merged commit 6aabedb into Expensify:main Sep 27, 2024

github-actions bot mentioned this pull request Sep 27, 2024

Deploy Checklist: New Expensify 2024-09-27 #49855

Closed

Krishna2323 mentioned this pull request Sep 29, 2024

[HOLD for payment 2024-10-07] Workspace - Invite message comes back after deleting it #49899

Closed

6 tasks

bernhardoj mentioned this pull request Oct 1, 2024

[HOLD for payment 2024-11-07] [HOLD for payment 2024-10-30] [$125.00] Workspace -Previous invite message reappears after clearing the field and entering a character #49996

Closed

6 tasks

mkzie2 mentioned this pull request Oct 4, 2024

[Due for payment 2025-03-05] [$250] Room - #announce room can be created via room mention #50173

Closed

6 tasks

rojiphil commented Oct 24, 2024

View reviewed changes

abdulrahuman5196 reviewed Nov 11, 2024

View reviewed changes

Conversation

rojiphil commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

NikkiWines commented Sep 18, 2024

Uh oh!

rojiphil commented Sep 19, 2024

Uh oh!

melvin-bot bot commented Sep 19, 2024

Uh oh!

rojiphil commented Sep 19, 2024

Uh oh!

allroundexperts commented Sep 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

NikkiWines commented Sep 24, 2024

Uh oh!

allroundexperts commented Sep 24, 2024

Uh oh!

allroundexperts commented Sep 24, 2024

Uh oh!

rojiphil commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allroundexperts commented Sep 24, 2024

Uh oh!

rojiphil commented Sep 24, 2024

Uh oh!

trjExpensify commented Sep 26, 2024

Uh oh!

allroundexperts commented Sep 26, 2024

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

rojiphil commented Sep 27, 2024

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Sep 27, 2024

Uh oh!

github-actions bot commented Sep 27, 2024

Uh oh!

dangrous commented Sep 30, 2024

Uh oh!

github-actions bot commented Sep 30, 2024

Uh oh!

rojiphil Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 Nov 11, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rojiphil commented Sep 5, 2024 •

edited

Loading

allroundexperts commented Sep 22, 2024 •

edited

Loading

rojiphil commented Sep 24, 2024 •

edited

Loading