Fix performance of SearchRouter#50143
Merged
luacmartins merged 2 commits intoExpensify:mainfrom Oct 3, 2024
Merged
Conversation
48 tasks
6 tasks
Contributor
|
can you link this issue as well please? |
github-actions
bot
added
the
DeployBlockerCash
Contributor
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
63 tasks
luacmartins
removed
the
DeployBlockerCash
Kicu
approved these changes
Oct 3, 2024
Contributor
Kicu
left a comment
Kicu
left a comment
There was a problem hiding this comment.
LGTM 👍
but I think the migration of AuthScreens to useOnyx should be done in a separate PR, because AuthScreens is a special komponent, as it's pretty high up the tree and renders navigators.
Contributor
|
Agree with that part |
SzymczakJ
force-pushed
the
@szymczak/fix-search-router-performance
branch
from
304845d to
dfb3325
Compare
|
@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
Please ignore the eslint rule as it's forcing me to migrate withOnyx to useOnyx in AuthScreen which has a dedicated issue #49103 |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeScreen.Recording.2024-10-03.at.4.32.55.PM.moviOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-03.at.16.27.02.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-03.at.16.28.34.mp4MacOS: Chrome / SafariScreen.Recording.2024-10-03.at.4.22.21.PM.movMacOS: DesktopScreen.Recording.2024-10-03.at.4.24.46.PM.mov |
6 tasks
Contributor
|
#50156 is also fixed in this PR Screen.Recording.2024-10-03.at.4.32.19.PM.mov |
Contributor
|
@luacmartins all yours! |
Contributor
|
@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
6 tasks
OSBotify
pushed a commit
that referenced
this pull request
Oct 3, 2024
…arch-router-performance Fix performance of SearchRouter (cherry picked from commit 0c2900c) (CP triggered by jasperhuangg)
Contributor
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.0.44-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
github-actions
bot
added
the
DeployBlockerCash
Contributor
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
50 tasks
Contributor
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.44-12 🚀
|
luacmartins
removed
the
DeployBlockerCash
ishpaul777
reviewed
Nov 17, 2024
| const {isSmallScreenWidth} = useResponsiveLayout(); | ||
| const {isSearchRouterDisplayed, closeSearchRouter} = useSearchRouterContext(); | ||
|
|
||
| const modalType = isSmallScreenWidth ? CONST.MODAL.MODAL_TYPE.CENTERED_UNSWIPEABLE : CONST.MODAL.MODAL_TYPE.POPOVER; |
Contributor
eh2077
reviewed
Mar 12, 2025
| popoverAnchorPosition={{right: 20, top: 20}} | ||
| onClose={closeSearchRouter} | ||
| > | ||
| <FocusTrapForModal active={isSearchRouterDisplayed}>{isSearchRouterDisplayed && <SearchRouter />}</FocusTrapForModal> |
Contributor
There was a problem hiding this comment.
This caused
We should enable keyboard avoiding view in search modal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes performance of App
Fixed Issues
$ #49120
$ #49116
$ #50141
$ #50156
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
androidweb.mov
iOS: Native
ios.mov
iOS: mWeb Safari
iosweb.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov