Make SearchRouter swipable to the right by SzymczakJ · Pull Request #51731 · Expensify/App

SzymczakJ · 2024-10-30T12:41:27Z

Explanation of Change

This PR allows SearchRouter to be swipable to the right when on mobile screen.

Fixed Issues

$ #51191
PROPOSAL:

Tests

On mobile iOS - make sure swiping SearchRouter to the right is closing the router as expected:

Open ND on IOS app
Tap on the search icon on the top right(it is present on screens like Report page, Workspace page, Search page, etc.)
verify Swipe to the right to go back to LHN search page (iOS swiping style) works as expected

Test SearchRouter common scenarios, like opening and closing, scrolling SearchRouterList, entering query or selecting SearchRouterList item. (SearchRouter is opened by clicking search icon on the top right, one should be able to type into text input and search for query, by clicking enter. User should be able to open reports by clicking on report list items and search for recent search by clicking on recent search item.)

Offline tests

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

androidWeb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

iosWeb.mov

MacOS: Chrome / Safari

MacOS: Desktop

289Adam289

LGTM

melvin-bot · 2024-10-30T13:36:41Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-10-30T15:37:02Z

Videos look good to me from a design perspective 👍

ishpaul777 · 2024-10-30T17:49:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-31.at.10.14.59.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-10-31.at.10.23.03.PM.mov

iOS: Native

Screen.Recording.2024-10-31.at.10.12.37.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-10-31.at.10.07.59.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-31.at.10.27.46.PM.mov

MacOS: Desktop

Screen.Recording.2024-10-31.at.10.25.40.PM.mov

ishpaul777 · 2024-10-30T18:25:51Z

[BUG: ios safari ] status bar and adressbar background color not matching with screen

ishpaul777 · 2024-10-30T18:42:01Z

@SzymczakJ just incase you didn't notice jest test (job 2) failing for PR

ishpaul777 · 2024-10-30T18:57:01Z

[Bug: Android] transition animation in (<-) and out (->) not visible

Screen.Recording.2024-10-31.at.12.24.32.AM.mov

SzymczakJ · 2024-10-31T09:38:56Z

I've fixed iOS bug and android bug is not reproducible on my end, maybe it was fixed by merge or something.

Screen.Recording.2024-10-31.at.10.36.14.mov

SzymczakJ · 2024-10-31T11:40:24Z

FYI I'll OOO on Friday and Monday.

ishpaul777 · 2024-10-31T17:03:36Z

src/styles/utils/generators/ModalStyleUtils.ts

+                animationIn = isSmallScreenWidth ? 'slideInRight' : 'fadeIn';
+                animationOut = isSmallScreenWidth ? 'slideOutRight' : 'fadeOut';


NAB, we can define these strings as constants, since its used these few time in this file

melvin-bot · 2024-10-31T17:04:12Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #51191 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

ishpaul777 · 2024-10-31T17:06:28Z

android bug is not reproducible on my end, maybe it was fixed by merge or something.

FWIW, I am still able to reproduce but only on a big high traffic account and its also reproducable on main, so not a blocker for this PR

OSBotify · 2024-10-31T19:36:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-04T14:39:31Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 9.0.57-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

mvtglobally · 2024-11-04T15:54:07Z

@SzymczakJ @pecanoro @shawnborton What do we need to QA here? Can someone help with QA steps?

pecanoro · 2024-11-04T17:42:59Z

@SzymczakJ I just realized the QA steps are pretty vague, could you please outline them step by step in a way any user could follow them, please?

ishpaul777 · 2024-11-04T18:30:02Z

QA steps:

Open ND on IOS app
Tap on the search icon on the top right
verify Swipe to the right to go back to LHN search page (iOS swiping style) works as expected

@mvtglobally

SzymczakJ · 2024-11-05T09:26:20Z

Thanks @ishpaul777 for answering for me as I was OOO, I've made tests steps more detailed.

github-actions · 2024-11-06T00:03:04Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.57-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

SzymczakJ added 2 commits October 30, 2024 13:07

make SearchRouter swipable to the right

414b41d

fix unintentional code change

5833b42

289Adam289 approved these changes Oct 30, 2024

View reviewed changes

SzymczakJ marked this pull request as ready for review October 30, 2024 13:36

SzymczakJ requested review from a team as code owners October 30, 2024 13:36

melvin-bot bot requested a review from ishpaul777 October 30, 2024 13:36

melvin-bot bot removed the request for review from a team October 30, 2024 13:36

SzymczakJ added 2 commits October 31, 2024 10:16

fix ios web bug

ffa60b7

Merge branch 'main' into @szymczak/fix-searchRouter-unswipable

dbba655

ishpaul777 reviewed Oct 31, 2024

View reviewed changes

ishpaul777 approved these changes Oct 31, 2024

View reviewed changes

melvin-bot bot requested a review from pecanoro October 31, 2024 17:04

pecanoro approved these changes Oct 31, 2024

View reviewed changes

pecanoro merged commit 144b58e into Expensify:main Oct 31, 2024

github-actions bot mentioned this pull request Nov 4, 2024

Deploy Checklist: New Expensify 2024-11-04 #51953

Closed

63 tasks

melvin-bot bot mentioned this pull request Nov 6, 2024

[HOLD for payment 2024-11-13] [$250] iOS - Search - Search page cannot be dismissed by swiping to the right #51191

Closed

8 tasks

ishpaul777 mentioned this pull request Nov 17, 2024

Fix performance of SearchRouter #50143

Merged

49 tasks

IuliiaHerets mentioned this pull request Feb 22, 2025

[Due for payment 2025-03-17] [Due for payment 2025-03-13] [$250] iOS - Search - Search page cannot be dismissed by swiping to the right #57291

Closed

8 tasks

SzymczakJ deleted the @szymczak/fix-searchRouter-unswipable branch April 8, 2025 09:12

		animationIn = isSmallScreenWidth ? 'slideInRight' : 'fadeIn';
		animationOut = isSmallScreenWidth ? 'slideOutRight' : 'fadeOut';

Conversation

SzymczakJ commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

289Adam289 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Oct 30, 2024

Uh oh!

shawnborton commented Oct 30, 2024

Uh oh!

ishpaul777 commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Oct 30, 2024

Uh oh!

ishpaul777 commented Oct 30, 2024

Uh oh!

ishpaul777 commented Oct 30, 2024

Uh oh!

SzymczakJ commented Oct 31, 2024

Uh oh!

SzymczakJ commented Oct 31, 2024

Uh oh!

ishpaul777 Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Oct 31, 2024

Uh oh!

ishpaul777 commented Oct 31, 2024

Uh oh!

OSBotify commented Oct 31, 2024

Uh oh!

github-actions bot commented Nov 4, 2024

Uh oh!

mvtglobally commented Nov 4, 2024

Uh oh!

pecanoro commented Nov 4, 2024

Uh oh!

ishpaul777 commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SzymczakJ commented Nov 5, 2024

Uh oh!

github-actions bot commented Nov 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

SzymczakJ commented Oct 30, 2024 •

edited

Loading

ishpaul777 commented Oct 30, 2024 •

edited

Loading

ishpaul777 commented Nov 4, 2024 •

edited

Loading