[ReportPreview / Text] When showing two avatars, also show both display names with tooltip by grgia · Pull Request #50341 · Expensify/App

grgia · 2024-10-07T16:39:16Z

Details

We Reverted https://github.com/Expensify/App/pull/49172/files#diff-f0268faeaefd2de8c31b3f9ceba588c49478c66413b82b3285b0704b820a57a8

I'm breaking it into smaller PRs to avoid blockers- this PR allows for displaying both names if two avatars are shown. It does not change what avatars are shown.

Fixed Issues

Part of #49036
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console
Create or locate a report preview that displays two avatars
✅ Verify that both names are displayed in Name 1 & Name 2 Format
Create or locate a report preview that displays a single avatar
✅ Verify that single name is displayed i.e. Name 1

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-10-07T18:24:49Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

grgia · 2024-10-07T19:20:34Z

@eh2077 I assigned you since this is code from the original PR, I'm breaking it into pieces

src/pages/home/report/ReportActionItemSingle.tsx

eh2077 · 2024-10-08T13:42:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

eh2077

The changes looks good just a minor comment.

I'll complete remain recordings early tmr as it's EOD for me.

eh2077 · 2024-10-08T15:42:49Z

src/pages/home/report/ReportActionItemSingle.tsx

+                    {personArray.map((fragment) => (
+                        <ReportActionItemFragment
+                            style={[styles.flex1]}
+                            key={`person-${action?.reportActionID}-${actorAccountID}`}


I think it's better to use index suffix like before. Because it's possible that
personArray.length === 2 and isReportPreviewAction is false right?

I did it because of this eslint error-

I think we might be able to use this pattern for all multiple avatar cases, but we'd need to confirm with design and it's an easy fix so I'll do that in a separate PR if so

To clarify the above comment, we may be able to remove the isReportPreviewAction check entirely

Got it. For the lint error, maybe we can just disable the lint by adding

// eslint-disable-next-line react/no-array-index-key

Yeah I see what you mean, updating now.

eh2077

LGTM

melvin-bot · 2024-10-09T15:33:19Z

@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-10-09T15:33:22Z

🎯 @eh2077, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #50506.

OSBotify · 2024-10-09T15:49:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-09T20:48:05Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.47-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

IuliiaHerets · 2024-10-10T09:54:28Z

This PR is failing for Web because of issue #50547

lakchote · 2024-10-10T11:32:43Z

Reverted because of these reasons.

github-actions · 2024-10-10T23:03:16Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.47-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

When showing two avatars, also show both names with tooltip

58d2ae2

grgia self-assigned this Oct 7, 2024

grgia changed the title ~~When showing two avatars, also show both names with tooltip~~ [ReportPreview / Text]When showing two avatars, also show display both names with tooltip Oct 7, 2024

grgia changed the title ~~[ReportPreview / Text]When showing two avatars, also show display both names with tooltip~~ [ReportPreview / Text] When showing two avatars, also show display both names with tooltip Oct 7, 2024

typescript null check

2ff15ab

grgia marked this pull request as ready for review October 7, 2024 18:24

grgia requested a review from a team as a code owner October 7, 2024 18:24

melvin-bot bot requested review from marcaaron and removed request for a team October 7, 2024 18:24

grgia requested a review from eh2077 October 7, 2024 19:19

marcaaron removed their request for review October 8, 2024 00:49

marcaaron reviewed Oct 8, 2024

View reviewed changes

src/pages/home/report/ReportActionItemSingle.tsx Outdated Show resolved Hide resolved

useCallback() for function

73f0200

grgia changed the title ~~[ReportPreview / Text] When showing two avatars, also show display both names with tooltip~~ [ReportPreview / Text] When showing two avatars, also show both display names with tooltip Oct 8, 2024

eh2077 reviewed Oct 8, 2024

View reviewed changes

Merge branch 'main' into georgia-heading

57108d8

grgia requested review from eh2077 and marcaaron October 9, 2024 12:46

fix indexing

3880862

eh2077 approved these changes Oct 9, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath October 9, 2024 15:33

melvin-bot bot mentioned this pull request Oct 9, 2024

Payment issue for E/App PR#50341 #50506

Closed

puneetlath approved these changes Oct 9, 2024

View reviewed changes

puneetlath merged commit a427327 into main Oct 9, 2024

puneetlath deleted the georgia-heading branch October 9, 2024 15:39

github-actions bot mentioned this pull request Oct 9, 2024

Deploy Checklist: New Expensify 2024-10-09 #50518

Closed

58 tasks

IuliiaHerets mentioned this pull request Oct 10, 2024

Expense - No "&" when the display name is long, name overlaps with time on Android & iOS #50547

Closed

6 tasks

This was referenced Oct 10, 2024

Expense - Expense preview displays "fragment.text" when the expense is invalid #50553

Closed

[CP Staging] Revert "[ReportPreview / Text] When showing two avatars, also show both display names with tooltip" #50557

Merged

grgia mentioned this pull request Oct 14, 2024

[Avatars] Revert PR #50557 If two avatars, use Name 1 & Name 2 pattern. #50697

Closed

58 tasks

Conversation

grgia commented Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 7, 2024 • edited by marcaaron Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grgia commented Oct 7, 2024

Uh oh!

Uh oh!

eh2077 commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

eh2077 Oct 8, 2024

Choose a reason for hiding this comment

Uh oh!

grgia Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

grgia Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

eh2077 Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

grgia Oct 9, 2024

Choose a reason for hiding this comment

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Oct 9, 2024

Uh oh!

melvin-bot bot commented Oct 9, 2024

Uh oh!

OSBotify commented Oct 9, 2024

Uh oh!

github-actions bot commented Oct 9, 2024

Uh oh!

IuliiaHerets commented Oct 10, 2024

Uh oh!

lakchote commented Oct 10, 2024

Uh oh!

github-actions bot commented Oct 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

grgia commented Oct 7, 2024 •

edited

Loading

melvin-bot bot commented Oct 7, 2024 •

edited by marcaaron

Loading

eh2077 commented Oct 8, 2024 •

edited

Loading