Skip to content

[CP Staging] Revert "[ReportPreview / Text] When showing two avatars, also show both display names with tooltip"#50557

Merged
lakchote merged 1 commit intomainfrom
revert-50341-georgia-heading
Oct 10, 2024
Merged

[CP Staging] Revert "[ReportPreview / Text] When showing two avatars, also show both display names with tooltip"#50557
lakchote merged 1 commit intomainfrom
revert-50341-georgia-heading

Conversation

@lakchote
Copy link
Contributor

@lakchote lakchote commented Oct 10, 2024 •
edited by mountiny
Loading

Reverts #50341

related
#50553
#50547

@lakchote lakchote self-assigned this Oct 10, 2024
@lakchote lakchote requested a review from a team as a code owner October 10, 2024 11:22
@lakchote lakchote requested a review from mountiny October 10, 2024 11:22
@melvin-bot melvin-bot bot requested review from aldo-expensify and removed request for a team October 10, 2024 11:22
@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2024

@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny
mountiny approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming its a straight revert. This should fix 2 blockers so far and Georgia is ooo now so in order to focus on getting the deploy out and focus on other blockers, I agree this is better to revert in this case.

#50553
#50547

@mountiny
Copy link
Contributor

mountiny commented Oct 10, 2024

Straight revert, no need to add checklists

@lakchote lakchote merged commit b70ad57 into main Oct 10, 2024
@lakchote lakchote deleted the revert-50341-georgia-heading branch October 10, 2024 11:29
@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2024

@lakchote looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Oct 10, 2024
@lakchote
Copy link
Contributor Author

lakchote commented Oct 10, 2024

Removing the emergency label: this is a straight revert.

OSBotify pushed a commit that referenced this pull request Oct 10, 2024
@lakchote @OSBotify
Merge pull request #50557 from Expensify/revert-50341-georgia-heading
d7ba0bf 
[CP Staging] Revert "[ReportPreview / Text] When showing two avatars, also show both display names with tooltip"

(cherry picked from commit b70ad57)

(CP triggered by mountiny)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Oct 10, 2024
@lakchote lakchote mentioned this pull request Oct 10, 2024
Merged
54 tasks
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
Closed
58 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Oct 10, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.47-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

This was referenced Oct 10, 2024
Closed
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.47-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

grgia added a commit that referenced this pull request Oct 14, 2024
@grgia
Revert "Merge pull request #50557 from Expensify/revert-50341-georgia…
4ba67b3 
…-heading"

This reverts commit b70ad57, reversing
changes made to ab5175c.
@grgia grgia mentioned this pull request Oct 14, 2024
Closed
58 tasks
grgia added a commit that referenced this pull request Mar 31, 2025
@grgia
Revert #50557 (manual)
f820cf8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mountiny mountiny mountiny approved these changes

@aldo-expensify aldo-expensify Awaiting requested review from aldo-expensify

Assignees

@lakchote lakchote

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lakchote @mountiny @OSBotify