[HybridApp] Implement POC of NewDot SignIn on HybridApp#51257
Conversation
# Conflicts: # src/libs/actions/Session/index.ts
…ult-for-hybridapp
* Implement ND bootsplash logic * Rename param * Adress review
# Conflicts: # src/ONYXKEYS.ts # src/libs/actions/Session/index.ts # src/types/modules/react-native.d.ts
* Add hybridAppSettings AppProp * Unify how we pass data on both platforms * fix after merge * fix comments --------- Co-authored-by: war-in <war-in@users.noreply.github.com>
* wip * block switching when error returned * make goBack work correctly * validate code form and SignIn button works (but require further investigation) * show error when unable to switch to OD * adjust new sign-up flow * add comment --------- Co-authored-by: war-in <war-in@users.noreply.github.com>
|
FYI: It looks like translations are loaded with delay (components mount first and then we get valid translations). I'm working on a solution to speed up this process and guarantee that UI renders when at least one language is loaded. |
|
I managed to fix this issue. fixed.locale.mov |
|
Hi all, thanks for considering to remove the |
@tgolen I'm going to create a follow up issue for this. This refactor is 6+ months in the works with a F1 deadline for next week. On top of this the lazy load PR introduced issues here preventing us from shipping as we intended to this week. |
|
OK, sounds good to me. Thanks!
…On Tue, Jun 17, 2025 at 10:11 AM Jules ***@***.***> wrote:
*Julesssss* left a comment (Expensify/App#51257)
<#51257 (comment)>
I know it is a big ask to remove it, and technically it hasn't been
deprecated yet. However, it's got to be removed at some point, so it would
be nice to remove it before even deploying it. I won't press too hard
either way since I'm not the one that has to do the work.
@tgolen <https://github.com/tgolen> I'm going to create a follow up issue
for this. This refactor is 6+ months in the works with a F1 deadline for
next week. On top of this the lazy load PR introduced issues here
preventing us from shipping as we intended to this week.
—
Reply to this email directly, view it on GitHub
<#51257 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJMAB5MS3JWHIUMM6BPV4L3EA443AVCNFSM6AAAAABQMSTZW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOBQHE3TSNJVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
We have a solution to the translation issue, merging and we'll resolve any conflicts on the fix PR. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.1.69-0 🚀
|
|
For anyone noticing a regression related to these changes, we need to avoid a revert due to the scale of this and the accompanying Mobile-Expensify PR. @289Adam289, @war-in @mateuuszzzzz and myself (back Friday) will be able to help you resolve these issues. For any non-blockers, please add them here. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.1.69-0 🚀
|
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.1.69-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.1.69-3 🚀
|
Testrails Regression ChecklistThe following test cases must be verified by reviewers:
|
16 participants
Details
This PR refactors existing functionalities on mobile devices, but it's possible it's caused a regression on web or desktop, hence testing other platforms is also necessary.
Fixed Issues
$ #49844
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13284
Tests
Base information to every flow:
The flow is based on NVP
tryNewDotvalue, we have two possible scenarios to test:tryNewDotis properly setdismissed==false)Switch to Expensify Classicbuttondismissed==true)tryNewDotisundefined. This state can be achieved by having old classic account or manually settingawait NVP.set("tryNewDot", undefined);in Expenisfy classic on web.Try New Expensifybutton is no visibleMain flow:
Main flow new Account:
SAML Magic code
Use magic codeSAML single sign on
single sign-onGoogle sign-in Apple sign-in:
Both flows have different implementation depending on OS and need to be tested exhaustively
Verify that no errors or Growls appear.
2FA:
Travel, OD <-> ND switch etc
Verify that:
tryNewDotcan transition between OD and ND.Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop