Bring back new `SignInPage` by mateuuszzzzz · Pull Request #65178 · Expensify/App

mateuuszzzzz · 2025-06-30T11:08:15Z

Explanation of Change

Fixed Issues

$ #49844

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13607#pullrequestreview-2972319319

Tests

Please thoroughly test these cases, these changes have far reaching changes to authentication.

Base information to every flow:

Redirection tests apply to HybridApp, for web you should remain on the current URL

The flow is based on NVP tryNewDot value, we have two possible scenarios to test

tryNewDot is properly set

Log out from ND
Log in using any flows bellow
Verify that you end up in ND (dismissed == false)
Move to OD using Switch to Expensify Classic button
Log out from OD
Verify that you end up in ND sign in page and the transition is seamless (no bootsplash and no white screen)
Log in with the same account
Verify you end up in OD (dismissed == true)

tryNewDot is undefined. This state can be achieved by having old classic account or manually setting await NVP.set("tryNewDot", undefined); in Expenisfy classic on web.

Open app
Try to log in using preset account described above and any flow
Verify that you user is moved straight to OD and Try New Expensify button is no visible
Log out
Verify that you end up in ND sign in page and the transition is seamless (no bootsplash and no white screen)

Main flow:

Provide email
Enter magic code

Main flow new Account:

Provide new email
Press Join
Verify that onboarding starts
Verify that onboarding cannot be dismissed by pressing hardware back button.

SAML Magic code

Provide email that uses SAML
Press Use magic code
Enter magic code

SAML single sign on

Provide email that uses SAML
Press single sign-on
Login via SAML
Verify that app opens properly and not inside WebView

Domain-based login flow test

Log in using an email with the public domain.
Verify that users are able to sign in
Log in using an email with a private domain.
Verify that users are able to log in

Google sign-in Apple sign-in:

Both flows have different implementation depending on OS and need to be tested exhaustively
Verify that no errors or Growls appear.

2FA:

Log in to ND.
Add 2FA to the account
Sign out
Login again using the authenticator app

Travel, OD <-> ND switch etc
Verify that:

Travel from OD work according to [HybridApp] Allow classic experience users to use NewDot travel page #49602 (comment)
After sign-in ND share extension works properly
That changing copilot in OD/ND changes copilot in other app.
When changing copilot in ND no navigation happens
User with tryNewDot can transition between OD and ND.
Deeplinks navigate to appropriate app depending on the link
Verify that shortcuts work and navigate to app depending on where user is logged.

In addition, please run through the new test cases that were previously created for this feature.

Offline tests

N/A

QA Steps

Run the above tests
InternalQA- also run the above tests

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ScreenRecording_07-02-2025.12-12-07_1.MP4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-06-30T11:08:26Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

mateuuszzzzz · 2025-06-30T11:09:17Z

Diff will get better once we merge #64786

Julesssss

Holding on wider HybridApp signin changes

Julesssss · 2025-07-01T21:54:03Z

Hey @mateuuszzzzz could you merge main please as we have merged the sign in changes now.

melvin-bot · 2025-07-02T10:21:43Z

@JS00001 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

This reverts commit def8188.

war-in · 2025-07-03T12:40:32Z

src/Expensify.tsx

-    const isSplashVisible = splashScreenState === CONST.BOOT_SPLASH_STATE.VISIBLE;
-    const isHybridAppReady = splashScreenState === CONST.BOOT_SPLASH_STATE.READY_TO_BE_HIDDEN && isAuthenticated;
-    const shouldHideSplash = shouldInit && (CONFIG.IS_HYBRID_APP ? isHybridAppReady : isSplashVisible);
+    const shouldInit = isNavigationReady && hasAttemptedToOpenPublicRoom && !!preferredLocale && (CONFIG.IS_HYBRID_APP ? !hybridApp?.loggedOutFromOldDot : true);


I'd check if that condition is correct. After our changes, we say that the app shouldn't be init if we logged out from OldDot, right?

war-in · 2025-07-03T12:41:30Z

src/Expensify.tsx

+    const shouldHideSplash =
+        shouldInit &&
+        (CONFIG.IS_HYBRID_APP
+            ? splashScreenState === CONST.BOOT_SPLASH_STATE.READY_TO_BE_HIDDEN && (isAuthenticated || !!hybridApp?.useNewDotSignInPage)
+            : splashScreenState === CONST.BOOT_SPLASH_STATE.VISIBLE);


Let's split this logic as it's split on main currently

src/HybridAppHandler.tsx

src/components/BookTravelButton.tsx

src/components/CustomStatusBarAndBackground/index.tsx

war-in · 2025-07-03T13:21:58Z

src/libs/actions/Session/index.ts

            authPromiseResolver = null;
        }
-        if (CONFIG.IS_HYBRID_APP && session.authToken && session.authToken !== INVALID_TOKEN) {
+        if (CONFIG.IS_HYBRID_APP && session.authToken && session.authToken !== INVALID_TOKEN && isSetUpReady) {


Let's check if this additional value is still necessary

it is :/ Without it we would send old auth token to OD when we sign out from it

src/pages/ErrorPage/SessionExpiredPage.tsx

src/pages/signin/ChooseSSOOrMagicCode.tsx

war-in · 2025-07-03T13:42:31Z

src/pages/signin/SignInPage.tsx

+    useEffect(() => {
+        if (!CONFIG.IS_HYBRID_APP || !hybridApp?.loggedOutFromOldDot) {
+            return;
+        }
+        HybridAppModule.clearOldDotAfterSignOut();
+    }, [hybridApp?.loggedOutFromOldDot]);


Do we really have to do this in useEffect? 🤔
If we decide to change loggedOutFromOldDot in some other place, this logic will fire :/

How about putting this in Session/index.ts in setupNewDotAfterTransitionFromOldDot?
cc @mateuuszzzzz for thoughts

I added comment expalining why we do it here

src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.tsx

# Conflicts: # src/components/BookTravelButton.tsx # src/pages/signin/SAMLSignInPage/index.native.tsx

…eload-on-new-sign-in-page # Conflicts: # modules/hybrid-app/android/src/main/java/com/expensify/reactnativehybridapp/ReactNativeHybridApp.kt # modules/hybrid-app/ios/ReactNativeHybridApp.mm # modules/hybrid-app/src/NativeReactNativeHybridApp.ts # modules/hybrid-app/src/index.native.ts # modules/hybrid-app/src/index.ts # modules/hybrid-app/src/types.ts # src/App.tsx

github-actions · 2025-07-31T09:25:17Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-07-31T10:06:09Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #65178 Mobile-Expensify PR Expensify/Mobile-Expensify#13607.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/65178/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/65178/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/65178/NewExpensify.dmg	https://65178.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

war-in · 2025-07-31T11:29:18Z

Bugs summary:

Sign in - Unable to Log In via Google on Sign-In Page
- @Julesssss I believe you're aware of this issue. Is there anything we could do to make it work on adhoc builds? 🤔
iOS - Logout - Infinite loading when signing out
- this one is fixed: 18baf7e
- I added a comment explainig why we need initial insets

Julesssss · 2025-07-31T15:53:18Z

Thanks Marcin for fixing the second issue.

So yeah the Google SSO on AdHoc was expected, I broke that while fixing Google SSO on prod and this shouldn't block us.

Julesssss · 2025-07-31T15:54:29Z

The ESLint warning will also be left as-is. This rule will be applied with later, for now we need to complete the auth page switch.

melvin-bot · 2025-07-31T15:56:44Z

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

Julesssss · 2025-07-31T15:57:11Z

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

See here.

github-actions · 2025-08-04T19:58:42Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.1.89-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Julesssss · 2025-08-04T20:52:45Z

InternalQA
Authentication is working well. I did notice a couple of bugs that we'll need to solve though. Both only occur on Android and I opened up the magic sign-in issue for external contributors in the meantime. We do not want to revert this PR and have a couple of days to get these bugs resolved.

~~[Due for payment 2025-08-15] [Ready for payment Aug 13th] [RCA #65178] Android - stuck at magic code step of sign in #67814~~ - fixed here ✅
[Due for payment 2025-08-15] [RCA #65178] Stuck after signing out of classic on HybridApp #67812

FYI @war-in for tomorrow

github-actions · 2025-08-06T19:29:38Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.89-21 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Send hybridAppSettings via native method

bf87d42

mateuuszzzzz mentioned this pull request Jun 30, 2025

[Tracking] NewDot SignIn page on HybridApp follow up improvements #64348

Closed

Julesssss self-requested a review June 30, 2025 18:57

Julesssss requested changes Jun 30, 2025

View reviewed changes

mateuuszzzzz added 5 commits July 2, 2025 08:58

Merge branch 'main' into fix-reload-on-new-sign-in-page

e64d00a

Add log

15eed0e

Fix typo

296cb7e

Apply prettier

259a514

Add missing log in iOS turbo module

503fc0e

mateuuszzzzz marked this pull request as ready for review July 2, 2025 10:21

mateuuszzzzz requested a review from a team as a code owner July 2, 2025 10:21

melvin-bot bot requested a review from JS00001 July 2, 2025 10:21

melvin-bot bot removed the request for review from a team July 2, 2025 10:21

war-in mentioned this pull request Jul 2, 2025

Expense - Not here page opens when launching app via app shortcut #65295

Closed

8 tasks

Kicu mentioned this pull request Jul 2, 2025

Fix parsing short mentions when sending message to backend #65237

Merged

49 tasks

mateuuszzzzz added 2 commits July 3, 2025 11:58

Merge branch 'main' into fix-reload-on-new-sign-in-page

faeece6

Revert "Revert "Bring back new sign-in page""

c07874f

This reverts commit def8188.

mateuuszzzzz changed the title ~~Fix reload issues related to new SignInPage~~ Bring back new SignInPage Jul 3, 2025

Add missing import

cd42183

war-in reviewed Jul 3, 2025

View reviewed changes

Julesssss mentioned this pull request Jul 3, 2025

[$250] [HybridApp] Improvement to HybridApp TTI / NewDot authentication page #49844

Closed

This was referenced Jul 4, 2025

[Pre SignInPage] Add HYBRID_APP onyx key #65435

Merged

[HOLD] iOS - Magic link doesn't send on the first try when reopening a closed account #63593

Closed

Send hybridAppSettings via native method #65442

Merged

war-in added 2 commits July 8, 2025 16:13

Merge branch 'refs/heads/main' into fix-reload-on-new-sign-in-page

b79248d

# Conflicts: # src/components/BookTravelButton.tsx # src/pages/signin/SAMLSignInPage/index.native.tsx

fix infinite Signing out... iOS dialog

18baf7e

Julesssss added the InternalQA This pull request required internal QA label Jul 31, 2025

Julesssss approved these changes Jul 31, 2025

View reviewed changes

Julesssss merged commit 53883d3 into Expensify:main Jul 31, 2025
27 of 30 checks passed

melvin-bot bot added the Emergency label Jul 31, 2025

Julesssss removed the Emergency label Jul 31, 2025

github-actions bot mentioned this pull request Jul 31, 2025

[Due for payment 2025-08-13] Investigate workflow job failing on main: lint / ESLint check #67550

Closed

Julesssss mentioned this pull request Jul 31, 2025

[NO QA] Increase failed checks limit after large refactored Signin page #67554

Merged

51 tasks

war-in mentioned this pull request Aug 1, 2025

[$50 - RCA] Sign in-"Your session has expired" page displayed when signing in second time as new user #67605

Closed

8 tasks

github-actions bot mentioned this pull request Aug 4, 2025

Deploy Checklist: New Expensify 2025-08-04 #67808

Closed

This was referenced Aug 4, 2025

[Due for payment 2025-08-15] [Ready for payment Aug 13th] [RCA #65178] Android - stuck at magic code step of sign in #67814

Closed

[Due for payment 2025-08-15] [RCA #65178] Stuck after signing out of classic on HybridApp #67812

Closed

mitarachim mentioned this pull request Aug 5, 2025

[Due for payment 2025-09-04] [RCA #65178] iOS - App opens OD with no email ID and crashes in Settings after logging in via public room #67848

Closed

8 tasks

jponikarchuk mentioned this pull request Aug 5, 2025

[Due for payment 2025-08-15] [RCA #65178] Android - App is stuck at splash screen when relaunching app after opening login via public room #67849

Closed

8 tasks

mitarachim mentioned this pull request Aug 5, 2025

[Due for payment 2025-09-12] iOS - Login - Extra padding above "Done" row in language menu when accessed via public room #67863

Closed

8 tasks

jponikarchuk mentioned this pull request Aug 5, 2025

Android - App is stuck on splash screen when switching from ND to OD and back to ND #67939

Closed

8 tasks

MarioExpensify mentioned this pull request Aug 5, 2025

[Due for payment 2025-09-04] Android - User signed out of app when updating to '9.1.89-7' #67949

Closed

16 tasks

This was referenced Aug 6, 2025

[CP Staging] Revert "Bring back new SignInPage" #67992

Merged

[HybridApp] Migrate to NewDot sign-in page #67996

Merged

BlameGPT mentioned this pull request Aug 6, 2025

Email - The invited user redirects to the Home page instead of the created room #67920

Closed

8 tasks

Conversation

mateuuszzzzz commented Jun 30, 2025 • edited by Julesssss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Jun 30, 2025

Uh oh!

mateuuszzzzz commented Jun 30, 2025

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Jul 1, 2025

Uh oh!

melvin-bot bot commented Jul 2, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

war-in commented Jul 31, 2025

Uh oh!

Julesssss commented Jul 31, 2025

Uh oh!

Julesssss commented Jul 31, 2025

Uh oh!

Uh oh!

melvin-bot bot commented Jul 31, 2025

Uh oh!

Julesssss commented Jul 31, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

Julesssss commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mateuuszzzzz commented Jun 30, 2025 •

edited by Julesssss

Loading

Julesssss commented Aug 4, 2025 •

edited

Loading