[Pre SignInPage] Add HYBRID_APP onyx key#65435
Conversation
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@Julesssss can I get another build for testing? 🙏 |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
This comment was marked as outdated.
This comment was marked as outdated.
|
@mateuuszzzzz I also added a lint rule disallowing |
|
@dannymcclain @DylanDylann One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@dannymcclain no need for design review here, this PR is a minor part of the signin page changes. |
|
🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
ishpaul777
left a comment
There was a problem hiding this comment.
Code Lgtm! only minor comment
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-07-10.at.1.10.49.AM.movAndroid: mWeb ChromeScreen.Recording.2025-07-10.at.1.41.20.AM.moviOS: HybridApptrim.124DB961-26C8-436A-9573-72C4F8852B58.MOVtrim.5D25D699-EEAC-4931-B04D-79CE802C3C9B.MOVtrim.DE8B1BE3-C6F1-4FF6-B801-C80971D7527F.MOViOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.16.Pro.-.2025-07-10.at.01.49.15.mp4MacOS: Chrome / SafariScreen.Recording.2025-07-10.at.1.38.51.AM.movMacOS: Desktop |
|
I created an issue here to better track these changes. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.1.80-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.80-8 🚀
|
Explanation of Change
We're adding new HYBRID_APP onyx key in sign-in page PR. We decided to move this change out of the PR to keep it as small as possible.
The key will keep the most crucial hybridApp-related settings but for now, there are two keys
isClosingReactNativeAppkey indicates when the ND part is being closed and disables root status barFixed Issues
$ #65786
PROPOSAL:
Tests
<button brings you back to ODOffline tests
QA Steps
<button brings you back to ODPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.Jul.8.2025.from.Marcin.Warchol.mp4
Android: mWeb Chrome
iOS: Native
ScreenRecording_07-08-2025.12-37-41_1.MP4
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop