[HybridApp] Migrate to NewDot sign-in page

[war-in]

Explanation of Change

Another attempt to use NewDot SignInPage in HybridApp, previous PR: #65178. To be tested on iOS and Android only

Fixed Issues

$ #67949
$ #67848
$ #67949
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13646

Tests

Base information to every flow:
The flow is based on NVP tryNewDot value, we have two possible scenarios to test:

• tryNewDot is properly set

1. Log out from ND
2. Log in using any flows bellow
3. Verify that you end up in ND (dismissed == false)
4. Move to OD using Switch to Expensify Classic button
5. Log out from OD
6. Verify that you end up in ND sign in page and the transition is seamless (no bootsplash and no white screen)
7. Log in with the same account
8. Verify you end up in OD (dismissed == true)

• tryNewDot is undefined. This state can be achieved by having old classic account or manually setting await NVP.set("tryNewDot", undefined); in Expenisfy classic on web.

Open app
2. Try to log in using preset account described above and any flow
3. Verify that you user is moved straight to OD and Try New Expensify button is no visible
4. Log out
5. Verify that you end up in ND sign in page and the transition is seamless (no bootsplash and no white screen)

Main flow:

1. Provide email
2. Enter magic code

Main flow new Account:

1. Provide new email
2. Press Join
3. Verify that onboarding starts
4. Verify that onboarding cannot be dismissed by pressing hardware back button.

SAML Magic code

1. Provide email that uses SAML
2. Press Use magic code
3. Enter magic code

SAML single sign on

1. Provide email that uses SAML
2. Press single sign-on
3. Login via SAML
4. Verify that app opens properly and not inside WebView

Google sign-in / Apple sign-in:

1. Both flows have different implementation depending on OS and need to be tested exhaustively
2. Verify that no errors or Growls appear.

2FA:

1. Log in to ND.
2. Add 2FA to the account
3. Sign out
4. Login again using the authenticator app
5. Travel, OD <-> ND switch etc
6. Verify that:
7. Travel from OD work according to [HybridApp] Allow classic experience users to use NewDot travel page #49602 (comment)
8. After sign-in ND share extension works properly
9. That changing copilot in OD/ND changes copilot in other app.
10. When changing copilot in ND no navigation happens
11. User with tryNewDot can transition between OD and ND.
12. Deeplinks navigate to appropriate app depending on the link
13. Verify that shortcuts work and navigate to app depending on where user is logged.

App upgrade test (verify that user is not signed out when updating the app version from old sign in page to this one)
FOR C+s: You can build app from main (both repositories) and then switch to both branches of SignInPage PR.

QA: For this test you must install these older AdHoc builds first, then:

1. Sign in to app without new SignInPage (use old AdHoc test builds)
2. Install (update) to these AdHoc builds with SignInPage (this PR, do not delete previous app to keep local storage data)
   2.3 Reopen the app while being on NewDot, you should stay signed-in and app should be usable
   2.4 Go to OldDot (Settings -> Switch to Expensify Classic)
   2.5 Restart the app while being on OldDot, you should stay signed-in and app should be usable
   2.6 Sign out (Both sign-out from NewDot and OldDot app should be tested as separate scenarios)
   2.7 Repeat 2.1-2.5

Offline tests

QA Steps

Base information to every flow:
The flow is based on NVP tryNewDot value, we have two possible scenarios to test:

• tryNewDot is properly set

1. Log out from ND
2. Log in using any flows bellow
3. Verify that you end up in ND (dismissed == false)
4. Move to OD using Switch to Expensify Classic button
5. Log out from OD
6. Verify that you end up in ND sign in page and the transition is seamless (no bootsplash and no white screen)
7. Log in with the same account
8. Verify you end up in OD (dismissed == true)

• tryNewDot is undefined. This state can be achieved by having old classic account or manually setting await NVP.set("tryNewDot", undefined); in Expenisfy classic on web.

1. Open app
2. Try to log in using preset account described above and any flow
3. Verify that you user is moved straight to OD and Try New Expensify button is no visible
4. Log out
5. Verify that you end up in ND sign in page and the transition is seamless (no bootsplash and no white screen)
   Main flow:
6. Provide email
7. Enter magic code
   Main flow new Account:
8. Provide new email
9. Press Join
10. Verify that onboarding starts
11. Verify that onboarding cannot be dismissed by pressing hardware back button.
    SAML Magic code
12. Provide email that uses SAML
13. Press Use magic code
14. Enter magic code
    SAML single sign on
15. Provide email that uses SAML
16. Press single sign-on
17. Login via SAML
18. Verify that app opens properly and not inside WebView
    Google sign-in Apple sign-in:
    Both flows have different implementation depending on OS and need to be tested exhaustively
    Verify that no errors or Growls appear.
    2FA:
19. Log in to ND.
20. Add 2FA to the account
21. Sign out
22. Login again using the authenticator app
    Travel, OD <-> ND switch etc
    Verify that:
23. Travel from OD work according to [HybridApp] Allow classic experience users to use NewDot travel page #49602 (comment)
24. After sign-in ND share extension works properly
25. That changing copilot in OD/ND changes copilot in other app.
26. When changing copilot in ND no navigation happens
27. User with tryNewDot can transition between OD and ND.
28. Deeplinks navigate to appropriate app depending on the link
29. Verify that shortcuts work and navigate to app depending on where user is logged.

App upgrade test (verify that user is not signed out when updating the app version from old sign in page to this one)
FOR QAs: If you work on adhoc builds you can try to use adhoc from other PR and then install adhoc build from this PR to simulate app version update.

1. Sign in to app without new SignInPage
2. Install app with SignInPage (this PR, do not delete previous app to keep local storage data)
   2.3 Restart the app while being on NewDot, you should stay signed-in and app should be usable
   2.4 Go to OldDot (Settings -> Switch to Expensify Classic)
   2.5 Restart the app while being on OldDot, you should stay signed-in and app should be usable
   2.6 Sign out (Both sign-out from NewDot and OldDot app should be tested as separate scenarios)
   2.7 Repeat 2.1-2.5

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[mateuuszzzzz]

I found one issue today related to #67920

Navigation is fixed, but app crashes due to FlatList invariant violation. It might be that we render FlatList when some data is not loaded and we end up with number of items in array varying between 1 and 2 due to filtering (it repeats a few times). I tested it on debug builds.

I'm already investigating the issue and trying to fix this.

[github-actions]

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

[Julesssss]

Testing well so far 👍

[mateuuszzzzz]

Hi @Julesssss, after merge of the latest main, issues I mentioned are not reproducible. We can proceed further with this PR.

[github-actions]

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[war-in]

That's strange 🤔 I'm still able to reproduce the issue but only on the adhoc build
Will try to investigate it further

[war-in]

May be related to this slack thread

[github-actions]

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #67996 Mobile-Expensify PR Expensify/Mobile-Expensify#13646.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/67996/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/67996/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/67996/NewExpensify.dmg	https://67996.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[Julesssss]

• Upgrade, signout, signin flows working ✅
• Android notification prompt ✅
• Magic code bug resolved ✅
• Switch App experiences working ✅

Feature working nicely on both platforms, lets get it merged 🤩

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.1.99-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[IuliiaHerets]

@war-in Is the PR valid to be checked on Web?

5. Log out We have performed those steps, but we end up in OD sign-in pagerom OD
6. Verify that you end up in ND sign in page and the transition is seamless (no bootsplash and no white screen)

We have performed those steps, but we end up in OD sign-in page

bandicam.2025-08-27.14-46-58-063.1.mp4

[war-in]

@IuliiaHerets I don't think this PR should be checked on web
We developed this with HybridApp in mind and don't have access to OldDot web so the only platforms that will work are iOS native and Android native

Sorry for missing that in the QA steps section 😕

[OSBotify]

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.99-11 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅