Wallet empty state by koko57 · Pull Request #67274 · Expensify/App

koko57 · 2025-07-28T16:19:49Z

Explanation of Change

Fixed Issues

$ #66072
PROPOSAL: -

Tests

Go to Wallet
Verify that Bank accounts section description is: Add a bank account to make or receive payments.
If you have a business and personal bank account they should be displayed in separate sections: Personal bank accounts and Business bank accounts.
If you only have one bank account or only personal or only business bank accounts there should be no section headers.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-07-28T16:19:56Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2025-07-29T03:29:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

simulator_screenshot_639F448D-9F04-40B9-9107-CF25813A786B

iOS: mWeb Safari

simulator_screenshot_7CA8DBB3-595E-4DB4-88FE-E99A26FCE3C6

MacOS: Chrome / Safari

MacOS: Desktop

dominictb · 2025-07-29T03:46:23Z

For this point in the design doc:

We’ll add new Personal bank account and Business bank account sub-sections on Wallet if you have at least one personal and business bank account.

@joekaufmanexpensify What if I have (a) business bank account(s) but no personal one; and vice versa: (a) personal one(s) but no business account? Should we show them in their own section with corresponding title? Or must they have both types in order to show in sections?

dominictb · 2025-07-29T03:58:49Z

@koko57 We have conflicts & lints BTW.

koko57 · 2025-07-29T07:10:34Z

For this point in the design doc:

We’ll add new Personal bank account and Business bank account sub-sections on Wallet if you have at least one personal and business bank account.

@joekaufmanexpensify What if I have (a) business bank account(s) but no personal one; and vice versa: (a) personal one(s) but no business account? Should we show them in their own section with corresponding title? Or must they have both types in order to show in sections?

I will fix it. I think we don't want to show any header (section) when we only have one bank account

koko57 · 2025-07-29T08:00:11Z

@dominictb it is strange - is it displayed for you like this with the header? Section headers should be only visible when there is a business bank account and a personal bank account. an there should be always 2 headers

koko57 · 2025-07-29T08:05:04Z

conflicts resolved

dominictb · 2025-07-29T09:35:44Z

Oh sorry for not clarifying earlier. The screenshot was manually tweak for demonstration purpose. Currently it only shows sections if we have both types of account.

koko57 · 2025-07-29T09:46:38Z

@dominictb aaaa ok, thanks for clarifying! If I understood it correctly we don't want to show any header when only one bank account (or several but of one type) is displayed, but waiting for confirmation from @joekaufmanexpensify

joekaufmanexpensify · 2025-07-29T14:20:05Z

@joekaufmanexpensify What if I have (a) business bank account(s) but no personal one; and vice versa: (a) personal one(s) but no business account? Should we show them in their own section with corresponding title? Or must they have both types in order to show in sections?

The latter. We will only show the section headers if you have both personal and business bank account(s). If you only have personal bank accounts (one or multiple), then no section headers. Same with one or multiple business bank accounts. But as soon as you have at least one of both types, we show them.

The thinking was the section headers are overkill with only one type of bank account, since the user won't need to differentiate or really have a question about what type they are.

LMK if any more Q's!

src/languages/es.ts

dominictb

Beside the above update, everything works so well.

Co-authored-by: Dominic <165644294+dominictb@users.noreply.github.com>

joekaufmanexpensify · 2025-07-29T15:04:05Z

Sweet. Let's test on adhoc once you review @srikarparsi too 👍

github-actions · 2025-07-30T05:18:16Z

🚧 @srikarparsi has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-07-30T06:07:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #67274.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/67274/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/67274/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/67274/NewExpensify.dmg	https://67274.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

joekaufmanexpensify · 2025-07-30T14:29:46Z

Tested! It worked well. Good with me to proceed @srikarparsi 👍

srikarparsi · 2025-07-30T18:11:37Z

Awesome merging!

shubham1206agra · 2025-07-31T09:21:27Z

src/pages/settings/Wallet/PaymentMethodList.tsx

+                </OfflineWithFeedback>
+            );
+        },
        [


@koko57 You missed missed dependency here.

@srikarparsi Please consider this as regression and penalise C+ accordingly.

Hey @shubham1206agra, can you link the issue this caused please?

There was no issue. But it caused lint failure when another PR was merged #67435.

It looks like that is a different lint error? The one I see is

React Hook useCallback has missing dependencies: 'styles.mb1' and 'styles.mt4'. Either include them or remove the dependency array.

Is that the one you are referencing?

github-actions · 2025-07-31T12:18:41Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.1.88-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-08-04T19:25:36Z

🚀 Deployed to production by https://github.com/grgia in version: 9.1.88-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

koko57 added 4 commits July 24, 2025 15:36

feat: change the Bank Account section description

797652e

feat: add translations for section titles

f45b404

Merge branch 'main' into feat/66072-wallet-empty-state

e411588

feat: show bank account in sections

fd469b9

koko57 requested a review from a team as a code owner July 28, 2025 16:19

melvin-bot bot requested review from dominictb and removed request for a team July 28, 2025 16:19

koko57 mentioned this pull request Jul 28, 2025

[Due for payment 2025-08-13] [Due for payment 2025-08-11] [Better BBA] Wallet Empty State and Sub-Sections #66072

Closed

fix: resolve conflicts

1baffb9

fix: deps

9718a50

dominictb suggested changes Jul 29, 2025

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

dominictb approved these changes Jul 29, 2025

View reviewed changes

melvin-bot bot requested a review from srikarparsi July 29, 2025 15:01

fix: apply suggested change

83e8136

Co-authored-by: Dominic <165644294+dominictb@users.noreply.github.com>

srikarparsi approved these changes Jul 30, 2025

View reviewed changes

srikarparsi added the Ready To Build label Jul 30, 2025

srikarparsi merged commit 35b81ab into Expensify:main Jul 30, 2025
18 checks passed

shubham1206agra reviewed Jul 31, 2025

View reviewed changes

github-actions bot mentioned this pull request Jul 31, 2025

Deploy Checklist: New Expensify 2025-07-31 #67499

Closed

90 tasks

Julesssss mentioned this pull request Aug 19, 2025

[HybridApp] Migrate to NewDot sign-in page #67996

Merged

49 tasks

gijoe0295 mentioned this pull request Oct 8, 2025

[Due for payment 2025-11-06] [$250] Wallet - Blank popup on selecting Transfer balance option when BA has Business bank account #71437

Closed

8 tasks

Conversation

koko57 commented Jul 28, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 28, 2025

Uh oh!

dominictb commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dominictb commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koko57 commented Jul 29, 2025

Uh oh!

koko57 commented Jul 29, 2025

Uh oh!

koko57 commented Jul 29, 2025

Uh oh!

dominictb commented Jul 29, 2025

Uh oh!

koko57 commented Jul 29, 2025

Uh oh!

joekaufmanexpensify commented Jul 29, 2025

Uh oh!

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 30, 2025

Uh oh!

github-actions bot commented Jul 30, 2025

Uh oh!

joekaufmanexpensify commented Jul 30, 2025

Uh oh!

srikarparsi commented Jul 30, 2025

Uh oh!

Uh oh!

shubham1206agra Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

srikarparsi Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

srikarparsi Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Jul 31, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

github-actions bot commented Aug 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dominictb commented Jul 29, 2025 •

edited

Loading

dominictb commented Jul 29, 2025 •

edited

Loading

dominictb commented Jul 29, 2025 •

edited

Loading