Add Track expense follow up questions as rows in details view of a Tracked expense by twilight2294 · Pull Request #51951 · Expensify/App

twilight2294 · 2024-11-04T12:48:03Z

Explanation of Change

Add the track expense options into the details view of a tracked expense. We currently use the details view of an expense to surface other actions like Delete or Download, so this is a natural place to include the other missing track options. This will then allow users to go back to their tracked expenses and easily send them or share them when they wish

Fixed Issues

$ #51358
PROPOSAL: #51358 (comment)

Tests

Go to self DM, create a Track expense
Open report > Click header
Verify that you see the 3 options : Submit it to someone, Categorize it, Share it with my accountant
Click on Submit it to someone, submit the expense to someone.
Verify that you are able to submit the expense

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Go to self DM, create a Track expense
Open report > Click header
Verify that you see the 3 options : Submit it to someone, Categorize it, Share it with my accountant
Click on Submit it to someone, submit the expense to someone.
Verify that you are able to submit the expense

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-04.at.6.31.44.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-11-04.at.6.40.06.PM.mov

iOS: Native

Screen.Recording.2024-11-04.at.7.05.10.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-11-04.at.6.37.49.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-04.at.6.20.51.PM.mov

MacOS: Desktop

Screen.Recording.2024-11-04.at.6.29.54.PM.mov

melvin-bot · 2024-11-04T12:48:09Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2024-11-05T18:06:27Z

src/pages/ReportDetailsPage.tsx

+    const whisperAction = ReportActionsUtils.getTrackExpenseActionableWhisper(iouTransactionID, moneyRequestReport?.reportID ?? '0');
+    const actionableWhisperReportActionID = whisperAction?.reportActionID ?? '0';


I think we can define these 2 variables inside if (isTrackExpenseReport) condition below https://github.com/Expensify/App/pull/51951/files#diff-409b0e2fb439856e9897b808014031ce244a427d116ed30f37a2e0117599adc4R380 for optimization.

aimane-chnaif

Code looks good

aimane-chnaif · 2024-11-05T21:38:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

mchrome.mp4

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

NJ-2020 · 2024-11-05T22:14:59Z

@aimane-chnaif Can you explain please why you accept him using my code from my proposal ?, since I proposed first using this solution

cc: @thienlnam

aimane-chnaif · 2024-11-05T22:23:35Z

@NJ-2020 No need to provide full code diff in proposal stage, which can be same as final code from assigned contributor.
We had similar cases in the past: (internal discussions)
https://expensify.slack.com/archives/C02NK2DQWUX/p1718050494803419
https://expensify.slack.com/archives/C02NK2DQWUX/p1722982343070039
It's case-by-case.

@twilight2294 you exactly used @NJ-2020's code, right? If so, we can split bounty.
Note: please be honest in order not to break rule #2

NJ-2020 · 2024-11-05T22:28:34Z

@aimane-chnaif I cannot access those slack links
The key point of selecting the proposals is where we get the action id, transaction id etc
Inside his proposal he mentioned we can get from report header instead of using getTrackExpenseActionableWhisper function here

And also I proposed the first solution using getTrackExpenseActionableWhisper
Thanks

twilight2294 · 2024-11-06T04:02:47Z

No need to provide full code diff in proposal stage, which can be same as final code from assigned contributor.
We had similar cases in the past: (internal discussions)

@aimane-chnaif I agree with this, we also have this in our contributor guidelines:

any information provided may not necessarily lead to you getting hired for that issue or compensated in any way.

@thienlnam please merge this PR when you find time

OSBotify · 2024-11-06T16:28:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-07T13:09:32Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.59-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-11T18:15:07Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.59-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

ikevin127 · 2024-11-22T23:01:19Z

src/pages/ReportDetailsPage.tsx

            });
        }

+        if (isTrackExpenseReport) {


This check caused the following issue:

[HOLD for payment 2024-11-29] [$250] Track expense - Options are still present in thread details after the expense is deleted #52628

because it didn't account for !isDeletedParentAction, which was fixed in PR #52786.

allroundexperts · 2024-11-28T23:32:02Z

src/pages/ReportDetailsPage.tsx

Adding this exposed #52239. More thorough testing on mobile might have resulted in a fix.

hungvu193 · 2025-03-10T07:19:20Z

src/pages/ReportDetailsPage.tsx

+            const whisperAction = ReportActionsUtils.getTrackExpenseActionableWhisper(iouTransactionID, moneyRequestReport?.reportID ?? '0');
+            const actionableWhisperReportActionID = whisperAction?.reportActionID ?? '0';
+            items.push({
+                key: CONST.REPORT_DETAILS_MENU_ITEM.SETTINGS,


Each item should have a unique key to avoid such bug.
More info:
#57531 (comment)

add whispers for track expenses

f9e9afd

twilight2294 requested a review from a team as a code owner November 4, 2024 12:48

melvin-bot bot requested review from aimane-chnaif and removed request for a team November 4, 2024 12:48

twilight2294 added 3 commits November 4, 2024 18:27

fix lint

609b704

add missing dependency

d002395

Merge branch 'Expensify:main' into patch-5

f4334f1

aimane-chnaif reviewed Nov 5, 2024

View reviewed changes

twilight2294 added 3 commits November 6, 2024 01:40

rearrange variables

969090a

fix dependency error

c12db43

Merge branch 'Expensify:main' into patch-5

b3cf82f

aimane-chnaif approved these changes Nov 5, 2024

View reviewed changes

melvin-bot bot requested a review from thienlnam November 5, 2024 22:23

thienlnam approved these changes Nov 6, 2024

View reviewed changes

thienlnam merged commit 4aaf2d7 into Expensify:main Nov 6, 2024

github-actions bot mentioned this pull request Nov 7, 2024

Deploy Checklist: New Expensify 2024-11-07 #52178

Closed

60 tasks

mkzie2 mentioned this pull request Nov 11, 2024

[HOLD for payment 2024-11-28] [$250] Search - Search icon is not responsive after sharing expense with accountant and return to LHN #52239

Closed

8 tasks

melvin-bot bot mentioned this pull request Nov 11, 2024

[HOLD for payment 2024-11-18] [$500] Add Track expense follow up questions as rows in details view of a Tracked expense #51358

Closed

ikevin127 reviewed Nov 22, 2024

View reviewed changes

allroundexperts reviewed Nov 28, 2024

View reviewed changes

src/pages/ReportDetailsPage.tsx

Copy link

Contributor

allroundexperts Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this exposed #52239. More thorough testing on mobile might have resulted in a fix.

hungvu193 reviewed Mar 10, 2025

View reviewed changes

		const whisperAction = ReportActionsUtils.getTrackExpenseActionableWhisper(iouTransactionID, moneyRequestReport?.reportID ?? '0');
		const actionableWhisperReportActionID = whisperAction?.reportActionID ?? '0';

Conversation

twilight2294 commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 4, 2024

Uh oh!

aimane-chnaif Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

twilight2294 Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

NJ-2020 commented Nov 5, 2024

Uh oh!

aimane-chnaif commented Nov 5, 2024

Uh oh!

NJ-2020 commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twilight2294 commented Nov 6, 2024

Uh oh!

OSBotify commented Nov 6, 2024

Uh oh!

github-actions bot commented Nov 7, 2024

Uh oh!

github-actions bot commented Nov 11, 2024

Uh oh!

ikevin127 Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

allroundexperts Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

hungvu193 Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

twilight2294 commented Nov 4, 2024 •

edited

Loading

aimane-chnaif Nov 5, 2024 •

edited

Loading

aimane-chnaif left a comment •

edited

Loading

aimane-chnaif commented Nov 5, 2024 •

edited

Loading

NJ-2020 commented Nov 5, 2024 •

edited

Loading