Fix - Submit expense RHP doesn't include workspaces from Track flow by FitseTLT · Pull Request #52061 · Expensify/App

FitseTLT · 2024-11-05T16:48:20Z

Details

Fixed Issues

$ #51552
PROPOSAL: #51552 (comment)

Tests

Track any type of expense
Press submit to someone button of the whisper action
Search for workspaces and verify that they appear in the participants list and you can submit the expense

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

2025-01-22.01-30-57.mp4

iOS: Native

2025-01-21.23-47-42.mp4

iOS: mWeb Safari

2025-01-21.23-49-49.mp4

MacOS: Chrome / Safari

2025-01-22.00-20-40.mp4

MacOS: Desktop

2025-01-22.00-19-42.mp4

melvin-bot · 2024-11-05T16:48:25Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2024-11-06T08:57:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-31.at.14.16.36.android.mp4

Android: mWeb Chrome

Screen.Recording.2025-01-31.at.14.21.17.mov

iOS: Native

Screen.Recording.2025-01-23.at.21.33.41.ios.mov

iOS: mWeb Safari

Screen.Recording.2025-01-23.at.21.35.40.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-23.at.17.36.44.web.mov

MacOS: Desktop

Screen.Recording.2025-01-23.at.17.42.56.desktop.mov

hoangzinh · 2024-11-06T09:24:47Z

Bug 1: Unable to submit Expense to workspace from Track flow

Track an expense
Click "Submit it to someone"
Chose any workspace
=> BE returns "Invalid ReportID '0' for the report store"

Screen.Recording.2024-11-06.at.16.20.03.mov

@FitseTLT are you facing same experience as me? If yes can you help to check whether it's a FE or BE issue? I suspect it might be related to those request params

FitseTLT · 2024-11-06T14:47:27Z

Bug 1: Unable to submit Expense to workspace from Track flow

Track an expense

Click "Submit it to someone"

Chose any workspace
=> BE returns "Invalid ReportID '0' for the report store"

Screen.Recording.2024-11-06.at.16.20.03.mov
@FitseTLT are you facing same experience as me? If yes can you help to check whether it's a FE or BE issue? I suspect it might be related to those request params

{
    "jsonCode": 402,
    "message": "Invalid ReportID '0' for the report store",
    "requestID": "8de5cdfc9fe05453-JIB",
    "onyxData": []
}

Yeah @hoangzinh you are right but I think it is a BE bug

After dismissing the error and refreshing BTW the expense will appear

When it appears it shows a negative value this is because the modifiedAmount is set to positive amount and by default we expect a negative amount for expense reports but I suspect CONVERT_TRACKED_EXPENSE_TO_REQUEST is expecting only creating IOU's which are created for DM's. But now that we are allowing the converting of track to apply for workspaces too (that means it is ought to create an expense report not iou report) we need to make the necessary changes in BE.
I have tried to debug by comparing the params for submiting to workspace, converting tracked expenses for non-workspace (which works perfect) and I haven't seen any param we are lacking.
Only for submitting to a workspace I have observed that we send debtor info instead of payer info

App/src/libs/actions/IOU.ts

Lines 3660 to 3662 in d6f58b0

    
           const parameters: RequestMoneyParams = { 
        
               debtorEmail: payerEmail, 
        
               debtorAccountID: payerAccountID,

and I have tried to send that param for CONVERT_TRACKED_EXPENSE_TO_REQUEST but the same error occurs.

@luacmartins We need your help on this ^ one. Thx.

luacmartins · 2024-11-06T18:12:15Z

@thienlnam can you confirm if ConvertTrackedExpenseToRequest supports the case for converting from track to workspace request?

thienlnam · 2024-11-06T18:28:18Z

No, there probably need to be some additional changes made to support that use case

hoangzinh · 2024-11-07T01:34:55Z

@FitseTLT thank you so much for your thoughtful investigation.

luacmartins · 2024-11-07T15:39:48Z

@thienlnam do you think you could work on the needed Auth changes since you're familiar with the track flow?

thienlnam · 2024-11-07T18:49:16Z

I really don't have the capacity to take on that kind of change right now unfortunately

hoangzinh · 2024-11-13T09:37:42Z

@luacmartins should we find another internal engineer to help with this PR?

luacmartins · 2024-11-13T19:30:16Z

Yea, I currently don't have the bandwidth to take this. I'll post it internally and see if we get anyone to work on it.

hoangzinh · 2024-12-02T07:56:08Z

Hi @luacmartins let us know if you have any updates on it

luacmartins · 2024-12-02T16:47:01Z

No updates yet. Nobody volunteered 😞

FitseTLT · 2025-01-21T22:40:11Z

@hoangzinh You can proceed with the review now 👍

src/libs/actions/IOU.ts

luacmartins

Code is looking good. Only issue that I noticed is that the report preview doesn't update the correct total after submitting an expense

Screen.Recording.2025-01-27.at.12.20.54.PM.mov

luacmartins · 2025-01-28T16:56:57Z

@FitseTLT let's address my comment above. @hoangzinh did you notice any other issues while testing the PR?

FitseTLT · 2025-01-28T22:59:01Z

@luacmartins The behaviour is a bit different in my case. The submit it action properly sets the expense report's total but the openReport API called after AddTrackedExpenseToPolicy API resets back to some other value and the report preview changes after a while as you can see in my vid but from my investigation the same behaviour doesn't occur for submit to a dm and OpenReport called after ConvertTrackedExpense API in that case sets the iou report to the correct total
Don't you think the openReport API's behavior is buggy?

2025-01-29.01-41-27.mp4

hoangzinh · 2025-01-29T13:51:33Z

It's weird that I'm unable to reproduce above issue

Screen.Recording.2025-01-29.at.20.48.14.mov

hoangzinh · 2025-01-29T13:52:53Z

@hoangzinh did you notice any other issues while testing the PR?

@luacmartins So far so good to me except for the warning log above

FitseTLT · 2025-01-29T13:54:08Z

@hoangzinh did you notice any other issues while testing the PR?

@luacmartins So far so good to me except for the warning log above

But I fixed that @hoangzinh Is it still reproducible?

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

hoangzinh · 2025-01-29T14:23:08Z

@hoangzinh did you notice any other issues while testing the PR?

@luacmartins So far so good to me except for the warning log above

But I fixed that @hoangzinh Is it still reproducible?

Ah nope, It's no longer reproducible

luacmartins

@luacmartins The behaviour is a bit different in my case. The submit it action properly sets the expense report's total but the openReport API called after AddTrackedExpenseToPolicy API resets back to some other value and the report preview changes after a while as you can see in my vid but from my investigation the same behaviour doesn't occur for submit to a dm and OpenReport called after ConvertTrackedExpense API in that case sets the iou report to the correct total
Don't you think the openReport API's behavior is buggy?

I think the issue is that we're calling addTrackedExpenseToPolicy without the reimbursable param set to true. The API default is false, so the new request is always treated as non-reimbursable. When I updated your branch to send the param, things seem to work correctly

FitseTLT · 2025-01-30T12:17:09Z

@luacmartins The behaviour is a bit different in my case. The submit it action properly sets the expense report's total but the openReport API called after AddTrackedExpenseToPolicy API resets back to some other value and the report preview changes after a while as you can see in my vid but from my investigation the same behaviour doesn't occur for submit to a dm and OpenReport called after ConvertTrackedExpense API in that case sets the iou report to the correct total
Don't you think the openReport API's behavior is buggy?

I think the issue is that we're calling addTrackedExpenseToPolicy without the reimbursable param set to true. The API default is false, so the new request is always treated as non-reimbursable. When I updated your branch to send the param, things seem to work correctly

@luacmartins I passed reimbursable param as true for addTrackedExpenseToPolicy 👍

luacmartins · 2025-01-30T15:44:00Z

Nice! @hoangzinh let's give this another round of review

hoangzinh

LGTM

luacmartins

LGTM

github-actions · 2025-02-03T23:33:15Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-06T21:56:06Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-02-06T22:37:57Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

QichenZhu · 2025-11-26T06:36:17Z

src/pages/iou/request/step/IOURequestStepConfirmation.tsx

                    linkedTrackedExpenseReportAction: transaction.linkedTrackedExpenseReportAction,
                    linkedTrackedExpenseReportID: transaction.linkedTrackedExpenseReportID,
+                    waypoints: Object.keys(transaction.comment?.waypoints ?? {}).length ? getValidWaypoints(transaction.comment?.waypoints, true) : undefined,
+                    customUnitRateID,


Sending customUnitRateID when the expense is not a distance request caused an error. We fixed this by sending it conditionally.

include workspaces as participants for submit a tracked expense

e3273dd

FitseTLT requested a review from a team as a code owner November 5, 2024 16:48

melvin-bot bot requested review from hoangzinh and removed request for a team November 5, 2024 16:48

FitseTLT added 2 commits November 5, 2024 19:52

remove unnecessary import

4fc8e4b

remove unnecessary code

d6f58b0

FitseTLT mentioned this pull request Nov 8, 2024

Unable to submit distance expense to workspace when it is created from actionable whisper #52249

Closed

8 tasks

FitseTLT added 2 commits January 10, 2025 00:06

Merge branch 'main' into fix-include-workspaces-in-submit-via-track-flow

c377d1c

Merge branch 'main' into fix-include-workspaces-in-submit-via-track-flow

6377e5f

luacmartins self-requested a review January 20, 2025 15:34

FitseTLT added 3 commits January 21, 2025 17:18

implemented add tracked expense to policy

63868b7

fix lint

91a0373

Merge branch 'main' into fix-include-workspaces-in-submit-via-track-flow

9583b1d

hoangzinh mentioned this pull request Jan 22, 2025

[Due for payment 2025-02-13] [$250] Submit expense RHP doesn't include workspaces from Track flow #51552

Closed

hoangzinh reviewed Jan 22, 2025

View reviewed changes

src/libs/actions/IOU.ts Show resolved Hide resolved

luacmartins reviewed Jan 22, 2025

View reviewed changes

src/libs/actions/IOU.ts Outdated Show resolved Hide resolved

src/libs/actions/IOU.ts Show resolved Hide resolved

luacmartins reviewed Jan 27, 2025

View reviewed changes

Merge branch 'main' into fix-include-workspaces-in-submit-via-track-flow

2d4c3b1

hoangzinh reviewed Jan 29, 2025

View reviewed changes

src/pages/iou/request/step/IOURequestStepConfirmation.tsx Outdated Show resolved Hide resolved

minor fix

2e04450

FitseTLT requested a review from hoangzinh January 29, 2025 15:28

luacmartins self-requested a review January 29, 2025 16:49

luacmartins reviewed Jan 29, 2025

View reviewed changes

passed reimursable param

e8d2b20

hoangzinh approved these changes Jan 31, 2025

View reviewed changes

melvin-bot bot requested a review from luacmartins January 31, 2025 07:26

luacmartins approved these changes Jan 31, 2025

View reviewed changes

luacmartins merged commit 0b969c8 into Expensify:main Jan 31, 2025
15 checks passed

This was referenced Jan 31, 2025

Investigate workflow job failing on main: test / test (job 2) #56198

Closed

Investigate workflow job failing on main: confirmPassingBuild #56199

Closed

Deploy Checklist: New Expensify 2025-02-03 #56280

Closed

IuliiaHerets mentioned this pull request Feb 4, 2025

Expense details - Fix issues message is displayed on an expense with no violations #56318

Closed

8 tasks

Beamanator mentioned this pull request Feb 4, 2025

Track expense when submitted to the workspace shows "owes" in preview and "tracking" in LHN #56346

Closed

8 tasks

QichenZhu reviewed Nov 26, 2025

View reviewed changes

QichenZhu mentioned this pull request Nov 26, 2025

[Due for payment 2025-11-26] [$250] Expense - Error when submitting expense from self DM to workspace with instant submission #73847

Closed

8 tasks

Conversation

FitseTLT commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 5, 2024

Uh oh!

hoangzinh commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Nov 6, 2024

Uh oh!

FitseTLT commented Nov 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Nov 6, 2024

Uh oh!

thienlnam commented Nov 6, 2024

Uh oh!

hoangzinh commented Nov 7, 2024

Uh oh!

luacmartins commented Nov 7, 2024

Uh oh!

thienlnam commented Nov 7, 2024

Uh oh!

hoangzinh commented Nov 13, 2024

Uh oh!

luacmartins commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoangzinh commented Dec 2, 2024

Uh oh!

luacmartins commented Dec 2, 2024

Uh oh!

FitseTLT commented Jan 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Jan 28, 2025

Uh oh!

FitseTLT commented Jan 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hoangzinh commented Jan 29, 2025

Uh oh!

hoangzinh commented Jan 29, 2025

Uh oh!

FitseTLT commented Jan 29, 2025

Uh oh!

Uh oh!

hoangzinh commented Jan 29, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented Jan 30, 2025

Uh oh!

luacmartins commented Jan 30, 2025

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 3, 2025

Uh oh!

FitseTLT commented Nov 5, 2024 •

edited

Loading

hoangzinh commented Nov 6, 2024 •

edited

Loading

FitseTLT commented Nov 6, 2024 •

edited

Loading

luacmartins commented Nov 13, 2024 •

edited

Loading

FitseTLT commented Jan 28, 2025 •

edited

Loading