Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room by c3024 · Pull Request #52314 · Expensify/App

c3024 · 2024-11-11T15:16:30Z

Explanation of Change

This PR moves the onboarding tasks to #admins room.

Fixed Issues

$ #51443
PROPOSAL: NA

Tests

Logon to ND with a new account.
Click on "Manage my team's expenses" intent on the onboarding flow and complete the onboarding.
Verify that the onboarding tasks show up in the #admins room.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

guideAndroid.mp4

Android: mWeb Chrome

Screenrecorder-2024-11-26-14-13-37-829.mp4

iOS: Native

guideiOS.mp4

iOS: mWeb Safari

guideiOSmWeb-compressed.mp4

MacOS: Chrome / Safari

guideChrome.mp4

MacOS: Desktop

guideDesktop.mp4

c3024 · 2024-11-12T16:32:04Z

moveTasksToAdminsRoom.mp4

yuwenmemon · 2024-11-12T18:45:26Z

src/libs/actions/Report.ts

    const integrationName = userReportedIntegration ? CONST.ONBOARDING_ACCOUNTING_MAPPING[userReportedIntegration] : '';
-    const actorAccountID = CONST.ACCOUNT_ID.CONCIERGE;
-    const targetChatReport = ReportUtils.getChatByParticipants([actorAccountID, currentUserAccountID]);
+    const actorAccountID = engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM ? CONST.ACCOUNT_ID.QA_GUIDE : CONST.ACCOUNT_ID.CONCIERGE;


We don't use this, as discussed here https://expensify.slack.com/archives/C07HPDRELLD/p1731436691482209?thread_ts=1730777288.450589&cid=C07HPDRELLD

These are required for generating optimistic actions.

However, I will remove it from the params passed to CompleteGuidedSetup if it is not used in the backend.

Removing this from the params of the API request pushes the "Here are some important tasks" message generated from frontend below the tasks for some reason.

This reverts commit c0ee29f.

melvin-bot · 2024-11-19T06:35:17Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2024-11-19T05:59:59Z

src/CONST.ts

        NOTIFICATIONS: Number(Config?.EXPENSIFY_ACCOUNT_ID_NOTIFICATIONS ?? 11665625),
        PAYROLL: Number(Config?.EXPENSIFY_ACCOUNT_ID_PAYROLL ?? 9679724),
        QA: Number(Config?.EXPENSIFY_ACCOUNT_ID_QA ?? 3126513),
+        QA_GUIDE: Number(Config?.EXPENSIFY_ACCOUNT_ID_QA_GUIDE ?? 14365522),


This seems to be not a problem anymore. CreateWorkspace does not still return a personal detail for qa.guide. So, I retained this for the optimistic detail update.

We can use Concierge or currentUserAccountID instead of qa.guide for the optimistic report action generation. Backend overwrites these with qa.guide as the actor.

Can you try to use the guide's details that are sent along with their intro message following the call to CreatePolicy earlier in the guided setup flow?

When I checked this last time, CreateWorkspace was not returning qa.guide details. Let me check now again.

@yuwenmemon

CompleteGuidedSetup returns the assigned guide details. These optimistic task report actions etc. are created just after clicking on the accounting step and the assigned guide details are not available at that time.

The sender appears for the tasks as qa.guide briefly before they are replaced with the actual guide details sent in the response for CompleteGuidedSetup.

guideDetailOnCompleteGuidedSetup.mov

Look closer at that CreateWorkspace response. You should see that you have the email of the assigned guide:

Please do not use the qa.guide account as a placeholder. It is an internal testing account and should never be seen by the end user.

c3024 · 2024-11-19T06:05:51Z

src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx


+    const [allPersonalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST);
+
+    const setOptimticQAGuidePersonalDetail = () => {


This too is for the optimistic generation of report actions because CreateWorkspace's response still does not have the personal detail value for qa.guide. This can be omitted if we use Concierge or currentUserAccountID as the actor for the optimistic report actions. The actor is overwritten with qa.guide in backend's response.

c3024 · 2024-11-19T06:34:46Z

src/libs/actions/Report.ts

    const integrationName = userReportedIntegration ? CONST.ONBOARDING_ACCOUNTING_MAPPING[userReportedIntegration] : '';
-    const actorAccountID = CONST.ACCOUNT_ID.CONCIERGE;
-    const targetChatReport = ReportUtils.getChatByParticipants([actorAccountID, currentUserAccountID]);
+    const actorAccountID = engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM ? CONST.ACCOUNT_ID.QA_GUIDE : CONST.ACCOUNT_ID.CONCIERGE;


Removing this from the params of the API request pushes the "Here are some important tasks" message generated from frontend below the tasks for some reason.

jjcoffee · 2024-11-19T10:51:42Z

@c3024 Is this ready for testing online or should I only be testing offline for now?

c3024 · 2024-11-19T11:06:30Z

This is ready for testing online too!

c3024 · 2024-11-26T09:59:21Z

@yuwenmemon
Thank you! Removed the QA guide placeholders. Now, using the guide details sent.

@jjcoffee
Uploaded all videos.

jjcoffee · 2024-11-26T15:49:35Z

I guess the only thing outstanding now is waiting for the BE change to accept whatever we send from FE to avoid duplication?

This will change shortly, and we'll send the updated message reflected in the mocks.

yuwenmemon · 2024-11-26T18:47:37Z

Let's send only the tasks in order to not have duplicates. Let the guide message come from the backend.

jjcoffee · 2024-11-27T09:07:27Z

src/components/LHNOptionsList/OptionRowLHN.tsx

+    const [introSelected] = useOnyx(ONYXKEYS.NVP_INTRO_SELECTED);
+    const session = useSession();
+
+    // A guide is assigned to the user if they choose the 'MANAGE_TEAM' onboarding option, except for users with emails containing '+'.


@c3024 I was thinking of something a bit more concise like "Guides are assigned for the MANAGE_TEAM onboarding action, except for emails that have +.". I think the rest is self-explanatory/easy to understand from a quick read of the code.

jjcoffee · 2024-11-27T09:08:54Z

src/libs/actions/Report.ts

        }
    }

+    // A guide is assigned to the user if they choose the 'MANAGE_TEAM' onboarding option, except for users with emails containing '+'.


@c3024 Also could you make this one similarly more concise.

jjcoffee · 2024-11-27T09:21:37Z

@yuwenmemon Just to check the expected result, if we're offline before CreateWorkspace, here's what we'll get:

c3024 · 2024-11-27T10:32:47Z

@yuwenmemon Just to check the expected result, if we're offline before CreateWorkspace, here's what we'll get:

If we go offline before receiving the CreateWorkspace response, we do not have the guide's email. So, I used the "Setup Specialist" as the placeholder name for this case because I saw in some cases, the guide's name is shown as "Setup Specialist - <Guide's name>". Let me know if we wanna use a different placeholder.

jjcoffee

All good from my side, just this comment for you to check @yuwenmemon.

yuwenmemon · 2024-12-02T19:09:38Z

Think that's fine for now yeah!

OSBotify · 2024-12-02T19:18:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-02T22:02:15Z

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.70-0 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2024-12-03T10:19:16Z

@c3024 PR is fail with issue #53431

https://utest-dl.s3-accelerate.amazonaws.com/12102/26469/484909/6682554/bugAttachment/Bug6682554_1733192982196%21Screen_Recording_20241203_102616_Expensify.mp4?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20241203T101847Z&X-Amz-SignedHeaders=host&X-Amz-Credential=AKIAJ2UIWMJ2OMC3UCQQ%2F20241203%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Expires=86400&X-Amz-Signature=41399135f9f2b08fce931cdbf6d00734ea6f43ea958b420a527b755795a61dea

github-actions · 2024-12-04T01:11:29Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.70-9 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

c3024 added 8 commits November 8, 2024 18:08

wip-move-tasks-to-admin-2

d95b51f

fix qa guide personal detail

bb9c312

Merge branch 'main' into wip-move-tasks-to-admin-2

d993935

troubleshoot LHN alternate text

d27f273

troubleshoot LHN alternate text

3b31e9f

Merge branch 'main' into wip-move-tasks-to-admin-2

7412464

fix optimistic lhn message for admins room

ff29d0d

fix lint

8872ba1

c3024 changed the title ~~[WIP] Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room~~ Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room Nov 12, 2024

c3024 added 2 commits November 12, 2024 21:29

rename QA_GUIDE

9b83bf7

fix lint

528b1ac

yuwenmemon requested changes Nov 12, 2024

View reviewed changes

c3024 added 5 commits November 15, 2024 08:23

Merge branch 'main' into wip-move-tasks-to-admin-2

3f3bf16

Merge branch 'main' into wip-move-tasks-to-admin-2

45b5d17

currentUserAccountID as actor

c0ee29f

Revert "currentUserAccountID as actor"

25801d2

This reverts commit c0ee29f.

remove redundant optimistic introduction message

b2b933d

c3024 marked this pull request as ready for review November 19, 2024 06:35

c3024 requested a review from a team as a code owner November 19, 2024 06:35

melvin-bot bot requested review from jjcoffee and removed request for a team November 19, 2024 06:35

c3024 commented Nov 19, 2024

View reviewed changes

c3024 added 3 commits November 19, 2024 17:35

remove introduction message

ff16699

retain existing introductory video

39dbcc7

Merge branch 'main' into wip-move-tasks-to-admin-2

1a6df41

This comment was marked as resolved.

Sign in to view

c3024 added 3 commits November 26, 2024 13:07

fix missing and unused values

de2b8b2

remove optimstic video to avoid duplication

6ec519f

remove duplication of messages

3d31534

jjcoffee reviewed Nov 27, 2024

View reviewed changes

c3024 added 2 commits November 27, 2024 15:43

Merge branch 'main' into wip-move-tasks-to-admin-2

d70d159

make comments concise

5c1618e

jjcoffee approved these changes Nov 27, 2024

View reviewed changes

melvin-bot bot requested a review from yuwenmemon November 27, 2024 10:37

yuwenmemon approved these changes Dec 2, 2024

View reviewed changes

yuwenmemon merged commit 473822d into Expensify:main Dec 2, 2024

github-actions bot mentioned this pull request Dec 2, 2024

Deploy Checklist: New Expensify 2024-12-02 #53406

Closed

48 tasks

techievivek mentioned this pull request Dec 3, 2024

[HOLD for payment 2024-12-12] Android & iOS - App crashes after completing onboarding #53431

Closed

8 tasks

jjcoffee mentioned this pull request Dec 3, 2024

Onboarding - Onboarding tasks arenot moved to admins room in manage teams expenses #53450

Closed

8 tasks

melvin-bot bot mentioned this pull request Dec 4, 2024

[HOLD for payment 2024-12-20] [HOLD for payment 2024-12-11] [$250] Move onboarding tasks into the #admins room for admins #51443

Closed

6 tasks

yuwenmemon mentioned this pull request Dec 4, 2024

Revert "Optimistic update for moving tasks for "Manage Team's Expenses" to #admins room" #53598

Merged

This was referenced Dec 6, 2024

Revert revert moving tasks to admins room for "Manage my team expenses" intent #53661

Merged

[HOLD for payment 2025-01-28] [$250] Onboarding - "Start a free trial" banner and button appear in Concierge then disappear #53526

Closed

c3024 mentioned this pull request Jan 9, 2025

Move free trial banner to #admins room for users selecting MANAGE_TEAM onboarding intent #53895

Merged

50 tasks

francoisl mentioned this pull request Jan 17, 2025

add tasks for new user first workspace #55302

Merged

50 tasks


		const [allPersonalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST);

		const setOptimticQAGuidePersonalDetail = () => {

Conversation

c3024 commented Nov 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

c3024 commented Nov 12, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Nov 19, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c3024 Nov 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjcoffee commented Nov 19, 2024

Uh oh!

c3024 commented Nov 19, 2024

Uh oh!

This comment was marked as resolved.

c3024 commented Nov 26, 2024

Uh oh!

jjcoffee commented Nov 26, 2024

Uh oh!

yuwenmemon commented Nov 26, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jjcoffee commented Nov 27, 2024

Uh oh!

c3024 commented Nov 27, 2024

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

yuwenmemon commented Dec 2, 2024

Uh oh!

OSBotify commented Dec 2, 2024

Uh oh!

github-actions bot commented Dec 2, 2024

Uh oh!

izarutskaya commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

c3024 commented Nov 11, 2024 •

edited

Loading

c3024 Nov 23, 2024 •

edited

Loading

izarutskaya commented Dec 3, 2024 •

edited

Loading